You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Rooms- Number of members shown as "1 member" in admins/WS rooms when user sign in back #92103
Version Number: v9.3.89-3 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#91056 Email or phone of affected tester (no customers):applausetester+ck52826@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Windows 11/Chrome, Pixel 8a/Android 16, Iphone 16/18.7.1 App Component: Workspace Settings
Action Performed:
Precondition:
Admin has workspaces & has created rooms in some workspaces. Added few members to WS rooms
Navigate to staging.new.expensify.com
Go to WS settings >> # Rooms
Observe the actual number of members in #admins & workspace rooms
Sign out & sign in back
Go to WS settings >> # Rooms
Observe the number of members shown as "1 member" in #admins & workspace rooms
Expected Result:
Correct numbers to members that were added should be displayed in #admins & workspace rooms after logging in back
Actual Result:
Number of members always shown as "1 member" in admins/WS rooms when user sign in back though there are more members added
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The new rooms table introduced by PR #91056 computes each row's memberCount from report.participants via getParticipantsAccountIDsForDisplay, but report.participants for chat rooms is only fully hydrated after OpenReport (or a Pusher membership push) has been processed for that specific room.
The new OpenPolicyRoomsPage read command only sends {policyID} and the App has no client-side merge that primes per‑room participants. After sign‑out (Onyx wiped) + sign‑in, OpenApp rehydrates the chat-room stubs with only the current user in participants, so WorkspaceRoomsPage.tsx:67 collapses every row to 1 member.
Before sign‑out the count looked right only because the user had visited those rooms during the session — each OpenReport backfilled participants — but that state is derived, not persisted, and is lost across the sign‑in cycle.
Investigation details
Data flow that produces the bug
Sign‑in → OpenApp populates the reports_* collection with minimal chat‑room stubs (participants only contains the current account).
The request payload is just {policyID} (OpenPolicyRoomsPageParams.ts) and there's no client‑side success handler that writes per‑room participants into Onyx.
The selector policyChatRoomsSelector projects whatever Onyx already contains — it can't invent participants that aren't there.
Each row computes memberCount: getParticipantsAccountIDsForDisplay(report, true, false, false, undefined, personalDetails).length (WorkspaceRoomsPage.tsx:67). With an effectively empty participants map, this returns [currentUserAccountID] and the row renders "1 member".
Why the symptom is "1 member" (not "0 members")
getParticipantsAccountIDsForDisplay always includes the current account when participants contains it as the lone stub, hence the floor of 1.
Where the fix needs to land
The minimum‑risk, frontend‑only mitigation is in the new App code. However, the correct long‑term fix is to have OpenPolicyRoomsPage return participant data for every room and merge it into the reports collection — that work spans both Expensify/App (response handling / success data merge) and Expensify/Web-Expensify (backend command).
What changes do you think we should make in order to solve the problem?
Make OpenPolicyRoomsPage return participants for every room on the page and merge them into Onyx so the table can read an accurate count regardless of whether the user has visited the room.
Concretely, on the App side:
Add a successData (or response merge) to openPolicyRoomsPage in src/libs/actions/Policy/Room.ts that writes per‑room participants (or a precomputed participantsList / participantCount) into the reports_* collection.
In WorkspaceRoomsPage.tsx:67, prefer that returned field (e.g. report.participantCount ?? getParticipantsAccountIDsForDisplay(...).length). As a defensive UI choice, when no count is available render a skeleton/— rather than the misleading 1 member.
This requires a corresponding backend change in Expensify/Web-Expensify to make OpenPolicyRoomsPage actually return that data. That part is outside the Expensify/App repo and needs to be picked up by an internal Expensify engineer.
Until the backend ships, a low‑risk client‑only stopgap is to render — (or hide the column) when participants only contains the current user, so the UI no longer asserts an incorrect "1 member".
What alternative solutions did you explore? (Optional)
Fire OpenReport for every room on mount. Would hydrate participants but is wasteful (N requests, defeats the purpose of a single rooms‑page read) and breaks the design intent of the new endpoint.
Read from report.participantsList instead of participants.participantsList is a legacy denormalized field that isn't reliably populated for chat rooms in OpenApp either, so this would only partially mask the bug.
Cache the previous session's participants in Onyx across sign‑out. Wrong direction — Onyx wipe on sign‑out is intentional, and stale participant lists would create worse bugs than the current one.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/92103) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Note: the fully correct fix also requires backend work in Expensify/Web-Expensify (to make OpenPolicyRoomsPage return per‑room participants). MelvinBot cannot implement that — an internal Expensify engineer needs to pair the App-side change with the backend change.
@grgia@shubham1206agra@sumo-slonik this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
applause-bot commentedon May 29, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/9e546901308864aad700d9b4a3741f74b24bf3b029b3deaabf1fa53b051e7c98
melvin-bot commentedon May 29, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #91056
melvin-bot commentedon May 29, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon May 29, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon May 29, 2026
Proposal
What is the root cause of that problem?
The new rooms table introduced by PR #91056 computes each row's
memberCountfromreport.participantsviagetParticipantsAccountIDsForDisplay, butreport.participantsfor chat rooms is only fully hydrated afterOpenReport(or a Pusher membership push) has been processed for that specific room.The new
OpenPolicyRoomsPageread command only sends{policyID}and the App has no client-side merge that primes per‑room participants. After sign‑out (Onyx wiped) + sign‑in,OpenApprehydrates the chat-room stubs with only the current user inparticipants, soWorkspaceRoomsPage.tsx:67collapses every row to1 member.Before sign‑out the count looked right only because the user had visited those rooms during the session — each
OpenReportbackfilledparticipants— but that state is derived, not persisted, and is lost across the sign‑in cycle.Investigation details
Data flow that produces the bug
OpenApppopulates thereports_*collection with minimal chat‑room stubs (participantsonly contains the current account).WorkspaceRoomsPagemounts → firesopenPolicyRoomsPage(policyID)(Room.ts:6).{policyID}(OpenPolicyRoomsPageParams.ts) and there's no client‑side success handler that writes per‑roomparticipantsinto Onyx.policyChatRoomsSelectorprojects whatever Onyx already contains — it can't invent participants that aren't there.memberCount: getParticipantsAccountIDsForDisplay(report, true, false, false, undefined, personalDetails).length(WorkspaceRoomsPage.tsx:67). With an effectively emptyparticipantsmap, this returns[currentUserAccountID]and the row renders "1 member".Why the symptom is "1 member" (not "0 members")
getParticipantsAccountIDsForDisplayalways includes the current account whenparticipantscontains it as the lone stub, hence the floor of 1.Where the fix needs to land
The minimum‑risk, frontend‑only mitigation is in the new App code. However, the correct long‑term fix is to have
OpenPolicyRoomsPagereturn participant data for every room and merge it into thereportscollection — that work spans bothExpensify/App(response handling / success data merge) andExpensify/Web-Expensify(backend command).What changes do you think we should make in order to solve the problem?
Make
OpenPolicyRoomsPagereturn participants for every room on the page and merge them into Onyx so the table can read an accurate count regardless of whether the user has visited the room.Concretely, on the App side:
successData(or response merge) toopenPolicyRoomsPageinsrc/libs/actions/Policy/Room.tsthat writes per‑roomparticipants(or a precomputedparticipantsList/participantCount) into thereports_*collection.WorkspaceRoomsPage.tsx:67, prefer that returned field (e.g.report.participantCount ?? getParticipantsAccountIDsForDisplay(...).length). As a defensive UI choice, when no count is available render a skeleton/—rather than the misleading1 member.This requires a corresponding backend change in
Expensify/Web-Expensifyto makeOpenPolicyRoomsPageactually return that data. That part is outside theExpensify/Apprepo and needs to be picked up by an internal Expensify engineer.Until the backend ships, a low‑risk client‑only stopgap is to render
—(or hide the column) whenparticipantsonly contains the current user, so the UI no longer asserts an incorrect "1 member".What alternative solutions did you explore? (Optional)
OpenReportfor every room on mount. Would hydrateparticipantsbut is wasteful (N requests, defeats the purpose of a single rooms‑page read) and breaks the design intent of the new endpoint.report.participantsListinstead ofparticipants.participantsListis a legacy denormalized field that isn't reliably populated for chat rooms inOpenAppeither, so this would only partially mask the bug.participantsin Onyx across sign‑out. Wrong direction — Onyx wipe on sign‑out is intentional, and stale participant lists would create worse bugs than the current one.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/92103)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
7 remaining items
grgia commentedon Jun 9, 2026
@shubham1206agra working on it https://github.com/Expensify/Auth/pull/21965/changes.
sumo-slonik commentedon Jun 9, 2026
This looks related to #92054 (same
OpenPolicyRoomsPagedata gap). @grgia does your backend fix there (https://github.com/Expensify/Auth/pull/21965) also return the realownerAccountIDper room? If so it would likely fix this "Created By" issue too.melvin-bot commentedon Jun 9, 2026
@shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jun 11, 2026
@shubham1206agra Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Jun 12, 2026
@grgia @shubham1206agra @sumo-slonik this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
shubham1206agra commentedon Jun 15, 2026
@grgia is working on this
grgia commentedon Jun 15, 2026
Yep awaiting review.
grgia commentedon Jun 18, 2026
Confirmed fixed