Skip to content

[Due for payment 2026-06-22] Home - Left navigation bar disappears after completing onboarding #92409

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.91-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #91856
Email or phone of affected tester (no customers): jsodinjosdjsoinjsiojs@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Overview.
  3. Refresh the page twice.
  4. Go to Account > Sign out.
  5. Log in with a new Gmail account.
  6. Select Something else and complete onboarding.

Expected Result:

After completing onboarding, left navigation bar will not disappear.

Actual Result:

After completing onboarding, left navigation bar disappears.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7169688_1780412932414.14.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7169688

Issue OwnerCurrent Issue Owner: @borys3kk

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 2, 2026
  2. applause-bot commented on Jun 2, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/3cdf4702eda22bbde7e38baeab2c1c6f23a13935989c118ab005b5fd807c900a

  3. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #91856

  4. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 2, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 2, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    This is a regression from #91856 (merged 2026-06-01, on staging in 9.3.91 — matches "reproducible in staging, not production").

    The wide‑layout tab bar container (tabNavigatorBarContainer) uses a negative marginRight to overlap the central pane, so it depends on zIndex: 1 to stay painted above that content. PR #91856 changed that zIndex from unconditional to conditional:

    - style={[styles.tabNavigatorBarContainer]}                          // zIndex:1 always
    + style={[styles.tabNavigatorBarContainer, !isBlockingViewVisible && {zIndex: 1}]}

    So whenever isBlockingViewVisible === true in wide layout, the container loses its stacking context and the central pane paints over the left nav bar → it disappears (TabNavigatorBar.tsx:86).

    isBlockingViewVisible is global — true whenever any route has a ForceFullScreenView key registered (context provider) — and that provider is mounted above the auth boundary (App.tsx:115), so its state survives sign‑out/sign‑in. In the repro, Workspace Settings → Overview registers a key via its FullPageNotFoundView (WorkspaceInitialPage.tsx:469); that stale key isn't reliably cleared by the time the new user finishes onboarding and lands on Home, so Home renders with isBlockingViewVisible === true and the nav bar is hidden.

    What changes do you think we should make in order to solve the problem?

    Deploy‑blocker fix: restore the unconditional zIndex: 1 on tabNavigatorBarContainer (revert the conditional from PR #91856). This immediately brings the nav bar back regardless of blocking‑view state. The original goal of that PR — the back button hidden on the "Hmm... it's not here" page (#91831) — should be re‑approached with a change scoped to the DebugTabView / blocking‑view region, rather than dropping the stacking context for the entire wide‑layout tab navigator.

    Follow‑up (separate, not a blocker): make isBlockingViewVisible unable to stay true on a screen that has no blocking view — e.g. scope the flag to the focused route, or guarantee route keys are removed across sign‑out — so the underlying leak can't resurface through other flows.

    What alternative solutions did you explore? (Optional)

    Full revert of PR #91856 (simplest, safest for the blocker; it re‑opens the lower‑severity #91831).

    Investigation details & evidence

    Mechanism (high confidence): tabNavigatorBarContainer width = navigationTabBarSize + sideBarWithLHBWidth with marginRight: -sideBarWithLHBWidth, pulling the central pane to overlap. Equal/auto zIndex means the later‑rendered central pane paints on top → nav bar covered. zIndex: 1 is what kept the nav bar on top before the PR.

    Why isBlockingViewVisible is stuck true (medium confidence): route keys are added/removed in ForceFullScreenView. The cleanup closes over the correct route.key, so the leak isn't an obvious key‑mismatch — it's that the provider lives above the auth boundary and a key from the pre‑sign‑out Workspace Overview visit persists into the new session. The narrow‑layout use of isBlockingViewVisible (the shouldHide calc at TabNavigatorBar.tsx:44) pre‑dates this PR; PR #91856 newly extended the "hide when blocking view visible" behavior to wide layout via zIndex, which is where the regression lives.

    Note: DebugTabView is the brick‑road status indicator (a production feature with a "View" button), not a debug‑only overlay, so the original PR was solving a real user‑facing layout issue — the coupling to the whole tab navigator's zIndex is what overreached.

    Possibly related: #90932 ("Web - Left navigation bar disappears after switching to delegator account") shows the same symptom but was reported 2026‑05‑18, before PR #91856 — so it's likely a separate/underlying trigger of the same isBlockingViewVisible problem, worth cross‑referencing when doing the follow‑up.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/92409) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. luacmartins commented on Jun 2, 2026

    @luacmartins
    Contributor

    As stated, the steps seem like a big edge case. Gonna demote.

  8. added and removed on Jun 3, 2026
  9. 15 remaining items

  10. changed the title [-]Home - Left navigation bar disappears after completing onboarding[/-] [+][Due for payment 2026-06-22] Home - Left navigation bar disappears after completing onboarding[/+] on Jun 15, 2026
  11. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.7-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-22. 🎊

    For reference, here are some details about the assignees on this issue:

    • @borys3kk does not require payment (Contractor)
  13. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    @JS00001 @borys3kk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. melvin-bot commented on Jun 18, 2026

    @melvin-bot

    @borys3kk Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  15. melvin-bot commented on Jun 22, 2026

    @melvin-bot

    @borys3kk Still overdue 6 days?! Let's take care of this!

  16. borys3kk commented on Jun 23, 2026

    @borys3kk
    Contributor

    pr fixing the issue has been merged

  17. melvin-bot commented on Jun 26, 2026

    @melvin-bot

    @borys3kk Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions