You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-13] Infinite loading on Choose BA page when re-enable network during re-adding BA flow #92726
Version Number: v9.3.99-3 Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod - Provide reasoning. If this was caught during regression testing, add the test name, ID and link from BrowserStack:#91491 Email or phone of affected tester (no customers):kiatest.78+ck6426@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Windows 11/Chrome, iPhone 16/18.7.1 App Component: Workspace Settings
Action Performed:
Precondition:
Logged in as new user >> Create new WS & go through adding Plaid BA in Workflows >> Payments step
Disconnect the added BA
Launch Hybrid app or Navigate to staging.new.expensify.com
Go to Workflows >> Payments step >> Add bank account >> Log into your bank >> Finish the Plaid flow
Select the same BA as selected in precondition (in this case Plaid saving)
Verify the error "Bank account can't be created, it looks like a bank account with the same information already exists in your account." appears above the Next button.
Go offline (either toggle airplane mode or force offline in debug menu
Go online
Observe user automatically redirected to Personal info page
Tap back button on personal info page
Expected Result:
Choose BA options displayed in bank info page when user navigate back from personal info page after re-enabling network during re-adding BA flow
Actual Result:
Infinite loading on Choose BA page without displaying the bank account options when re-enable network during re-adding BA flow
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
TL;DR — this deploy blocker is very likely not caused by Expensify/App#91491 (the auto-assigned PR). Reverting that PR would only re-introduce the duplicate-error bug it fixed; it would not fix this infinite loading. Confidence: high on that point, medium on the precise root cause below.
Why #91491 is not the culprit: that PR's only behavioral change is gating whenhideBankAccountErrors() runs. hideBankAccountErrors() only does Onyx.merge(REIMBURSEMENT_ACCOUNT, {error: '', errors: null}) — it never touches isLoading, plaidData, or navigation (ReimbursementAccount/index.ts:22-24). The infinite spinner is driven entirely by isLoading flags, so changing error-clearing timing can't cause it.
Root cause (hypothesis): The "Choose an account" spinner is the in-component one in AddPlaidBankAccount.tsx:232-242, which renders when plaidData.bankAccounts is empty andplaidData.isLoading is true. On returning to the Plaid step after the offline→online refetch, plaidData.bankAccounts is empty, so the mount effect re-calls openPlaidBankLogin (AddPlaidBankAccount.tsx:138-150). That action optimistically SETs plaidData = {...DEFAULT_DATA, isLoading: true} (wiping accounts) but has no successData to flip isLoading back to false — unlike its sibling openPlaidBankAccountSelector (Plaid.ts:15-57 vs :101-141). If the OpenPlaidBankLogin response doesn't yield a link token that re-renders PlaidLink, isLoading stays true forever → infinite spinner with no accounts.
Recommended fix: Add a successData block to openPlaidBankLogin that merges plaidData.isLoading: false (mirroring openPlaidBankAccountSelector). Before implementing, an internal engineer should confirm via repro/logs (a) that plaidData.bankAccounts is empty on return to the Plaid step (likely wiped by the OPEN_REIMBURSEMENT_ACCOUNT_PAGE re-fetch response) and (b) that OpenPlaidBankLogin returns without a usable link token in this path.
Investigation details
Repro recap: duplicate-account error shown on the Plaid "Choose an account" step → go offline → online → auto-redirected to Personal info (REQUESTOR) → tap Back → infinite spinner on Choose BA page, no accounts.
The two possible spinners:
Page-level ReimbursementAccountLoadingIndicator — driven by reimbursementAccount.isLoading. openReimbursementAccountPage resets this via successData, so this is not the stuck one.
In-component ActivityIndicator — driven by plaidData.isLoading + empty bankAccounts. This matches the symptom "Choose BA page without the bank account options".
Back from REQUESTOR → goToWithdrawalAccountSetupStep(BANK_ACCOUNT) (:409-414); AddPlaidBankAccount remounts.
isAuthenticatedWithPlaid() is false (empty bankAccounts, no OAuth token, and the duplicate error lives on reimbursementAccount.errors, not plaidData.errors) → mount effect calls openPlaidBankLogin → isLoading stuck true (no successData).
CONST.PLAID.DEFAULT_DATA.bankAccounts = [] (CONST/index.ts:3533-3539) confirms the optimistic SET wipes the list.
Alternatives considered: (1) Page-level reimbursementAccount.isLoading stuck — ruled out, openReimbursementAccountPage has successData. (2) A different PR in the same release regressed the Plaid VBBA offline flow — worth a glance is the commit "avoid resetting Plaid data to prevent getting stuck when returning to the start of the VBBA flow", which targets the same symptom family. (3) The OPEN_REIMBURSEMENT_ACCOUNT_PAGE response itself resetting plaidData server-side (needs log confirmation).
Open question needing logs/repro: exactly what empties plaidData.bankAccounts on the return trip. The missing successData explains why the resulting spinner is infinite rather than transient regardless.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/92726) to create a draft PR (adds successData to openPlaidBankLogin). To refine:@MelvinBot <your feedback> — e.g. if logs show plaidData is cleared elsewhere. To reject: Explain why this analysis is off-base.
Issue is still reproducible on Windows 11 / Chrome in v9.3.99-7.
Note:
On step 6, the "An unexpected error..." appears instead of "Bank account can't be created, it looks like a bank account with the same information already exists in your account."
In Prod, User is not automatically redirected to Personal info page, but the green button have infinite loading.
Then if tap back, there is not infinite loading on the RHP.
Prod_Staging_retest.mp4
Stg - issue is still reproducible on iPhone 7 Plus / iOS 15.8.3 in v9.3.99-8
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.27-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
applause-bot commentedon Jun 4, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/0370de4076d63d93132a80457b3dadf6d5763e3b9b267edad350b8b3cedeee1e
melvin-bot commentedon Jun 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #91491
melvin-bot commentedon Jun 4, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 4, 2026
Issue Analysis
Why #91491 is not the culprit: that PR's only behavioral change is gating when
hideBankAccountErrors()runs.hideBankAccountErrors()only doesOnyx.merge(REIMBURSEMENT_ACCOUNT, {error: '', errors: null})— it never touchesisLoading,plaidData, or navigation (ReimbursementAccount/index.ts:22-24). The infinite spinner is driven entirely byisLoadingflags, so changing error-clearing timing can't cause it.Root cause (hypothesis): The "Choose an account" spinner is the in-component one in
AddPlaidBankAccount.tsx:232-242, which renders whenplaidData.bankAccountsis empty andplaidData.isLoadingistrue. On returning to the Plaid step after the offline→online refetch,plaidData.bankAccountsis empty, so the mount effect re-callsopenPlaidBankLogin(AddPlaidBankAccount.tsx:138-150). That action optimisticallySETsplaidData = {...DEFAULT_DATA, isLoading: true}(wiping accounts) but has nosuccessDatato flipisLoadingback tofalse— unlike its siblingopenPlaidBankAccountSelector(Plaid.ts:15-57vs:101-141). If theOpenPlaidBankLoginresponse doesn't yield a link token that re-rendersPlaidLink,isLoadingstaystrueforever → infinite spinner with no accounts.Recommended fix: Add a
successDatablock toopenPlaidBankLoginthat mergesplaidData.isLoading: false(mirroringopenPlaidBankAccountSelector). Before implementing, an internal engineer should confirm via repro/logs (a) thatplaidData.bankAccountsis empty on return to the Plaid step (likely wiped by theOPEN_REIMBURSEMENT_ACCOUNT_PAGEre-fetch response) and (b) thatOpenPlaidBankLoginreturns without a usable link token in this path.Investigation details
Repro recap: duplicate-account error shown on the Plaid "Choose an account" step → go offline → online → auto-redirected to Personal info (REQUESTOR) → tap Back → infinite spinner on Choose BA page, no accounts.
The two possible spinners:
ReimbursementAccountLoadingIndicator— driven byreimbursementAccount.isLoading.openReimbursementAccountPageresets this viasuccessData, so this is not the stuck one.ActivityIndicator— driven byplaidData.isLoading+ emptybankAccounts. This matches the symptom "Choose BA page without the bank account options".Flow:
fetchData(true)→openReimbursementAccountPage(ReimbursementAccountPage.tsx:298-300); backend advancescurrentStepto REQUESTOR. The auto-redirect to Personal info is the existingUSDBankAccountStep/achData.currentStepsync (:264-282) — pre-existing, unrelated to Surface duplicate Plaid bank account error on USD VBBA flow #91491.goToWithdrawalAccountSetupStep(BANK_ACCOUNT)(:409-414);AddPlaidBankAccountremounts.isAuthenticatedWithPlaid()isfalse(emptybankAccounts, no OAuth token, and the duplicate error lives onreimbursementAccount.errors, notplaidData.errors) → mount effect callsopenPlaidBankLogin→isLoadingstucktrue(nosuccessData).CONST.PLAID.DEFAULT_DATA.bankAccounts = [](CONST/index.ts:3533-3539) confirms the optimisticSETwipes the list.Alternatives considered: (1) Page-level
reimbursementAccount.isLoadingstuck — ruled out,openReimbursementAccountPagehassuccessData. (2) A different PR in the same release regressed the Plaid VBBA offline flow — worth a glance is the commit "avoid resetting Plaid data to prevent getting stuck when returning to the start of the VBBA flow", which targets the same symptom family. (3) TheOPEN_REIMBURSEMENT_ACCOUNT_PAGEresponse itself resettingplaidDataserver-side (needs log confirmation).Open question needing logs/repro: exactly what empties
plaidData.bankAccountson the return trip. The missingsuccessDataexplains why the resulting spinner is infinite rather than transient regardless.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/92726)to create a draft PR (addssuccessDatatoopenPlaidBankLogin).To refine:
@MelvinBot <your feedback>— e.g. if logs showplaidDatais cleared elsewhere.To reject: Explain why this analysis is off-base.
youssef-lr commentedon Jun 4, 2026
CP https://expensify.slack.com/archives/C07J32337/p1780605937377909
IuliiaHerets commentedon Jun 5, 2026
Issue is still reproducible on Windows 11 / Chrome in v9.3.99-7.
Note:
On step 6, the "An unexpected error..." appears instead of "Bank account can't be created, it looks like a bank account with the same information already exists in your account."
bandicam.2026-06-05.14-54-39-519.mp4
IuliiaHerets commentedon Jun 5, 2026
In Prod, User is not automatically redirected to Personal info page, but the green button have infinite loading.
Then if tap back, there is not infinite loading on the RHP.
Prod_Staging_retest.mp4
Stg - issue is still reproducible on iPhone 7 Plus / iOS 15.8.3 in v9.3.99-8
Repro_Infinite.loading.mp4
lakchote commentedon Jun 5, 2026
@MelvinBot what is the offending PR for this issue?
41 remaining items
melvin-bot commentedon Jul 13, 2026
@youssef-lr Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Jul 15, 2026
@youssef-lr 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
dmkt9 commentedon Jul 16, 2026
@youssef-lr We haven't processed the payment for that PR yet. cc @mallenexpensify
mallenexpensify commentedon Jul 16, 2026
Payment Summary
Contributor+: @dmkt9 paid $250 via Upwork
^ Test case created. Thx
dmkt9 commentedon Jul 22, 2026
@mallenexpensify I am still receiving payments through Upwork. Thanks.
mallenexpensify commentedon Jul 22, 2026
@dmkt9 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022079986280366749180
dmkt9 commentedon Jul 23, 2026
@mallenexpensify Thanks. I've accepted the offer
mallenexpensify commentedon Jul 23, 2026
@dmkt9 paid, summary updated above. Thx.