You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-17] Workspace - "Copy in progress..." & "All set!" modal cannot be dismissed by clicking outside #92873
Version Number: 9.4.0-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#91368 Email or phone of affected tester (no customers):applausetester+ssndjois2jd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Create two workspaces - A and B.
Go to staging.new.expensify.com
Go to Workspaces.
Click 3-dot menu on Workspace A > Copy settings.
Select Workspace B > Next.
Select Categories > Next.
Click Copy settings.
Click outside "Copy in progress..." modal.
Click outside "All set!" modal.
Expected Result:
"Copy in progress..." and "All set!" modal can be dismissed by clicking outside the modal (similar to other similar modals in the app).
Actual Result:
"Copy in progress..." and "All set!" modal cannot be dismissed by clicking outside the modal.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
When you click outside a ConfirmModal, the backdrop press flows to the Modal's onClose handler (ConfirmModal.tsx:186), which is wired to onCancel. The base modal only falls back to onClose when no onBackdropPress is supplied (BaseModal.tsx:190-194).
For both flagged steps, onCancel is a no-op:
"Copy in progress…" step → onCancel: () => {} (:55-60)
So clicking outside calls a no-op that never changes the Onyx step, isVisible stays true, and the modal can't be dismissed. (Only the "Notify me when it's done" Concierge step at :63-79 wires onCancel to clearCopyPolicySettings(), which is why that one can be dismissed.)
What changes do you think we should make in order to solve the problem?
Wire the backdrop-dismiss handler to the appropriate state-clearing action for each step, mirroring what the buttons already do:
"All set!" step: set onCancel to clearCopyPolicySettings() — the same action the Done button calls in onConfirm (:39-43). Dismissing the final confirmation is unambiguous.
"Copy in progress…" step: decide the intended outcome of clicking outside while a copy is running. Cleanest option that matches the in-modal control is to mirror the "Notify me" button (requestCopyPolicySettingsNotification() + advance to the Complete step), so the copy keeps running in the background. Alternatively, if product wants outside-click to be a true cancel, call clearCopyPolicySettings().
Note: ConfirmModal already exposes a dedicated onBackdropPress prop (ConfirmModal.tsx:187) if the team wants backdrop-dismiss to differ from the buttons' onCancel.
This needs a product call on the in-progress step's behavior before implementing — the "All set!" fix is straightforward.
What alternative solutions did you explore? (Optional)
If the product intent is that these progress modals should be intentionally non-dismissible (some apps block dismissal while an operation runs), then this is working as designed and the issue should be closed as a QA expectation mismatch rather than a bug. The expected result in the report ("similar to other similar modals in the app") suggests dismissal is wanted, but that's worth confirming.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/92873) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
This issue has not been updated in over 15 days. @carlosmiceli, @fedirjh eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
applause-bot commentedon Jun 7, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/2c110fe731ec31a77115b37169a7af2773061815da7def2d76d3b4f911b84443
melvin-bot commentedon Jun 7, 2026
@yuwenmemon recently merged #91368, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Jun 7, 2026
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 7, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 7, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 7, 2026
Proposal
What is the root cause of that problem?
The progress modal's visibility is driven entirely by Onyx state (
copyPolicySettings.currentStep), not by an internalisVisibleflag:CopyPolicySettingsProgressModal.tsx:22-24When you click outside a
ConfirmModal, the backdrop press flows to theModal'sonClosehandler (ConfirmModal.tsx:186), which is wired toonCancel. The base modal only falls back toonClosewhen noonBackdropPressis supplied (BaseModal.tsx:190-194).For both flagged steps,
onCancelis a no-op:onCancel: () => {}(:55-60)onCancel: () => {}(:39-43)So clicking outside calls a no-op that never changes the Onyx step,
isVisiblestaystrue, and the modal can't be dismissed. (Only the "Notify me when it's done" Concierge step at:63-79wiresonCanceltoclearCopyPolicySettings(), which is why that one can be dismissed.)What changes do you think we should make in order to solve the problem?
Wire the backdrop-dismiss handler to the appropriate state-clearing action for each step, mirroring what the buttons already do:
onCanceltoclearCopyPolicySettings()— the same action the Done button calls inonConfirm(:39-43). Dismissing the final confirmation is unambiguous.requestCopyPolicySettingsNotification()+ advance to the Complete step), so the copy keeps running in the background. Alternatively, if product wants outside-click to be a true cancel, callclearCopyPolicySettings().Note:
ConfirmModalalready exposes a dedicatedonBackdropPressprop (ConfirmModal.tsx:187) if the team wants backdrop-dismiss to differ from the buttons'onCancel.This needs a product call on the in-progress step's behavior before implementing — the "All set!" fix is straightforward.
What alternative solutions did you explore? (Optional)
If the product intent is that these progress modals should be intentionally non-dismissible (some apps block dismissal while an operation runs), then this is working as designed and the issue should be closed as a QA expectation mismatch rather than a bug. The expected result in the report ("similar to other similar modals in the app") suggests dismissal is wanted, but that's worth confirming.
Introduced by & related issues
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/92873)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
carlosmiceli commentedon Jun 7, 2026
@fedirjh I see you grabbed this issue, do you think you will get a fix for it so we don't need to revert? Haven't started investigating yet.
fedirjh commentedon Jun 7, 2026
@carlosmiceli This can be demoted since it is already under Beta. I will create a fix for it.
10 remaining items
melvin-bot commentedon Jun 11, 2026
@fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jun 15, 2026
@fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Jul 6, 2026
This issue has not been updated in over 15 days. @carlosmiceli, @fedirjh eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
fedirjh commentedon Jul 7, 2026
This is done.