You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Investigate workflow job failing on main: typecheck / typecheck #93029
🐛 Error Message:
warning: [git-mirror] Skipping cache commit: Found 2 failed/cancelled steps
warning: [git-mirror] - Step: unknown (failed)
failure: Process completed with exit code 2.
failure: Expected 8-9 arguments, but got 7.
failure: Expected 8-9 arguments, but got 7.
failure: Expected 8-9 arguments, but got 7.
⚠️Action Required⚠️:
🛠️ A recent merge appears to have caused a failure in the job named typecheck / typecheck.
🔍 This issue has been automatically created and labeled with Workflow Failure for investigation.
Root Cause:Expensify/App#92756 ("Part 5: Make reportActionsList required on addMembersToWorkspace") made reportActionsList a required 8th parameter. It updated every call site that existed on its branch base — but three test call sites added later by Expensify/App#90995 (the "override the role on Submit / non-Submit workspaces" tests, merged June 5) still pass only 7 args. Since #92756's branch was never re-synced with main after #90995 merged, its typecheck never saw those calls, so they only break once both land on main. Classic stale-base merge race.
The 3 failing calls (each missing the reportActionsList arg):
Recommended Fix: Add an empty reportActionsList argument ({}) to each of the three calls, matching the other passing call sites in the same file (e.g. :379, :433-435, :606):
Typecheck error from the failing run: tests/actions/PolicyMemberTest.ts(481,20): error TS2554: Expected 8-9 arguments, but got 7. (same at 514, 557).
Signature now has 8 required params + optional approverEmail?: Member.ts:934-943.
#92756's diff does not contain the override the role test blocks — confirming those calls came from a different PR (#90995, merged 2026-06-05), not from #92756.
All other call sites in the file already pass {} or reportActionsList as the 8th arg; only these three were missed.
The fix is entirely within the Expensify/App repo (test file only).
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/93029) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Activity
Gonals commentedon Jun 9, 2026
@MelvinBot, investigate
MelvinBot commentedon Jun 9, 2026
Issue Analysis
Root Cause:
Expensify/App#92756("Part 5: MakereportActionsListrequired onaddMembersToWorkspace") madereportActionsLista required 8th parameter. It updated every call site that existed on its branch base — but three test call sites added later byExpensify/App#90995(the "override the role on Submit / non-Submit workspaces" tests, merged June 5) still pass only 7 args. Since#92756's branch was never re-synced withmainafter#90995merged, its typecheck never saw those calls, so they only break once both land onmain. Classic stale-base merge race.The 3 failing calls (each missing the
reportActionsListarg):tests/actions/PolicyMemberTest.ts:481tests/actions/PolicyMemberTest.ts:514tests/actions/PolicyMemberTest.ts:557Recommended Fix: Add an empty
reportActionsListargument ({}) to each of the three calls, matching the other passing call sites in the same file (e.g.:379,:433-435,:606):Evidence
tests/actions/PolicyMemberTest.ts(481,20): error TS2554: Expected 8-9 arguments, but got 7.(same at 514, 557).approverEmail?:Member.ts:934-943.#92756's diff does not contain theoverride the roletest blocks — confirming those calls came from a different PR (#90995, merged 2026-06-05), not from#92756.{}orreportActionsListas the 8th arg; only these three were missed.The fix is entirely within the
Expensify/Apprepo (test file only).Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/93029)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
DylanDylann commentedon Jun 9, 2026
@MelvinBot Could you raise a PR to fix this?
MelvinBot commentedon Jun 9, 2026
🤖 Draft PR created: #93043
Please mark it as "Ready for review" when it is ready for review.
DylanDylann commentedon Jun 9, 2026
@MelvinBot You are slow 😄, so I created it by myself. Please close your PR
MelvinBot commentedon Jun 9, 2026
Haha, fair enough 😄 — closed both of my duplicate PRs (#93032 and #93043) in favor of your fix in #93044. Thanks for handling it!
Gonals commentedon Jun 9, 2026
All good now