Skip to content

Investigate workflow job failing on main: typecheck / typecheck #93029

Closed

Description

@github-actions

🚨 Failure Summary 🚨:

  • 📋 Job Name: typecheck / typecheck
  • 🔧 Failure in Workflow: Process new code merged to main
  • 🔗 Triggered by PR: PR Link
  • 👤 PR Author: @DylanDylann
  • 🤝 Merged by: @Gonals
  • 🐛 Error Message:
    warning: [git-mirror] Skipping cache commit: Found 2 failed/cancelled steps
    warning: [git-mirror] - Step: unknown (failed)
    failure: Process completed with exit code 2.
    failure: Expected 8-9 arguments, but got 7.
    failure: Expected 8-9 arguments, but got 7.
    failure: Expected 8-9 arguments, but got 7.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named typecheck / typecheck.
🔍 This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

For detailed instructions, check this SO.

🐛 We appreciate your help in squashing this bug!

Activity

  1. Gonals commented on Jun 9, 2026

    @Gonals
    Contributor

    @MelvinBot, investigate

  2. MelvinBot commented on Jun 9, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    Root Cause: Expensify/App#92756 ("Part 5: Make reportActionsList required on addMembersToWorkspace") made reportActionsList a required 8th parameter. It updated every call site that existed on its branch base — but three test call sites added later by Expensify/App#90995 (the "override the role on Submit / non-Submit workspaces" tests, merged June 5) still pass only 7 args. Since #92756's branch was never re-synced with main after #90995 merged, its typecheck never saw those calls, so they only break once both land on main. Classic stale-base merge race.

    The 3 failing calls (each missing the reportActionsList arg):

    Recommended Fix: Add an empty reportActionsList argument ({}) to each of the three calls, matching the other passing call sites in the same file (e.g. :379, :433-435, :606):

    Member.addMembersToWorkspace({[newUserEmail]: 1234}, 'Welcome', policy, [], CONST.POLICY.ROLE.USER, TestHelper.formatPhoneNumber, currentUser, {});
    Evidence
    • Typecheck error from the failing run: tests/actions/PolicyMemberTest.ts(481,20): error TS2554: Expected 8-9 arguments, but got 7. (same at 514, 557).
    • Signature now has 8 required params + optional approverEmail?: Member.ts:934-943.
    • #92756's diff does not contain the override the role test blocks — confirming those calls came from a different PR (#90995, merged 2026-06-05), not from #92756.
    • All other call sites in the file already pass {} or reportActionsList as the 8th arg; only these three were missed.

    The fix is entirely within the Expensify/App repo (test file only).


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93029) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  3. DylanDylann commented on Jun 9, 2026

    @DylanDylann
    Contributor

    @MelvinBot Could you raise a PR to fix this?

  4. MelvinBot commented on Jun 9, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: #93043
    Please mark it as "Ready for review" when it is ready for review.

  5. DylanDylann commented on Jun 9, 2026

    @DylanDylann
    Contributor

    @MelvinBot You are slow 😄, so I created it by myself. Please close your PR

  6. MelvinBot commented on Jun 9, 2026

    @MelvinBot
    Contributor

    Haha, fair enough 😄 — closed both of my duplicate PRs (#93032 and #93043) in favor of your fix in #93044. Thanks for handling it!

  7. Gonals commented on Jun 9, 2026

    @Gonals
    Contributor

    All good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions