Skip to content

[Due for payment 2026-06-19] [Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page #93255

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.5-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92161
Email or phone of affected tester (no customers): iosjnnsjdosnjsodj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Run Onyx.merge('betas', ['newManualExpenseFlow']); in console.
  • Enable Taxes and Rules.
  • Enable Attendee tracking in Rules settings.
  1. Go to staging.new.expensify.com
  2. Open FAB > Create expense > Manual.
  3. Open Category.
  4. Close not here page.
  5. Open Tax field.
  6. Close not here page.
  7. Open Attendees page.

Expected Result:

Category, Tax and Attendees field will open the correct page.

Actual Result:

Category, Tax and Attendees field open not here page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7177545_1781148719582.16.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7177545

Activity

  1. applause-bot commented on Jun 11, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/8bef857e615531266283e2174b0562a7da3454fe6ea085c37dd89662441d77f0

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 11, 2026
  3. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #92161

  4. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 11, 2026

    @MelvinBot
    Contributor

    Proposal

    Root Cause: PR #92161 migrated Category / Tax / Attendees (and Accountant / Upgrade) to the new dynamic-suffix routing system, but the entryScreens allow-lists for those dynamic routes are missing the screen the new manual flow actually runs on.

    In newManualExpenseFlow, IOURequestStartPage renders the confirmation fields inline, so the focused React Navigation screen stays SCREENS.MONEY_REQUEST.CREATE (Money_Request_Create) — not STEP_CONFIRMATION. When a field is tapped, createDynamicRoute appends the dynamic suffix to the current path, and the resolver validates the focused screen against entryScreens:

    Why it lands on the "not here" page

    The entry-screen guard at getStateFromPath.ts:44 only proceeds if the focused route name is in the route's entryScreens. The four affected routes list only STEP_CONFIRMATION (+ REPORT / RIGHT_MODAL variants) and not MONEY_REQUEST.CREATE:

    Because every candidate fails validation, resolution falls through to RNGetStateFromPath at line 70, which has no static route for the combined …/start/…/category/… path and returns the NotFoundPage. (A [DynamicRoute] None of the … candidate(s) passed entryScreens validation warning is logged at the moment of failure — useful to confirm in logs.)

    What changes do you think we should make in order to solve the problem?

    Add SCREENS.MONEY_REQUEST.CREATE to the entryScreens arrays of the affected dynamic routes in src/ROUTES.ts: MONEY_REQUEST_STEP_CATEGORY, MONEY_REQUEST_STEP_TAX_RATE, MONEY_REQUEST_STEP_TAX_AMOUNT, and MONEY_REQUEST_ATTENDEE.

    Also audit MONEY_REQUEST_ACCOUNTANT (ROUTES.ts:256) and MONEY_REQUEST_UPGRADE (ROUTES.ts:275) — they were part of the same migration and reachable from the embedded confirmation, so they likely need the same entry. (MONEY_REQUEST_UPGRADE already lists HOME/INBOX/SEARCH.ROOT but still not CREATE.)

    What alternative solutions did you explore? (Optional)

    Reverting #92161 would also unblock the deploy, but the targeted entryScreens fix is much smaller and preserves the migration.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93255) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. mjasikowski commented on Jun 11, 2026

    @mjasikowski
    Contributor

    PR reverted

  8. IuliiaHerets commented on Jun 11, 2026

    @IuliiaHerets

    Chrome / v9.4.5-1
    Passed

    REC-20260611220347.mp4
  9. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. changed the title [-]Expense - Category, Tax and Attendees field open not here page[/-] [+][Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page[/+] on Jun 11, 2026
  11. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-18. 🎊

  13. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    @mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. changed the title [-][Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page[/-] [+][Due for payment 2026-06-19] [Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page[/+] on Jun 12, 2026
  15. melvin-bot commented on Jun 12, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-19. 🎊

  16. melvin-bot commented on Jun 12, 2026

    @melvin-bot

    @mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions