You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-19] [Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page #93255
Version Number: 9.4.5-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92161 Email or phone of affected tester (no customers):iosjnnsjdosnjsodj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Run Onyx.merge('betas', ['newManualExpenseFlow']); in console.
Enable Taxes and Rules.
Enable Attendee tracking in Rules settings.
Go to staging.new.expensify.com
Open FAB > Create expense > Manual.
Open Category.
Close not here page.
Open Tax field.
Close not here page.
Open Attendees page.
Expected Result:
Category, Tax and Attendees field will open the correct page.
Actual Result:
Category, Tax and Attendees field open not here page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root Cause: PR #92161 migrated Category / Tax / Attendees (and Accountant / Upgrade) to the new dynamic-suffix routing system, but the entryScreens allow-lists for those dynamic routes are missing the screen the new manual flow actually runs on.
In newManualExpenseFlow, IOURequestStartPage renders the confirmation fields inline, so the focused React Navigation screen stays SCREENS.MONEY_REQUEST.CREATE (Money_Request_Create) — notSTEP_CONFIRMATION. When a field is tapped, createDynamicRoute appends the dynamic suffix to the current path, and the resolver validates the focused screen against entryScreens:
Why it lands on the "not here" page
The entry-screen guard at getStateFromPath.ts:44 only proceeds if the focused route name is in the route's entryScreens. The four affected routes list only STEP_CONFIRMATION (+ REPORT / RIGHT_MODAL variants) and notMONEY_REQUEST.CREATE:
Because every candidate fails validation, resolution falls through to RNGetStateFromPath at line 70, which has no static route for the combined …/start/…/category/… path and returns the NotFoundPage. (A [DynamicRoute] None of the … candidate(s) passed entryScreens validation warning is logged at the moment of failure — useful to confirm in logs.)
What changes do you think we should make in order to solve the problem?
Add SCREENS.MONEY_REQUEST.CREATE to the entryScreens arrays of the affected dynamic routes in src/ROUTES.ts: MONEY_REQUEST_STEP_CATEGORY, MONEY_REQUEST_STEP_TAX_RATE, MONEY_REQUEST_STEP_TAX_AMOUNT, and MONEY_REQUEST_ATTENDEE.
What alternative solutions did you explore? (Optional)
Reverting #92161 would also unblock the deploy, but the targeted entryScreens fix is much smaller and preserves the migration.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/93255) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Expense - Category, Tax and Attendees field open not here page[/-][+][Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page[/+]on Jun 11, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page[/-][+][Due for payment 2026-06-19] [Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page[/+]on Jun 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 11, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/8bef857e615531266283e2174b0562a7da3454fe6ea085c37dd89662441d77f0
melvin-bot commentedon Jun 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92161
melvin-bot commentedon Jun 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 11, 2026
Proposal
Root Cause: PR #92161 migrated Category / Tax / Attendees (and Accountant / Upgrade) to the new dynamic-suffix routing system, but the
entryScreensallow-lists for those dynamic routes are missing the screen the new manual flow actually runs on.In
newManualExpenseFlow,IOURequestStartPagerenders the confirmation fields inline, so the focused React Navigation screen staysSCREENS.MONEY_REQUEST.CREATE(Money_Request_Create) — notSTEP_CONFIRMATION. When a field is tapped,createDynamicRouteappends the dynamic suffix to the current path, and the resolver validates the focused screen againstentryScreens:Why it lands on the "not here" page
The entry-screen guard at
getStateFromPath.ts:44only proceeds if the focused route name is in the route'sentryScreens. The four affected routes list onlySTEP_CONFIRMATION(+REPORT/RIGHT_MODALvariants) and notMONEY_REQUEST.CREATE:MONEY_REQUEST_STEP_TAX_RATE— ROUTES.ts:183MONEY_REQUEST_STEP_TAX_AMOUNT— ROUTES.ts:201MONEY_REQUEST_STEP_CATEGORY— ROUTES.ts:219MONEY_REQUEST_ATTENDEE— ROUTES.ts:238Because every candidate fails validation, resolution falls through to
RNGetStateFromPathat line 70, which has no static route for the combined…/start/…/category/…path and returns the NotFoundPage. (A[DynamicRoute] None of the … candidate(s) passed entryScreens validationwarning is logged at the moment of failure — useful to confirm in logs.)What changes do you think we should make in order to solve the problem?
Add
SCREENS.MONEY_REQUEST.CREATEto theentryScreensarrays of the affected dynamic routes insrc/ROUTES.ts:MONEY_REQUEST_STEP_CATEGORY,MONEY_REQUEST_STEP_TAX_RATE,MONEY_REQUEST_STEP_TAX_AMOUNT, andMONEY_REQUEST_ATTENDEE.Also audit
MONEY_REQUEST_ACCOUNTANT(ROUTES.ts:256) andMONEY_REQUEST_UPGRADE(ROUTES.ts:275) — they were part of the same migration and reachable from the embedded confirmation, so they likely need the same entry. (MONEY_REQUEST_UPGRADEalready listsHOME/INBOX/SEARCH.ROOTbut still notCREATE.)What alternative solutions did you explore? (Optional)
Reverting #92161 would also unblock the deploy, but the targeted
entryScreensfix is much smaller and preserves the migration.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/93255)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
mjasikowski commentedon Jun 11, 2026
PR reverted
IuliiaHerets commentedon Jun 11, 2026
Chrome / v9.4.5-1
Passed
REC-20260611220347.mp4
melvin-bot commentedon Jun 11, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Expense - Category, Tax and Attendees field open not here page[/-][+][Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page[/+]melvin-bot commentedon Jun 11, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 11, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-18. 🎊
melvin-bot commentedon Jun 11, 2026
@mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-][Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page[/-][+][Due for payment 2026-06-19] [Due for payment 2026-06-18] Expense - Category, Tax and Attendees field open not here page[/+]melvin-bot commentedon Jun 12, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.6-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-19. 🎊
melvin-bot commentedon Jun 12, 2026
@mjasikowski The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]