Skip to content

92826 - Certinia - Preferred exporter is not selected by default #93273

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.4.5-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92826
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 11 / Chrome, Android 16 / Samsung Galaxy A06
App Component: Workspace Settings

Action Performed:

  1. Go to staging.expensify.com
  2. Connect a Workspace to Certinia FFA.
  3. Go to export

Expected Result:

Preferred exporters is selected by default

Actual Result:

Preferred exporters is not selected by default

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7177611_1781158430663.Recording__268.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Nathan Lemma
Bug ID: 7177611

Issue OwnerCurrent Issue Owner: @thelullabyy

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 11, 2026
  2. applause-bot commented on Jun 11, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/7a8c503ba8905e353d81fc2bffce2968ba45b028c81c6766fc70bed18a6d4ad5

  3. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #92826

  4. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nlemma commented on Jun 11, 2026

    @nlemma

    I couldn't find the PR culprit for this issue, because the Certinia accounting integration option wasn't in any of the ad hoc builds.

  7. MelvinBot commented on Jun 11, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    Root Cause: This is not caused by PR #92826, and the fix is not in the App repo. PR #92826 never touches the preferred-exporter default logic, and the App-side code is correct — it matches the QBO/NetSuite reference implementations. The "Preferred exporter" defaults to the policy owner only when that owner is returned as an admin in the policy's employee list. When the connection's export.exporter is empty (fresh FFA connect) and the policy owner isn't present as an admin in getAdminEmployees(policy), no row matches, so nothing is selected. The default export.exporter is seeded by the backend Certinia connect/sync flow, which lives outside this repo.

    This is consistent with the report being reproducible on staging but not production — production connections appear to seed a default exporter (or the owner data), while the staging FFA connect flow does not.

    Recommended next step: Escalate to an internal engineer with backend access to confirm the Certinia FFA connect/sync flow seeds a default export.exporter (and that the policy owner is returned with the ADMIN role). No App code change is warranted based on current evidence.

    Investigation details & evidence

    The App-side default logic is correct and unchanged by #92826:

    Why the default can fail to highlight: getAdminEmployees only returns members of policy.employeeList whose role === ADMIN. If export.exporter is empty and the owner isn't in that admin list, the ?? policyOwner fallback can't match any row → nothing selected.

    #92826 ruled out as the cause: The PR only changed export-status normalization, card titles (Certinia (FFA)), a "Reconnect" menu label, the offline Connect CTA, API command/param types, and renamed CERTINIA_CONFIG.COMPANY → COMPANY_ID. A repo-wide grep for the removed CERTINIA_CONFIG.COMPANY key returns zero references, and the EXPORTER key is unchanged — so the rename can't break the exporter default.

    To confirm (needs production/staging policy state): On the failing staging workspace, inspect policy.connections.financialforce.config.export.exporter, policy.owner, and the entries/roles in policy.employeeList. If staging returns an empty exporter while production seeds one, the gap is in the backend Certinia FFA connect flow.


    Next Steps for Contributor+ team:
    To refine: @MelvinBot <your feedback> (e.g., share the staging policy Onyx state for the affected workspace and I'll narrow it further).
    Note: Because the root cause appears to be backend (outside Expensify/App), @MelvinBot implement is not recommended here — this needs an internal engineer with backend access.

  8. yuwenmemon commented on Jun 11, 2026

    @yuwenmemon
    Contributor

    This is behind a beta, not a blocker.

  9. 5 remaining items

  10. melvin-bot commented on Jun 18, 2026

    @melvin-bot

    @thelullabyy Still overdue 6 days?! Let's take care of this!

  11. melvin-bot commented on Jun 22, 2026

    @melvin-bot

    @thelullabyy 10 days overdue. I'm getting more depressed than Marvin.

  12. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    @thelullabyy 12 days overdue now... This issue's end is nigh!

  13. melvin-bot commented on Jun 25, 2026

    @melvin-bot

    @yuwenmemon @ShridharGoel @thelullabyy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  14. melvin-bot commented on Jun 29, 2026

    @melvin-bot

    This issue has not been updated in over 14 days. @yuwenmemon, @ShridharGoel, @thelullabyy eroding to Weekly issue.

  15. thelullabyy commented on Jul 9, 2026

    @thelullabyy
    Contributor

    @ShridharGoel Could you please take a look at this?

  16. ShridharGoel commented on Jul 9, 2026

    @ShridharGoel
    Contributor

    @yuwenmemon This seems to need a BE fix, should I pick that?

  17. kavimuru commented on Jul 9, 2026

    @kavimuru

    @ShridharGoel bug is still reproducible in NewDot

    REC-20260709171957.mp4
  18. yuwenmemon commented on Jul 10, 2026

    @yuwenmemon
    Contributor

    @ShridharGoel yeah, go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringImprovementItem broken or needs improvement.WeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions