Skip to content

[Due for payment 2026-06-23] Expensify Card - Choose a rule page is not scrollable in landscape mode #93298

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.5-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89205
Email or phone of affected tester (no customers): applausetester+ssndjois2jd1@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Set up workspace with bank account and set up Expensify Card.
  • Enable Rules.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Expensify Card.
  3. Tap Issue card.
  4. Proceed to Step 4 of Issue card flow.
  5. Enable Add spend rule.
  6. Tap Copy existing.
  7. Tap Choose a rule.
  8. Rotate the device to landscape mode.
  9. Scroll down the empty state.

Expected Result:

Choose a rule page will be scrollable in landscape mode.

Actual Result:

Choose a rule page is not scrollable in landscape mode.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7177949_1781187358516.Screen_Recording_20260611_221249_Expensify.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7177949

Issue OwnerCurrent Issue Owner: @luacmartins

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 11, 2026
  2. applause-bot commented on Jun 11, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/0321d4f5890acb4550544ecf355c058b56872e71ba75528e053783095136c5a8

  3. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #89205

  4. melvin-bot commented on Jun 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. JS00001 commented on Jun 11, 2026

    @JS00001
    Contributor

    not a blocker, behind staging

  7. self-assigned this
    on Jun 11, 2026
  8. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 11, 2026
  9. MelvinBot commented on Jun 11, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    On the "Choose a rule" page, the empty state branch renders GenericEmptyStateComponent directly inside ScreenWrapper, with no ScrollView around it.

    EmptyStateComponent renders a View with a fixed minHeight: minModalHeight (default 400) and flexGrow1/flexShrink0. In landscape mode the available viewport height drops below that 400px content height, so the content overflows the screen — and because nothing wraps it in a scroll container, there is no way to scroll to reach it.

    The content branch (isLoadedWithContent) doesn't have this bug because it uses SelectionList, which is internally scrollable.

    Why this is the right diagnosis

    Every other page that renders this empty state wraps it in a ScrollView with contentContainerStyle={[styles.flexGrow1, styles.flexShrink0]}, exactly to handle the small-viewport/landscape case:

    SpendRuleSelectionPage is the only one of these that omits the wrapper — and it was newly added in PR #89205, which matches "N/A - new feature, doesn't exist in prod."

    What changes do you think we should make in order to solve the problem?

    Wrap the empty-state branch in SpendRuleSelectionPage.tsx in a ScrollView, mirroring the established pattern:

    • Import ScrollView from @components/ScrollView.
    • Render the isLoadedAndEmpty GenericEmptyStateComponent inside <ScrollView contentContainerStyle={[styles.flexGrow1, styles.flexShrink0]} addBottomSafeAreaPadding>.

    This makes the empty state scrollable in landscape while leaving the loading and content branches untouched.

    What alternative solutions did you explore? (Optional)

    Reducing minModalHeight would only mask the problem on some screen sizes and would still break on shorter viewports — the scroll-wrapper pattern is the correct, codebase-consistent fix.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93298) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  10. luacmartins commented on Jun 11, 2026

    @luacmartins
    Contributor

    PR in review

  11. luacmartins commented on Jun 16, 2026

    @luacmartins
    Contributor

    This is done

  12. changed the title [-]Expensify Card - Choose a rule page is not scrollable in landscape mode[/-] [+][Due for payment 2026-06-23] Expensify Card - Choose a rule page is not scrollable in landscape mode[/+] on Jun 16, 2026
  13. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.8-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-23. 🎊

  15. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    @luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions