You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-23] Expensify Card - Choose a rule page is not scrollable in landscape mode #93298
Version Number: 9.4.5-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#89205 Email or phone of affected tester (no customers):applausetester+ssndjois2jd1@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Log in with Expensifail account.
Set up workspace with bank account and set up Expensify Card.
Enable Rules.
Go to staging.new.expensify.com
Go to workspace settings > Expensify Card.
Tap Issue card.
Proceed to Step 4 of Issue card flow.
Enable Add spend rule.
Tap Copy existing.
Tap Choose a rule.
Rotate the device to landscape mode.
Scroll down the empty state.
Expected Result:
Choose a rule page will be scrollable in landscape mode.
Actual Result:
Choose a rule page is not scrollable in landscape mode.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
On the "Choose a rule" page, the empty state branch renders GenericEmptyStateComponentdirectly inside ScreenWrapper, with no ScrollView around it.
EmptyStateComponent renders a View with a fixed minHeight: minModalHeight (default 400) and flexGrow1/flexShrink0. In landscape mode the available viewport height drops below that 400px content height, so the content overflows the screen — and because nothing wraps it in a scroll container, there is no way to scroll to reach it.
The content branch (isLoadedWithContent) doesn't have this bug because it uses SelectionList, which is internally scrollable.
Why this is the right diagnosis
Every other page that renders this empty state wraps it in a ScrollView with contentContainerStyle={[styles.flexGrow1, styles.flexShrink0]}, exactly to handle the small-viewport/landscape case:
SpendRuleSelectionPage is the only one of these that omits the wrapper — and it was newly added in PR #89205, which matches "N/A - new feature, doesn't exist in prod."
What changes do you think we should make in order to solve the problem?
Wrap the empty-state branch in SpendRuleSelectionPage.tsx in a ScrollView, mirroring the established pattern:
Import ScrollView from @components/ScrollView.
Render the isLoadedAndEmptyGenericEmptyStateComponent inside <ScrollView contentContainerStyle={[styles.flexGrow1, styles.flexShrink0]} addBottomSafeAreaPadding>.
This makes the empty state scrollable in landscape while leaving the loading and content branches untouched.
What alternative solutions did you explore? (Optional)
Reducing minModalHeight would only mask the problem on some screen sizes and would still break on shorter viewports — the scroll-wrapper pattern is the correct, codebase-consistent fix.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/93298) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Expensify Card - Choose a rule page is not scrollable in landscape mode[/-][+][Due for payment 2026-06-23] Expensify Card - Choose a rule page is not scrollable in landscape mode[/+]on Jun 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.8-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 11, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/0321d4f5890acb4550544ecf355c058b56872e71ba75528e053783095136c5a8
melvin-bot commentedon Jun 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #89205
melvin-bot commentedon Jun 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
JS00001 commentedon Jun 11, 2026
not a blocker, behind staging
MelvinBot commentedon Jun 11, 2026
Proposal
What is the root cause of that problem?
On the "Choose a rule" page, the empty state branch renders
GenericEmptyStateComponentdirectly insideScreenWrapper, with noScrollViewaround it.EmptyStateComponentrenders aViewwith a fixedminHeight: minModalHeight(default 400) andflexGrow1/flexShrink0. In landscape mode the available viewport height drops below that 400px content height, so the content overflows the screen — and because nothing wraps it in a scroll container, there is no way to scroll to reach it.The content branch (
isLoadedWithContent) doesn't have this bug because it usesSelectionList, which is internally scrollable.Why this is the right diagnosis
Every other page that renders this empty state wraps it in a
ScrollViewwithcontentContainerStyle={[styles.flexGrow1, styles.flexShrink0]}, exactly to handle the small-viewport/landscape case:EmptyCardView.tsx:36-54AgentsPage.tsx:155-164WorkspaceCompanyCardsFeedAddedEmptyPage.tsx:20-33SpendRuleSelectionPageis the only one of these that omits the wrapper — and it was newly added in PR #89205, which matches "N/A - new feature, doesn't exist in prod."What changes do you think we should make in order to solve the problem?
Wrap the empty-state branch in
SpendRuleSelectionPage.tsxin aScrollView, mirroring the established pattern:ScrollViewfrom@components/ScrollView.isLoadedAndEmptyGenericEmptyStateComponentinside<ScrollView contentContainerStyle={[styles.flexGrow1, styles.flexShrink0]} addBottomSafeAreaPadding>.This makes the empty state scrollable in landscape while leaving the loading and content branches untouched.
What alternative solutions did you explore? (Optional)
Reducing
minModalHeightwould only mask the problem on some screen sizes and would still break on shorter viewports — the scroll-wrapper pattern is the correct, codebase-consistent fix.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/93298)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
luacmartins commentedon Jun 11, 2026
PR in review
luacmartins commentedon Jun 16, 2026
This is done
[-]Expensify Card - Choose a rule page is not scrollable in landscape mode[/-][+][Due for payment 2026-06-23] Expensify Card - Choose a rule page is not scrollable in landscape mode[/+]melvin-bot commentedon Jun 16, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.8-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-23. 🎊
melvin-bot commentedon Jun 16, 2026
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]