Skip to content

[Due for payment 2026-07-23] [$250] Workspace setting- Company cards page loads each time opening it #93404

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.6-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: EDGE https://github.com/Expensify/Expensify/issues/608024
Email or phone of affected tester (no customers): undefined
Issue reported by: Applause Internal Team

Action Performed:

  1. Open https://staging.new.expensify.com/
  2. Go to workspace settings.
  3. Go to Company cards.
  4. Go to Categories/any other page.
  5. Go to Company cards.

Expected Result:

In Step 5, Company cards page will not load each time opening it.

Actual Result:

In Step 5, Company cards page loads each time opening it.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7158351_1779229692257.Recording__2110.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 12, 2026
  2. MelvinBot commented on Jun 12, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    Every time the Company cards page mounts, it unconditionally re-fetches the feed and re-shows the skeleton — even when the cards are already cached in Onyx.

    The page has a useEffect that fires the feed fetch on every mount with no "already loaded" guard:

    WorkspaceCompanyCardsPage.tsx:86-88

    useEffect(() => {
        loadPolicyCompanyCardsFeed();
    }, [loadPolicyCompanyCardsFeed]);

    Contrast this with the sibling effect right above it (L70-76), which does guard with hasFeedsLoaded and skips the fetch when feeds already exist. The feed-level fetch has no equivalent guard.

    loadPolicyCompanyCardsFeed calls openPolicyCompanyCardsFeed, whose optimisticData unconditionally sets cardFeedsStatus[feed].isLoading = true. The table reads exactly that flag and renders the skeleton:

    WorkspaceCompanyCardsTable/index.tsx:105,131-136 — areWorkspaceCardFeedsLoading → isLoadingPage → isLoading → TableSkeleton.

    The lone guard inside loadPolicyCompanyCardsFeed (L79) checks the page's local isLoading, which is itself based on isLoadingOnyxValue(cardListMetadata) (L66). On remount, useOnyx subscriptions transition through status: 'loading' for a tick even when the value is cached, so the guard races: it can be true on the first render and false on the next, at which point the effect re-fires the API + the optimistic isLoading: true. Result: the skeleton flashes on every navigation back to the page.

    Why it reproduces on every navigation
    1. Navigate away → page unmounts → Onyx subscriptions torn down.
    2. Navigate back → page remounts; useOnyx metadata is briefly 'loading'.
    3. The unguarded effect fires openPolicyCompanyCardsFeed; its optimistic merge sets cardFeedsStatus[feed].isLoading = true.
    4. WorkspaceCompanyCardsTable reads areWorkspaceCardFeedsLoading and renders the skeleton.
    5. Server responds; successData flips isLoading: false; cards reappear.

    Note: this is a long-standing behavior (reported on v9.4.6-0), not specific to the recent refactor in PR #93202 — that PR rewrote this file but the unguarded-fetch pattern persists.

    What changes do you think we should make in order to solve the problem?

    Add an "already loaded" guard to the feed fetch, mirroring the existing hasFeedsLoaded guard on the sibling effect:

    • In loadPolicyCompanyCardsFeed (or its useEffect), skip the call when the selected feed's cards are already present in Onyx (e.g. cardsList/companyCardEntries is non-empty, or cardListMetadata.status === 'loaded'). This prevents the redundant OpenPolicyCompanyCardsFeed call on remount.
    • Optionally, also make openPolicyCompanyCardsFeed's optimistic isLoading: true write conditional on there being no cached cards, so the skeleton only shows on the genuine first load.

    This keeps the first-load behavior intact while eliminating the skeleton flash on subsequent visits.

    What alternative solutions did you explore? (Optional)

    • Gate the skeleton render in WorkspaceCompanyCardsTable so it never shows while cached cards exist (treat the refetch as a background refresh). This addresses the symptom but still issues a redundant API call on every mount, so the guard on the fetch is preferred.

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93404) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jun 12, 2026
  4. aswin-s commented on Jun 12, 2026

    @aswin-s
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On Web, when a user navigates from a workspace's Company cards page to another workspace page (e.g. Categories) and back, the Company cards page re-fetches the feed and flashes the loading skeleton on every revisit, instead of rendering the already-cached cards immediately.

    What is the root cause of that problem?

    In src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx, the effect at lines 86–88 calls loadPolicyCompanyCardsFeed() on every mount without checking whether the feed's card list is already loaded. The internal guards in loadPolicyCompanyCardsFeed (lines 78–84) only short-circuit on isLoading/!bankName/isFeedPending/isOffline — none of which are true on a revisit when the cards are already cached — so it calls openPolicyCompanyCardsFeed, which optimistically writes cardFeedsStatus[feed].isLoading: true (src/libs/actions/CompanyCards.ts lines 966–981). That flips the table into its skeleton state until the network response returns. The sibling effect for loadPolicyCompanyCardsPage (lines 70–76) avoids the same issue with a hasFeedsLoaded guard; the feed effect has no equivalent.

    What changes do you think we should make in order to solve the problem?

    1. src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx lines 86–88: gate the effect with a "cards already loaded for this feed" check, mirroring the hasFeedsLoaded pattern used at line 71. Skip the call when cardsList for the current feedName is already present and non-empty (i.e. derive hasCardsLoaded from companyCards.cardList/assignedCards or check cardListMetadata.status === 'loaded' together with a non-undefined value).
    2. src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx line 84: drop unneeded reactive deps from loadPolicyCompanyCardsFeed (e.g. isLoading) so the callback identity is stable across re-renders within the same mount, preventing redundant effect re-runs even if the guard above is bypassed.
    3. Keep the existing manual onReloadFeed path (passed to WorkspaceCompanyCardsTable line 117) unchanged so users can still explicitly refresh.

    What alternative solutions did you explore? (Optional)

    Tracking a "fetched once per (policyID, feedName)" ref to suppress re-fetch on remount — rejected because Onyx already holds the cached cards; a data-driven guard (option 1) is simpler and survives provider remounts.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jun 12, 2026
  6. lorretheboy commented on Jun 12, 2026

    @lorretheboy
    Contributor

    Proposal

    What is the root cause of that problem?

    On every mount the page decides whether to refetch feeds using only whether allCardFeeds currently has keys:

    const hasFeedsLoaded = !!allCardFeeds && Object.keys(allCardFeeds).length > 0;

    useEffect(() => {
    if (isOffline || hasFeedsLoaded) {
    return;
    }
    loadPolicyCompanyCardsPage();
    }, [loadPolicyCompanyCardsPage, isOffline, hasFeedsLoaded]);

    When you leave the page (to Categories) and come back, the component remounts and the useCardFeeds Onyx subscription re-hydrates from cache. On the first render allCardFeeds is still undefined (status loading), so hasFeedsLoaded is false and the effect fires openPolicyCompanyCardsPage again — even though the data is already cached and about to arrive. That call optimistically sets the domain-member isLoading: true flag, which the table reads as areWorkspaceCardFeedsLoading and turns into the skeleton:

    const isLoadingPage = !isOffline && !hasCards && (isLoadingFeed || isLoadingOnyxValue(personalDetailsMetadata) || areWorkspaceCardFeedsLoading);

    So the chain is: remount → feeds collection briefly loading from cache → hasFeedsLoaded false → guard ignores the loading state → spurious OpenPolicyCompanyCardsPage refetch → isLoading flag flips on while cards haven't rebuilt yet → full skeleton flashes on every visit.

    What changes do you think we should make in order to solve the problem?

    Don't treat "feeds collection is still hydrating" as "feeds not loaded". useCompanyCards already exposes isInitiallyLoadingFeeds (= isLoadingOnyxValue(allCardFeedsMetadata)):

    const isInitiallyLoadingFeeds = isLoadingOnyxValue(allCardFeedsMetadata);

    Destructure it on the page and add it to the guard so the refetch only fires once the cache has actually settled and there are genuinely no feeds:

    useEffect(() => {
    if (isOffline || hasFeedsLoaded) {
    return;
    }
    loadPolicyCompanyCardsPage();
    }, [loadPolicyCompanyCardsPage, isOffline, hasFeedsLoaded]);

    if (isOffline || hasFeedsLoaded || isInitiallyLoadingFeeds) {
        return;
    }
    loadPolicyCompanyCardsPage();
    

    (add isInitiallyLoadingFeeds to the dependency array). A true first-time load still works: once isInitiallyLoadingFeeds resolves to false with no feeds, the fetch fires as before — but a revisit with cached feeds no longer refetches, so the skeleton stops flashing.

    What alternative solutions did you explore? (Optional)

    Cache the "already fetched this policy" decision in a ref/Onyx flag so the fetch only runs once per session. This avoids the hydration race too, but it adds extra state to manage and still re-runs after a genuine cache eviction; gating on the existing loading metadata is the smaller, more direct fix.

  7. melvin-bot commented on Jun 12, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @marufsharifi (External)

  8. changed the title [-]Workspace setting- Company cards page loads each time opening it[/-] [+][$250] Workspace setting- Company cards page loads each time opening it[/+] on Jun 12, 2026
  9. melvin-bot commented on Jun 12, 2026

    @melvin-bot
  10. yusufdeveloper2903 commented on Jun 12, 2026

    @yusufdeveloper2903
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2026-06-15 07:03:30 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On the Workspace Company cards page, the card list re-runs its loading state (skeleton) every time you navigate away to another workspace page (e.g. Categories) and come back, even though the data is already cached. Re-opening the page should not re-trigger a load.

    What is the root cause of that problem?

    WorkspaceCompanyCardsPage has two data-loading effects, each of which drives a skeleton via an optimistic isLoading: true, and they fail to skip on a revisit for two distinct reasons.

    1. The feed-cards effect has no "already loaded" guard. It calls loadPolicyCompanyCardsFeed() unconditionally on every mount:

    https://github.com/Expensify/App/blob/main/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx#L86-L88

    On a revisit it re-fires openPolicyCompanyCardsFeed, which optimistically writes cardFeedsStatus[feed].isLoading = true:

    https://github.com/Expensify/App/blob/main/src/libs/actions/CompanyCards.ts#L966-L981

    That surfaces as selectedFeed.status and feeds straight into the table's isLoadingFeed → skeleton flash on every open:

    https://github.com/Expensify/App/blob/main/src/components/Tables/WorkspaceCompanyCardsTable/index.tsx#L131-L136

    2. The page-load guard is a presence check, so a no-feed workspace never settles. hasFeedsLoaded only becomes true once a feed key exists:

    https://github.com/Expensify/App/blob/main/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx#L68-L76

    For a workspace with zero feeds, allCardFeeds stays empty forever, so hasFeedsLoaded is permanently false. Every revisit re-fires openPolicyCompanyCardsPage, which optimistically re-sets the domain-member root isLoading: true → the table reads it as areWorkspaceCardFeedsLoading → isLoadingPage → skeleton. The feed-level guard can't help here because there is no selectedFeed.

    (Note: for a workspace with feeds, the page effect is already safe — allCardFeeds is a cached SHARED_NVP_PRIVATE_DOMAIN_MEMBER collection, so useOnyx returns status: 'loaded' synchronously on the first render after remount and hasFeedsLoaded is true on render #1. So the page-level fetch only needs the no-feed fix, while the feed-level fetch needs the missing guard.)

    What changes do you think we should make in order to solve the problem?

    Guard both effects on a resolved Onyx status (isLoading === false) — the signal that persists in SHARED_NVP_PRIVATE_DOMAIN_MEMBER across the remount — instead of on value presence. A genuine first load (status === undefined) still fires; a revisit refetches neither.

    1. Page-load effect — covers the no-feed workspace:

    - const hasFeedsLoaded = !!allCardFeeds && Object.keys(allCardFeeds).length > 0;
    + const hasWorkspaceFeedsResolved = workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.isLoading === false;
    + const hasFeedsLoaded = (!!allCardFeeds && Object.keys(allCardFeeds).length > 0) || hasWorkspaceFeedsResolved;
    
      useEffect(() => {
    -     if (isOffline || hasFeedsLoaded) {
    +     if (isOffline || isInitiallyLoadingFeeds || hasFeedsLoaded) {
              return;
          }
          loadPolicyCompanyCardsPage();
    - }, [loadPolicyCompanyCardsPage, isOffline, hasFeedsLoaded]);
    + }, [loadPolicyCompanyCardsPage, isOffline, isInitiallyLoadingFeeds, hasFeedsLoaded]);

    isInitiallyLoadingFeeds gates the cold-start hydration window: while allCardFeeds is still hydrating, workspaceCardFeedsStatus is empty, so the resolved-status check would read undefined === false and fire a wasteful fetch before the persisted status is even available. It's status === 'loading' (set only on isFirstConnection && hasPendingMergeForKey), guaranteed to flip to false once the initial read settles — so it can never block the genuine first load.

    2. Feed-load effect — covers the cached-feed revisit, on === false (not just truthy) so an interrupted {isLoading: true} self-heals instead of stranding the skeleton:

      useEffect(() => {
    +     if (isOffline || selectedFeed?.status?.isLoading === false) {
    +         return;
    +     }
          loadPolicyCompanyCardsFeed();
    - }, [loadPolicyCompanyCardsFeed]);
    + }, [loadPolicyCompanyCardsFeed, isOffline, selectedFeed?.status?.isLoading]);

    workspaceCardFeedsStatus, selectedFeed and isInitiallyLoadingFeeds are already available from useCompanyCards, so no new Onyx wiring is needed.

    Net rule on both effects: undefined → load, {isLoading: false} → skip, {isLoading: true} → self-heal. Why it's correct across the edge cases:

    • No-feed workspace: page status resolves to isLoading: false on first success → no refetch on revisit (the presence check alone never could).
    • Cached-feed revisit: selectedFeed.status.isLoading === false → feed fetch skipped, no skeleton flash.
    • Cold-start hydration: while feeds are still hydrating (isInitiallyLoadingFeeds), the page effect defers instead of reading the not-yet-hydrated root status; once settled it skips (resolved) or fires the first load (never fetched).
    • First-ever load: both statuses are undefined → both fetches still fire once.
    • Feed switching: changes bankName/selectedFeed; the new feed's status is undefined → it loads.
    • Interrupted fetch ({isLoading: true}): falls through and self-heals instead of stranding the page.
    • Manual reload & offline: untouched — the guards live in the effects, so onReloadPage/onReloadFeed and the existing offline/pending/bankName guards inside the callbacks still apply.
    • All platforms: root cause is platform-agnostic React/Onyx logic, so the fix covers Web, mWeb, iOS and Android.

    What alternative solutions did you explore? (Optional)

    • Make the table ignore the optimistic isLoading when cards already exist — papers over the symptom (the skeleton) while still firing redundant OPEN_POLICY_COMPANY_CARDS_PAGE / OPEN_POLICY_COMPANY_CARDS_FEED requests on every open.
    • Use a useRef "already fetched" flag — a ref resets on unmount, so it doesn't survive the revisit; the Onyx-backed resolved status is the only signal that persists across the remount.
    • Guard on cardList / card-entry presence — regresses valid feeds (and workspaces) that resolved with zero cards, since presence never becomes truthy for them.
  11. mukhrr commented on Jun 12, 2026

    @mukhrr
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2026-06-12 13:54:06 UTC.

    Proposal

    What is the root cause of that problem?

    On a workspace with no company card feeds, the loading skeleton re-appears every time the Company cards page is opened.

    The skeleton is driven by the table's isLoadingPage, which includes areWorkspaceCardFeedsLoading — the optimistic isLoading flag on the domain member:

    const isLoadingPage = !isOffline && !hasCards && (isLoadingFeed || isLoadingOnyxValue(personalDetailsMetadata) || areWorkspaceCardFeedsLoading);

    const areWorkspaceCardFeedsLoading = !!workspaceCardFeedsStatus?.[domainOrWorkspaceAccountID]?.isLoading;

    OpenPolicyCompanyCardsPage re-fetches on every visit and optimistically sets that flag back to true:

    function openPolicyCompanyCardsPage(policyID: string, domainOrWorkspaceAccountID: number, emailList: string[], translate: LocaleContextProps['translate']) {
    // Skip loading state writes when domainOrWorkspaceAccountID is 0 since Onyx discards writes to collection keys with member ID '0'.
    const onyxLoadingStateUpdates = domainOrWorkspaceAccountID !== CONST.DEFAULT_NUMBER_ID;
    const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER>> = onyxLoadingStateUpdates
    ? [
    {
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainOrWorkspaceAccountID}`,
    value: {
    isLoading: true,
    errors: null,
    },
    },
    ]
    : [];

    For a workspace with no feeds there are no cached cards to suppress the loader (hasCards is false), so the skeleton flashes on every revisit. Compare this with Categories/Tags: they also fetch on every visit, but gate their skeleton on a durable per-policy data key that a refetch never resets, so it never re-flashes:

    const isLoading = !isOffline && policyCategories === undefined;

    The company cards skeleton instead keys off the transient optimistic flag — and that flag isn't durable either: the backend re-sends the sharedNVP_private_domain_member NVP without it on navigation, so any "loaded once" marker stored there is wiped between visits (I confirmed this at runtime — the flag read false on one mount and undefined on the very next visit).

    What changes do you think we should make in order to solve the problem?

    Keep fetching on every visit (consistent with Categories/Tags), and stop the skeleton from being driven by the optimistic flag once we've already resolved that the workspace has no feeds.

    In WorkspaceCompanyCardsTable, add !isNoFeed to isLoadingPage:

    - const isLoadingPage = !isOffline && !hasCards && (isLoadingFeed || isLoadingOnyxValue(personalDetailsMetadata) || areWorkspaceCardFeedsLoading);
    + const isLoadingPage = !isOffline && !hasCards && !isNoFeed && (isLoadingFeed || isLoadingOnyxValue(personalDetailsMetadata) || areWorkspaceCardFeedsLoading);

    isNoFeed is derived from the feeds collection's Onyx metadata, not the optimistic flag, so it stays true through the background refetch — the company-cards analog of Categories' durable policyCategories:

    const isInitiallyLoadingFeeds = isLoadingOnyxValue(allCardFeedsMetadata);
    const isNoFeed = !selectedFeed && !isInitiallyLoadingFeeds;

    This mirrors the !isNoFeed guard already used one line above in isLoadingFeed:

    const isLoadingFeed =
    !hasCards && ((!feedName && isInitiallyLoadingFeeds) || !isPolicyLoaded || (!isNoFeed && isLoadingOnyxValue(lastSelectedFeedMetadata)) || !!selectedFeedStatus?.isLoading);

    Result: a no-feed workspace keeps showing its empty state on revisit (no skeleton flash), while the genuine first cold load — where isInitiallyLoadingFeeds is still true, so isNoFeed is false — still shows the skeleton. With-feeds, feed-pending, and the account-ID-0 error state are untouched (isNoFeed is false, or the error branch renders instead).

    What alternative solutions did you explore? (Optional)

    n/a

  12. wildan-m commented on Jun 12, 2026

    @wildan-m
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    On the Workspace settings → Company cards page, the card list reloads (the skeleton loader flashes) every single time the page is opened. After navigating away (e.g. to Categories) and back to Company cards, the page shows a loading state again instead of immediately displaying the already-fetched cards.

    What is the root cause of that problem?

    The Company cards page fires two data fetches on mount: one for the list of feeds (openPolicyCompanyCardsPage) and one for the selected feed's card list (openPolicyCompanyCardsFeed).

    The feeds-list fetch is already guarded so it is skipped once the feeds are present in Onyx:

    useEffect(() => {
    if (isOffline || hasFeedsLoaded) {
    return;
    }
    loadPolicyCompanyCardsPage();
    }, [loadPolicyCompanyCardsPage, isOffline, hasFeedsLoaded]);

    But the second effect, which fetches the selected feed's card list, has no equivalent "already loaded" guard. It re-runs on every mount and calls openPolicyCompanyCardsFeed unconditionally:

    useEffect(() => {
    loadPolicyCompanyCardsFeed();
    }, [loadPolicyCompanyCardsFeed]);

    openPolicyCompanyCardsFeed optimistically sets the feed's isLoading to true:

    const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER>> = [
    {
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainAccountID}`,
    value: {
    settings: {
    cardFeedsStatus: {
    [feed]: {
    isLoading: true,
    errors: null,
    },
    },
    },
    },
    },
    ];

    Because the Company cards screen is unmounted when you navigate away and freshly mounted when you return, this effect re-fires on every visit, putting the feed back into a loading state and flashing the skeleton — even though the card list is already cached in Onyx. This is the same class of unnecessary re-fetch that was fixed for the feeds list, but the per-feed card list was left unguarded.

    What changes do you think we should make in order to solve the problem?

    Add an "already loaded" guard to the feed-loading effect in WorkspaceCompanyCardsPage, mirroring the existing hasFeedsLoaded guard used for the feeds-list fetch.

    Concretely, the page already derives the selected feed's card entries through useCompanyCards (companyCardEntries). We compute a boolean such as hasCards = (companyCardEntries ?? []).length > 0 and add it to the effect that calls loadPolicyCompanyCardsFeed, returning early when cards are already present:

    useEffect(() => {
    loadPolicyCompanyCardsFeed();
    }, [loadPolicyCompanyCardsFeed]);

    So the effect becomes: if the selected feed's cards are already loaded, skip the fetch; otherwise call loadPolicyCompanyCardsFeed(). This keeps the first (cold) load behavior intact — the cards are still fetched when they are not yet cached — while preventing the redundant re-fetch (and the skeleton flash) on every subsequent visit.

    The guard is placed in the effect, not inside loadPolicyCompanyCardsFeed itself, so the manual "Try again" reload path (onReloadFeed) that re-uses this callback continues to force a refresh on demand. This matches the established pattern and the table's own "if we already have fetched cards, do not show the skeleton loader" logic.

    Compare branch: https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/93404-company-cards-skeleton-flash?expand=1

    What alternative solutions did you explore? (Optional)

    Keep a previously-fetched-feed signal in Onyx (e.g. gate on the selected feed's status having been written by a prior fetch) instead of deriving from the card entries. This is more precise for empty feeds but more invasive; gating on the already-computed card entries is the minimal change that fixes the reported scenario and stays consistent with the feeds-list guard.

  13. github-actions commented on Jun 12, 2026

    @github-actions
    Contributor

    ⚠️ @mukhrr Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

  14. 131 remaining items

  15. melvin-bot commented on Jul 22, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  16. melvin-bot commented on Jul 22, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2065365683893732639/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. mallenexpensify commented on Jul 24, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @nkdengineer paid $250 via NewDot
    Contributor+: @marufsharifi due $250 via Upwork

    @marufsharifi can you please accept the job below? Please reply here and tag me once you have.
    If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
    https://www.upwork.com/jobs/~022065365683893732639

    ^ Test case created. Thx

  18. marufsharifi commented on Jul 25, 2026

    @marufsharifi

    @mallenexpensify, I've accepted the offer. thanks.

  19. mallenexpensify commented on Jul 27, 2026

    @mallenexpensify
    Contributor

    @marufsharifi paid, summary updated above. Thx.

  20. twisterdotcom commented on Aug 18, 2026

    @twisterdotcom
    Contributor

    $250 approved for @nkdengineer in Report ID: R00HUzY8dIps.

    Zapier Logs Run ID: 00040eee-748a-ab0c-24f9-0462af69b334

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions