Skip to content

[Due for payment 2026-06-24] [Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page #93626

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.8-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80449
Email or phone of affected tester (no customers): jsodinjosdjsoinjsiojs@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Workflows.
  3. Click Add approval workflow.
  4. Upgrade workspace if needed.
  5. Enter email which does not have ND account > select it > Next.
  6. Click Invite.
  7. Select any approver > Skip.

Expected Result:

Invited user will show correct avatar on confirm page.

Actual Result:

Invited user shows fallback avatar on confirm page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7181524_1781548551889.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7181524

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 15, 2026
  2. applause-bot commented on Jun 15, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/60b2b492c7ae9a5ef1e27162d478f8a4bc3cd111d871f8e205195b51da0e98ee

  3. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80449

  4. melvin-bot commented on Jun 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 15, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    On the confirm page, the "Expenses from" members are rendered by ApprovalWorkflowEditor.tsx memberPills, which reads each member's avatar straight from approvalWorkflow.members (avatar: m.avatar).

    For a newly invited user (no ND account), that stored avatar is undefined. It gets set to undefined when the workflow members are saved in nextStep of WorkspaceWorkflowsApprovalsExpensesFromPage.tsx:340-347 (avatar: undefined), before the invite even happens, and that snapshot is never refreshed afterward.

    An undefined avatar can't resolve to the deterministic default avatar. Avatar calls getAvatar, but getAvatar only computes a default avatar when the source passes isDefaultAvatar — which returns false for undefined. So source stays undefined, useFallBackAvatar becomes true, and the generic FallbackAvatar is shown.

    Existing workspace members don't hit this because their avatar comes from personalDetails as a default-avatar URL string that isDefaultAvatar recognizes, so the deterministic avatar resolves correctly. The PR also already fixed the Expenses from list itself (the selectedMembers memo falls back to personalDetail?.avatar), which is why returning to that page shows the right avatar — but the confirm page consumes the stale approvalWorkflow.members snapshot and was missed.

    Why passing only an accountID wouldn't fix it

    UserPill/Avatar derive the default avatar from getAvatar, and getAvatar short-circuits to the deterministic avatar only when the source is a recognizable default-avatar value (via isDefaultAvatar). A bare accountID with an undefined source still returns undefined → fallback. The member needs an actual default-avatar source value, which getDefaultAvatarURL/getDefaultAvatar produce. Note getAccountIDHashBucket hashes accountEmail (md5) when present, matching backend bucket selection, so email alone yields the correct avatar even before a real accountID exists.

    What changes do you think we should make in order to solve the problem?

    Stop storing avatar: undefined for invited members. In nextStep, when building the usersToInvite entries in allMembers, resolve a deterministic default avatar for each invited user (e.g. via getDefaultAvatar/getDefaultAvatarURL keyed on the user's email, and the draft accountID already captured in usersToInvite when available) instead of undefined.

    That value is recognized by isDefaultAvatar, so the existing memberPills → UserPill → Avatar chain will render the correct deterministic avatar on the confirm page with no further changes.

    What alternative solutions did you explore? (Optional)

    Resolve the avatar live in ApprovalWorkflowEditor.memberPills from personalDetails by email (the invited user exists by the time the confirm page renders post-invite), and pass accountID through to UserPills. This is more robust against stale snapshots but is a slightly larger change touching the editor's data dependencies.

    Confidence & verification

    Confidence: High. Traced end-to-end from the stored member data through UserPills → UserPill → Avatar → getAvatar/isDefaultAvatar. The fallback path is exercised precisely when avatar is undefined, which is exactly what nextStep stores for invited (non-ND) users. Introduced in #80449 (this is a new feature, not in production), consistent with the deploy-blocker context.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93626) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. twilight2294 commented on Jun 16, 2026

    @twilight2294
    Contributor
  8. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. 3 remaining items

  11. IuliiaHerets commented on Jun 16, 2026

    @IuliiaHerets

    Chrome / v9.4.8-2
    Passed

    REC-20260616190137.mp4
  12. puneetlath commented on Jun 16, 2026

    @puneetlath
    Contributor

    Nice

  13. changed the title [-]Workflow - Invited user shows fallback avatar on confirm page[/-] [+][Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page[/+] on Jun 16, 2026
  14. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.8-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-23. 🎊

  16. melvin-bot commented on Jun 16, 2026

    @melvin-bot

    @youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  17. changed the title [-][Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page[/-] [+][Due for payment 2026-06-24] [Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page[/+] on Jun 17, 2026
  18. melvin-bot commented on Jun 17, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.9-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-06-24. 🎊

  19. melvin-bot commented on Jun 17, 2026

    @melvin-bot

    @youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions