You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-24] [Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page #93626
Version Number: 9.4.8-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#80449 Email or phone of affected tester (no customers):jsodinjosdjsoinjsiojs@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Go to staging.new.expensify.com
Go to workspace settings > Workflows.
Click Add approval workflow.
Upgrade workspace if needed.
Enter email which does not have ND account > select it > Next.
Click Invite.
Select any approver > Skip.
Expected Result:
Invited user will show correct avatar on confirm page.
Actual Result:
Invited user shows fallback avatar on confirm page.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
On the confirm page, the "Expenses from" members are rendered by ApprovalWorkflowEditor.tsxmemberPills, which reads each member's avatar straight from approvalWorkflow.members (avatar: m.avatar).
For a newly invited user (no ND account), that stored avatar is undefined. It gets set to undefined when the workflow members are saved in nextStep of WorkspaceWorkflowsApprovalsExpensesFromPage.tsx:340-347 (avatar: undefined), before the invite even happens, and that snapshot is never refreshed afterward.
An undefined avatar can't resolve to the deterministic default avatar. Avatar calls getAvatar, but getAvatar only computes a default avatar when the source passes isDefaultAvatar — which returns false for undefined. So source stays undefined, useFallBackAvatar becomes true, and the generic FallbackAvatar is shown.
Existing workspace members don't hit this because their avatar comes from personalDetails as a default-avatar URL string that isDefaultAvatar recognizes, so the deterministic avatar resolves correctly. The PR also already fixed the Expenses from list itself (the selectedMembers memo falls back to personalDetail?.avatar), which is why returning to that page shows the right avatar — but the confirm page consumes the stale approvalWorkflow.members snapshot and was missed.
Why passing only an accountID wouldn't fix it
UserPill/Avatar derive the default avatar from getAvatar, and getAvatar short-circuits to the deterministic avatar only when the source is a recognizable default-avatar value (via isDefaultAvatar). A bare accountID with an undefined source still returns undefined → fallback. The member needs an actual default-avatar source value, which getDefaultAvatarURL/getDefaultAvatar produce. Note getAccountIDHashBucket hashes accountEmail (md5) when present, matching backend bucket selection, so email alone yields the correct avatar even before a real accountID exists.
What changes do you think we should make in order to solve the problem?
Stop storing avatar: undefined for invited members. In nextStep, when building the usersToInvite entries in allMembers, resolve a deterministic default avatar for each invited user (e.g. via getDefaultAvatar/getDefaultAvatarURL keyed on the user's email, and the draft accountID already captured in usersToInvite when available) instead of undefined.
That value is recognized by isDefaultAvatar, so the existing memberPills → UserPill → Avatar chain will render the correct deterministic avatar on the confirm page with no further changes.
What alternative solutions did you explore? (Optional)
Resolve the avatar live in ApprovalWorkflowEditor.memberPills from personalDetails by email (the invited user exists by the time the confirm page renders post-invite), and pass accountID through to UserPills. This is more robust against stale snapshots but is a slightly larger change touching the editor's data dependencies.
Confidence & verification
Confidence: High. Traced end-to-end from the stored member data through UserPills → UserPill → Avatar → getAvatar/isDefaultAvatar. The fallback path is exercised precisely when avatar is undefined, which is exactly what nextStep stores for invited (non-ND) users. Introduced in #80449 (this is a new feature, not in production), consistent with the deploy-blocker context.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/93626) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Workflow - Invited user shows fallback avatar on confirm page[/-][+][Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page[/+]on Jun 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.8-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page[/-][+][Due for payment 2026-06-24] [Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page[/+]on Jun 17, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.9-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 15, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/60b2b492c7ae9a5ef1e27162d478f8a4bc3cd111d871f8e205195b51da0e98ee
melvin-bot commentedon Jun 15, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #80449
melvin-bot commentedon Jun 15, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 15, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 15, 2026
Proposal
What is the root cause of that problem?
On the confirm page, the "Expenses from" members are rendered by
ApprovalWorkflowEditor.tsxmemberPills, which reads each member's avatar straight fromapprovalWorkflow.members(avatar: m.avatar).For a newly invited user (no ND account), that stored avatar is
undefined. It gets set toundefinedwhen the workflow members are saved innextStepofWorkspaceWorkflowsApprovalsExpensesFromPage.tsx:340-347(avatar: undefined), before the invite even happens, and that snapshot is never refreshed afterward.An
undefinedavatar can't resolve to the deterministic default avatar.AvatarcallsgetAvatar, butgetAvataronly computes a default avatar when the source passesisDefaultAvatar— which returnsfalseforundefined. Sosourcestaysundefined,useFallBackAvatarbecomes true, and the genericFallbackAvataris shown.Existing workspace members don't hit this because their
avatarcomes frompersonalDetailsas a default-avatar URL string thatisDefaultAvatarrecognizes, so the deterministic avatar resolves correctly. The PR also already fixed the Expenses from list itself (theselectedMembersmemo falls back topersonalDetail?.avatar), which is why returning to that page shows the right avatar — but the confirm page consumes the staleapprovalWorkflow.memberssnapshot and was missed.Why passing only an accountID wouldn't fix it
UserPill/Avatarderive the default avatar fromgetAvatar, andgetAvatarshort-circuits to the deterministic avatar only when the source is a recognizable default-avatar value (viaisDefaultAvatar). A bareaccountIDwith anundefinedsource still returnsundefined→ fallback. The member needs an actual default-avatar source value, whichgetDefaultAvatarURL/getDefaultAvatarproduce. NotegetAccountIDHashBuckethashesaccountEmail(md5) when present, matching backend bucket selection, so email alone yields the correct avatar even before a real accountID exists.What changes do you think we should make in order to solve the problem?
Stop storing
avatar: undefinedfor invited members. InnextStep, when building theusersToInviteentries inallMembers, resolve a deterministic default avatar for each invited user (e.g. viagetDefaultAvatar/getDefaultAvatarURLkeyed on the user's email, and the draft accountID already captured inusersToInvitewhen available) instead ofundefined.That value is recognized by
isDefaultAvatar, so the existingmemberPills→UserPill→Avatarchain will render the correct deterministic avatar on the confirm page with no further changes.What alternative solutions did you explore? (Optional)
Resolve the avatar live in
ApprovalWorkflowEditor.memberPillsfrompersonalDetailsby email (the invited user exists by the time the confirm page renders post-invite), and passaccountIDthrough toUserPills. This is more robust against stale snapshots but is a slightly larger change touching the editor's data dependencies.Confidence & verification
Confidence: High. Traced end-to-end from the stored member data through
UserPills→UserPill→Avatar→getAvatar/isDefaultAvatar. The fallback path is exercised precisely whenavatarisundefined, which is exactly whatnextStepstores for invited (non-ND) users. Introduced in #80449 (this is a new feature, not in production), consistent with the deploy-blocker context.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/93626)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
twilight2294 commentedon Jun 16, 2026
PR is here:
melvin-bot commentedon Jun 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Jun 16, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
3 remaining items
IuliiaHerets commentedon Jun 16, 2026
Chrome / v9.4.8-2
Passed
REC-20260616190137.mp4
puneetlath commentedon Jun 16, 2026
Nice
[-]Workflow - Invited user shows fallback avatar on confirm page[/-][+][Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page[/+]melvin-bot commentedon Jun 16, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.8-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-23. 🎊
melvin-bot commentedon Jun 16, 2026
@youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-][Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page[/-][+][Due for payment 2026-06-24] [Due for payment 2026-06-23] Workflow - Invited user shows fallback avatar on confirm page[/+]melvin-bot commentedon Jun 17, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.9-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-24. 🎊
melvin-bot commentedon Jun 17, 2026
@youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]