You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-25] Spend-Expense preview is missing in "In expense report" in Chats #93641
Version Number: 9.4.8-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176922/test-cases/41237507 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: MacBook Air 26.5 Chrome, iPhone 15 iOS 26.5 App Component: Search
Action Performed:
Sign on to ND
Create a workspace
Open workspace chat, click "+" button, select "Create expense"
Create a manual expense
Open Spend tab, click Advanced filters
Set Type to Chats, dismiss filters
Look for "In Expense Report [date]" entry
Expected Result:
Expense preview is shown in "In expense report" entry in Chats
Actual Result:
Expense preview is missing in "In expense report" entry in Chats. Only the title, avatars, creator's name, and the date are displayed
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root Cause (likely): Regression from Expensify/App#93421 — "[NoQA] stabilize stableReportSelector and more reports in the ReportActionItem tree" (LukasMod, merged 2026-06-15, in the 9.4.8 staging window). It is the only PR in this release that touches the exact chain rendering a Type=Chats expense-report row: ChatListItem → ReportActionItem → ActionContentRouter → MoneyRequestReportPreview. It switched iouReport/chatReport to the projectedgetStableReportSelector instead of the full report, and lifted chatReport up as a prop. When a needed field on the projected report resolves undefined for a Search row, the preview card body is gated out and only the title/avatars/creator/date remain — exactly the reported symptom.
Recommended Fix: Ask LukasMod to either revert Expensify/App#93421 to unblock the deploy, or fix forward by ensuring the Search Type=Chats path feeds the fields the preview needs (verify the row does not hit the isEmpty / placeholder branch in ReportActionItem.tsx:480).
ReportActionItem.tsx:480: isEmpty = !shouldRenderViewBasedOnAction && !isClosedExpenseReportWithNoExpenses. When isEmpty, the preview frame is replaced with empty HTML at L579.
Why #93421 is the prime suspect: Two independent investigations bisected the 9.4.8 staging window (git log over src/components/Search/ and the ReportActionItem tree). #93421 is the only merged PR touching all of ChatListItem, ReportActionItem, and ActionContentRouter, and it changes how iouReport/chatReport/originalReport are subscribed (projected selector + lifted prop). The projection at Report.ts:126-189 drops any Report field not explicitly listed; a Search snapshot row feeding a projected report into this tree is a plausible path to an undefined field that gates the preview out.
Confidence: Medium. The git bisect signal is strong and deterministic (single PR in the window touching the whole chain), and the gating code matches the symptom. I have not confirmed at runtime which field/branch goes falsy for Search rows specifically — that requires reproducing on staging. The fastest path for a deploy blocker is to revert #93421 and confirm the preview returns.
Alternative explanations considered: Search snapshot reports may not be hydrated into live ONYXKEYS.COLLECTION.REPORT (Expensify/App#93112 hydrates only one specific RHP), which could independently leave iouReport undefined in the preview. This is consistent with the same symptom but is pre-existing; #93421 is the change that lands in this exact regression window.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/pull/93421) to create a draft revert PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Thanks QichenZhu — you're right, I'll retract the #93421 call. Reverting it and the clean adhoc build rule it out. Here's a corrected, code-backed analysis.
Why the preview body is empty in Search (verified mechanism)
In a Type=Chats row, the preview's report is read through the snapshot-aware useOnyx (so the title/avatars/creator/date render fine), but its transactions/violations come from a different source that the search snapshot does not feed:
useReportWithTransactionsAndViolations.ts:15-19 — report comes from wrapped useOnyx(REPORT/{id}) (snapshot-routable), but transactions/violations come from useAllReportsTransactionsAndViolations(), i.e. the derived Onyx value.
That derived value is computed only from the live collectionsreportTransactionsAndViolations.ts:11-14 (COLLECTION.TRANSACTION + COLLECTION.TRANSACTION_VIOLATIONS), and ONYXKEYS.DERIVED.* is not in SNAPSHOT_ONYX_KEYS, so it is never served from the search snapshot. Its provider also sits above SearchScopeProvider, so it can't see isOnSearch either.
Net: the carousel body renders only when the IOU report's transactions are present in live Onyx. Right after creating an expense they usually are (which fits "not reproducible in production"), but whenever the live transaction/derived entry is absent, the body collapses to the empty placeholder while the header still shows — exactly the reported symptom.
What this means for the regression
This data path is unchanged for months (the hook and derived config last changed Feb/Apr 2026), so the regression is upstream of the preview — something in the 9.4.8 cut that affects whether the freshly-created transaction stays in live COLLECTION.TRANSACTION / its derived entry. I couldn't bisect it to a single PR from here (my checkout is shallow and I can't reproduce on staging), so I'd rather not name another suspect blind after getting it wrong once.
Decisive next step (on a staging repro)
With the preview empty, open Onyx devtools and check:
Is transactions_<transactionID> present in the liveONYXKEYS.COLLECTION.TRANSACTION?
Does ONYXKEYS.DERIVED.REPORT_TRANSACTIONS_AND_VIOLATIONS have an entry for that iouReportID containing the transaction?
Live TRANSACTION missing the entry → regression is in transaction population/retention; bisect 9.4.8 PRs that touch transaction Onyx writes (the in-flight "Remove Onyx.connect() for TRANSACTION_VIOLATIONS" refactor series is a natural place to start).
Present, but body still empty → regression is in the preview gating/derived-value read instead.
That single check splits the search space cleanly.
Next Steps: Reply with @MelvinBot <findings from the Onyx check> and I'll dig into that specific branch.
Net: the carousel body renders only when the IOU report's transactions are present in live Onyx. Right after creating an expense they usually are (which fits "not reproducible in production"), but whenever the live transaction/derived entry is absent, the body collapses to the empty placeholder while the header still shows — exactly the reported symptom.
@MelvinBot 'not reproducible in production' means the same steps don't trigger the bug in prod. It has nothing to do with whether transactions are present in Onyx.
You're right, and thanks for the correction — I'll retract that parenthetical.
Reproducible in production: No is a build comparison: the same repro steps run against the production build don't trigger the bug, while the staging build does. It says nothing about runtime Onyx state. I incorrectly used it as evidence for the "transactions happen to be present in prod" theory — that reasoning doesn't hold.
If anything, the corrected reading points the other way: staging-reproducible + production-clean means the cause is a code change that landed in the 9.4.8 cut (a regression), not a data-timing coincidence. So the symptom path I described (preview body collapses when the IOU report's transactions aren't in live Onyx / the derived value) may still be the mechanism, but the trigger is whatever 9.4.8 change broke transaction population/retention or the preview's read — and the clean prod build is what tells us it's a regression, nothing more.
The decisive Onyx-devtools check from my previous comment still stands as the way to split that search space.
changed the title [-]Spend-Expense preview is missing in "In expense report" in Chats[/-][+][Due for payment 2026-06-25] Spend-Expense preview is missing in "In expense report" in Chats[/+]on Jun 18, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.14-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 15, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/3256a33cf10e3890d9ad43a9c3a26b1edc8382213285bdeac77652ecea300f20
melvin-bot commentedon Jun 15, 2026
Triggered auto assignment to @cead22 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jun 15, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 15, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 15, 2026
Issue Analysis
Root Cause (likely): Regression from Expensify/App#93421 — "[NoQA] stabilize stableReportSelector and more reports in the ReportActionItem tree" (
LukasMod, merged 2026-06-15, in the 9.4.8 staging window). It is the only PR in this release that touches the exact chain rendering aType=Chatsexpense-report row:ChatListItem→ReportActionItem→ActionContentRouter→MoneyRequestReportPreview. It switchediouReport/chatReportto the projectedgetStableReportSelectorinstead of the full report, and liftedchatReportup as a prop. When a needed field on the projected report resolvesundefinedfor a Search row, the preview card body is gated out and only the title/avatars/creator/date remain — exactly the reported symptom.Recommended Fix: Ask
LukasModto either revert Expensify/App#93421 to unblock the deploy, or fix forward by ensuring the SearchType=Chatspath feeds the fields the preview needs (verify the row does not hit theisEmpty/ placeholder branch inReportActionItem.tsx:480).Investigation details & evidence
Render chain (Type=Chats expense-report row):
SearchUIUtils.ts:3567→getListItem(CHAT)returnsChatListItem.ChatListItem.tsxreads the row report (getStableReportSelector) and now the liftedchatReportStable, then renders<ReportActionItem … />.ReportActionItem.tsx:177now loadsiouReportviagetStableReportSelector(changed by [NoQA] stabilize stableReportSelector and more reports in the ReportActionItem tree #93421).ReportActionItem.tsx:480:isEmpty = !shouldRenderViewBasedOnAction && !isClosedExpenseReportWithNoExpenses. WhenisEmpty, the preview frame is replaced with empty HTML at L579.ActionContentRouter.tsxrenders<MoneyRequestReportPreview …>, whose body shows an empty/access placeholder wheniouReportisundefined(MoneyRequestReportPreviewContent.tsx:132-146).Why #93421 is the prime suspect: Two independent investigations bisected the 9.4.8 staging window (
git logoversrc/components/Search/and the ReportActionItem tree). #93421 is the only merged PR touching all ofChatListItem,ReportActionItem, andActionContentRouter, and it changes howiouReport/chatReport/originalReportare subscribed (projected selector + lifted prop). The projection atReport.ts:126-189drops anyReportfield not explicitly listed; a Search snapshot row feeding a projected report into this tree is a plausible path to anundefinedfield that gates the preview out.Confidence: Medium. The git bisect signal is strong and deterministic (single PR in the window touching the whole chain), and the gating code matches the symptom. I have not confirmed at runtime which field/branch goes falsy for Search rows specifically — that requires reproducing on staging. The fastest path for a deploy blocker is to revert #93421 and confirm the preview returns.
Alternative explanations considered: Search snapshot reports may not be hydrated into live
ONYXKEYS.COLLECTION.REPORT(Expensify/App#93112 hydrates only one specific RHP), which could independently leaveiouReportundefined in the preview. This is consistent with the same symptom but is pre-existing; #93421 is the change that lands in this exact regression window.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/pull/93421)to create a draft revert PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
QichenZhu commentedon Jun 16, 2026
@MelvinBot I tried reverting #93421 but it didn't fix this, and the issue doesn't reproduce in #93421's adhoc build.
MelvinBot commentedon Jun 16, 2026
Thanks
QichenZhu— you're right, I'll retract the #93421 call. Reverting it and the clean adhoc build rule it out. Here's a corrected, code-backed analysis.Why the preview body is empty in Search (verified mechanism)
In a
Type=Chatsrow, the preview's report is read through the snapshot-awareuseOnyx(so the title/avatars/creator/date render fine), but its transactions/violations come from a different source that the search snapshot does not feed:useReportWithTransactionsAndViolations.ts:15-19—reportcomes from wrappeduseOnyx(REPORT/{id})(snapshot-routable), buttransactions/violationscome fromuseAllReportsTransactionsAndViolations(), i.e. the derived Onyx value.reportTransactionsAndViolations.ts:11-14(COLLECTION.TRANSACTION+COLLECTION.TRANSACTION_VIOLATIONS), andONYXKEYS.DERIVED.*is not inSNAPSHOT_ONYX_KEYS, so it is never served from the search snapshot. Its provider also sits aboveSearchScopeProvider, so it can't seeisOnSearcheither.Net: the carousel body renders only when the IOU report's transactions are present in live Onyx. Right after creating an expense they usually are (which fits "not reproducible in production"), but whenever the live transaction/derived entry is absent, the body collapses to the empty placeholder while the header still shows — exactly the reported symptom.
What this means for the regression
This data path is unchanged for months (the hook and derived config last changed Feb/Apr 2026), so the regression is upstream of the preview — something in the 9.4.8 cut that affects whether the freshly-created transaction stays in live
COLLECTION.TRANSACTION/ its derived entry. I couldn't bisect it to a single PR from here (my checkout is shallow and I can't reproduce on staging), so I'd rather not name another suspect blind after getting it wrong once.Decisive next step (on a staging repro)
With the preview empty, open Onyx devtools and check:
transactions_<transactionID>present in the liveONYXKEYS.COLLECTION.TRANSACTION?ONYXKEYS.DERIVED.REPORT_TRANSACTIONS_AND_VIOLATIONShave an entry for thatiouReportIDcontaining the transaction?TRANSACTIONmissing the entry → regression is in transaction population/retention; bisect 9.4.8 PRs that touch transaction Onyx writes (the in-flight "RemoveOnyx.connect()forTRANSACTION_VIOLATIONS" refactor series is a natural place to start).That single check splits the search space cleanly.
Next Steps: Reply with
@MelvinBot <findings from the Onyx check>and I'll dig into that specific branch.QichenZhu commentedon Jun 16, 2026
@MelvinBot 'not reproducible in production' means the same steps don't trigger the bug in prod. It has nothing to do with whether transactions are present in Onyx.
MelvinBot commentedon Jun 16, 2026
You're right, and thanks for the correction — I'll retract that parenthetical.
Reproducible in production: Nois a build comparison: the same repro steps run against the production build don't trigger the bug, while the staging build does. It says nothing about runtime Onyx state. I incorrectly used it as evidence for the "transactions happen to be present in prod" theory — that reasoning doesn't hold.If anything, the corrected reading points the other way: staging-reproducible + production-clean means the cause is a code change that landed in the 9.4.8 cut (a regression), not a data-timing coincidence. So the symptom path I described (preview body collapses when the IOU report's transactions aren't in live Onyx / the derived value) may still be the mechanism, but the trigger is whatever 9.4.8 change broke transaction population/retention or the preview's read — and the clean prod build is what tells us it's a regression, nothing more.
The decisive Onyx-devtools check from my previous comment still stands as the way to split that search space.
9 remaining items
youssef-lr commentedon Jun 16, 2026
PR ready
[-]Spend-Expense preview is missing in "In expense report" in Chats[/-][+][Due for payment 2026-06-25] Spend-Expense preview is missing in "In expense report" in Chats[/+]melvin-bot commentedon Jun 18, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 18, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.14-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-25. 🎊
melvin-bot commentedon Jun 18, 2026
@youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]