You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-06-26] [Due for payment 2026-06-25] Expense - Your file is ready! modal does not close when click Download file #93874
Version Number: v9.4.10-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92169 Email or phone of affected tester (no customers):gocemate+b215490600@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Windows 10/Chrome App Component: Other
Action Performed:
Open ND.
Navigate to Spend > Expenses.
Select any expense.
Click the "x selected" dropdown button, then choose Export > All Data - Expense Level.
Verify that the Send me the file when is ready is displayed
Wait a few seconds until the following modal appears: Your file is ready!
Click Download file.
Expected Result:
Your file is ready! modal should close when click Download file
Actual Result:
Your file is ready! modal does not close when click Download file
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
In the "Your file is ready!" state, the Download file button only triggers the download — it never closes the modal. Its handler is wired to downloadFile alone, with no call to onClose/handleClose:
So the expected behavior (modal closes on Download file) was never implemented — the only way to dismiss is the secondary Close button. This was introduced in #92169.
What changes do you think we should make in order to solve the problem?
Make the Download file button download and then dismiss the modal. Add a small handler that runs downloadFile() followed by handleClose() (handleClose already calls clearExportDownload + onClose, line 95-98), and wire it to the button's onPress instead of downloadFile.
Implementation detail & edge cases
The non-concierge ready path already auto-downloads via the useEffect at line 76-82, so the visible Download file button is effectively a manual re-trigger. Closing on press matches the QA-expected flow without affecting the auto-download.
Confirm whether closing should also fire when the auto-download useEffect runs, or only on explicit button press. The reported repro is specifically the button, so scoping the fix to the button's onPress is the minimal, safe change.
What alternative solutions did you explore? (Optional)
None needed — the gap is a missing dismiss call on a single button handler.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/93874) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
@truph01 Yeah, this was not planned before, but we decided to close the modal on clicking the Download button. Another fix we want to have with this CP is:
Remove the "Close" button below the "Download file" in the ready state. So this means the modal will be dismissible on the ready state.
Replace the H1 style textHeadlineH1, create new one exportDownloadTitle
Contributor: @truph01 due $125 via NewDot
Contributor+: @daledah due $125 via NewDot
Starting this at $125 cuz it's a regression (even if it's a new feature, we still don't want regressions, if they should have be caught) and also cuz it's a followup (we really don't want there to be a financial incentive where contributors get $500 ($250 x 2) when causing regressions). I'll leave open for comments for a bit then close. (also... I'm tracking examples like this so we can, finally, document regressions and how to address them).
Activity
applause-bot commentedon Jun 17, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/b4f24c2965d930d1e353825ca90ddcc4cb5781a3c366b138a719d24ed05177ed
melvin-bot commentedon Jun 17, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92169
melvin-bot commentedon Jun 17, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 17, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 17, 2026
Proposal
What is the root cause of that problem?
In the "Your file is ready!" state, the Download file button only triggers the download — it never closes the modal. Its handler is wired to
downloadFilealone, with no call toonClose/handleClose:src/components/ExportDownloadStatusModal.tsx:148-153—Download file→onPress={downloadFile}(downloads but does not dismiss)src/components/ExportDownloadStatusModal.tsx:154-158— the separateClosebutton is the only control that dismisses (viahandleClose)So the expected behavior (modal closes on Download file) was never implemented — the only way to dismiss is the secondary
Closebutton. This was introduced in #92169.What changes do you think we should make in order to solve the problem?
Make the Download file button download and then dismiss the modal. Add a small handler that runs
downloadFile()followed byhandleClose()(handleClosealready callsclearExportDownload+onClose, line 95-98), and wire it to the button'sonPressinstead ofdownloadFile.Implementation detail & edge cases
useEffectat line 76-82, so the visible Download file button is effectively a manual re-trigger. Closing on press matches the QA-expected flow without affecting the auto-download.useEffectruns, or only on explicit button press. The reported repro is specifically the button, so scoping the fix to the button'sonPressis the minimal, safe change.What alternative solutions did you explore? (Optional)
None needed — the gap is a missing dismiss call on a single button handler.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/93874)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
truph01 commentedon Jun 18, 2026
@mollfpr Do we want to close the modal once clicking on "Download file" button?
mollfpr commentedon Jun 18, 2026
@truph01 Yeah, this was not planned before, but we decided to close the modal on clicking the Download button. Another fix we want to have with this CP is:
readystate. So this means the modal will be dismissible on thereadystate.textHeadlineH1, create new oneexportDownloadTitletruph01 commentedon Jun 18, 2026
@mollfpr Could you assign me and @daledah ?
16 remaining items
melvin-bot commentedon Jun 23, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
truph01 commentedon Jun 24, 2026
@mollfpr Are we eligible for payment here? Since this issue was implementing a new design rather than fixing an existing bug.
mollfpr commentedon Jun 24, 2026
Yes! Reopen!
melvin-bot commentedon Jun 25, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jun 25, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Jun 28, 2026
Payment Summary
Contributor: @truph01 due $125 via NewDot
Contributor+: @daledah due $125 via NewDot
Starting this at $125 cuz it's a regression (even if it's a new feature, we still don't want regressions, if they should have be caught) and also cuz it's a followup (we really don't want there to be a financial incentive where contributors get $500 ($250 x 2) when causing regressions). I'll leave open for comments for a bit then close. (also... I'm tracking examples like this so we can, finally, document regressions and how to address them).
garrettmknight commentedon Aug 10, 2026
$125 approved for @truph01
quinthar commentedon Aug 19, 2026
Approved $125 to @daledah