Skip to content

[Due for payment 2026-06-26] [Due for payment 2026-06-25] Expense - Your file is ready! modal does not close when click Download file #93874

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.4.10-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92169
Email or phone of affected tester (no customers): gocemate+b215490600@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Windows 10/Chrome
App Component: Other

Action Performed:

  1. Open ND.
  2. Navigate to Spend > Expenses.
  3. Select any expense.
  4. Click the "x selected" dropdown button, then choose Export > All Data - Expense Level.
  5. Verify that the Send me the file when is ready is displayed
  6. Wait a few seconds until the following modal appears: Your file is ready!
  7. Click Download file.

Expected Result:

Your file is ready! modal should close when click Download file

Actual Result:

Your file is ready! modal does not close when click Download file

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7183844_1781722921305.Recording__918.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Nathan Lemma
Bug ID: 7183844

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. applause-bot commented on Jun 17, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/b4f24c2965d930d1e353825ca90ddcc4cb5781a3c366b138a719d24ed05177ed

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 17, 2026
  3. melvin-bot commented on Jun 17, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #92169

  4. melvin-bot commented on Jun 17, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 17, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 17, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    In the "Your file is ready!" state, the Download file button only triggers the download — it never closes the modal. Its handler is wired to downloadFile alone, with no call to onClose/handleClose:

    So the expected behavior (modal closes on Download file) was never implemented — the only way to dismiss is the secondary Close button. This was introduced in #92169.

    What changes do you think we should make in order to solve the problem?

    Make the Download file button download and then dismiss the modal. Add a small handler that runs downloadFile() followed by handleClose() (handleClose already calls clearExportDownload + onClose, line 95-98), and wire it to the button's onPress instead of downloadFile.

    Implementation detail & edge cases
    • The non-concierge ready path already auto-downloads via the useEffect at line 76-82, so the visible Download file button is effectively a manual re-trigger. Closing on press matches the QA-expected flow without affecting the auto-download.
    • Confirm whether closing should also fire when the auto-download useEffect runs, or only on explicit button press. The reported repro is specifically the button, so scoping the fix to the button's onPress is the minimal, safe change.

    What alternative solutions did you explore? (Optional)

    None needed — the gap is a missing dismiss call on a single button handler.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/93874) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. truph01 commented on Jun 18, 2026

    @truph01
    Contributor

    @mollfpr Do we want to close the modal once clicking on "Download file" button?

  8. mollfpr commented on Jun 18, 2026

    @mollfpr
    Contributor

    @truph01 Yeah, this was not planned before, but we decided to close the modal on clicking the Download button. Another fix we want to have with this CP is:

    • Remove the "Close" button below the "Download file" in the ready state. So this means the modal will be dismissible on the ready state.
    • Replace the H1 style textHeadlineH1, create new one exportDownloadTitle
    exportDownloadTitle: {
        ...headlineFont,
        ...whiteSpace.preWrap,
        color: theme.heading,
        fontSize: variables.fontSizeLarge,      // 17 (Figma)
        lineHeight: variables.lineHeightXLarge, // 20 (Figma)
    },
    
  9. truph01 commented on Jun 18, 2026

    @truph01
    Contributor

    @mollfpr Could you assign me and @daledah ?

  10. 16 remaining items

  11. melvin-bot commented on Jun 23, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. truph01 commented on Jun 24, 2026

    @truph01
    Contributor

    @mollfpr Are we eligible for payment here? Since this issue was implementing a new design rather than fixing an existing bug.

  13. mollfpr commented on Jun 24, 2026

    @mollfpr
    Contributor

    Yes! Reopen!

  14. melvin-bot commented on Jun 25, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  15. melvin-bot commented on Jun 25, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @truph01 owed $250 via NewDot
    • Reviewer: @daledah owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. mallenexpensify commented on Jun 28, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @truph01 due $125 via NewDot
    Contributor+: @daledah due $125 via NewDot

    Starting this at $125 cuz it's a regression (even if it's a new feature, we still don't want regressions, if they should have be caught) and also cuz it's a followup (we really don't want there to be a financial incentive where contributors get $500 ($250 x 2) when causing regressions). I'll leave open for comments for a bit then close. (also... I'm tracking examples like this so we can, finally, document regressions and how to address them).

  17. garrettmknight commented on Aug 10, 2026

    @garrettmknight
    Contributor

    $125 approved for @truph01

  18. quinthar commented on Aug 19, 2026

    @quinthar
    Contributor

    Approved $125 to @daledah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions