You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android & iOS - Members - Search field is pushed out of view when role filter is long #93987
Version Number: 9.4.15-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#91464 Email or phone of affected tester (no customers):sdjnoisdjdosijsonssjo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Workspace Settings
Action Performed:
Precondition:
Create a Control workspace.
Invite at least 12 users to the workspace.
Launch Expensify app.
Go to workspace settings > Members.
Tap Role.
Select all roles and tap Apply.
Expected Result:
Search field should be visible when role filter is long.
Actual Result:
Search field is pushed out of view when role filter is long.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
PR #91464 made the member filter multi-select, so the dropdown label can now grow from a single value (Role: All) to a long comma-joined string (Role: Members, Admins, Approvers, Auditor). In the header row, the role dropdown and the search field are siblings inside a flexRow, but only the search field is flexible while the dropdown is allowed to grow up to a hard maxWidth: 256 cap and is given no flexShrink — so on narrow (native) screens the dropdown holds up to ~256px of the row and the flex1 search bar collapses to near-zero width, appearing "pushed out".
Evidence (confidence: high)
Header row places the dropdown next to the SearchBar, and the search bar is the only flexible item (styles.flex1): WorkspaceMembersPage.tsx:1047.
The dropdown wrapper uses styles.flexGrow0 (flexGrow:0, no flexShrink) on narrow layout, so it won't yield space to its sibling: WorkspaceMembersPage.tsx:719.
The shared button hardcodes {maxWidth: 256}; the numberOfLines={1}/flexShrink1 only ellipsize the text within the 256px button, they don't make the button give up row space: DropdownButton.tsx:65.
What changes do you think we should make in order to solve the problem?
Let the dropdown shrink and ellipsize instead of holding a near-fixed width on narrow screens. Add flexShrink: 1 to the dropdown's narrow-layout wrapperStyle in WorkspaceMembersPage.tsx:719 (e.g. [styles.flexGrow0, styles.flexShrink1]) and the same for the Group filter in DomainMembersPage.tsx:117. Combined with the existing numberOfLines={1} + ellipsis on the label, the button label truncates and the flex1 search field keeps a usable width.
What alternative solutions did you explore? (Optional)
Stack on narrow layout: put the filter dropdown on its own line above the search bar when shouldUseNarrowLayout (the page already wraps both in a flexColumn at line 1046). Most robust visually, slightly larger change.
Lower the maxWidth cap on narrow screens in DropdownButton. Less precise — it's a shared component used elsewhere.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/93987) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Testing Melvin manually with this: verify if this issue is reproducable on android: https://github.com/Expensify/App/issues/93987 and take a screenshot to verify
Android verification — could not reproduce in the test environment ⚠️
I attempted to reproduce this on standalone Android NewDot (developmentDebug) but could not stage the precondition, so I have no visual confirmation of the bug. I do not want to imply it's not reproducible — only that I couldn't reach the required state here.
Why the precondition is hard to stage: the search field that gets pushed out only renders once the workspace has ≥ 12 members (STANDARD_LIST_ITEM_LIMIT = 12, WorkspaceMembersPage.tsx:672), and the long "Role: …" label needs multiple roles selected. In a fresh throwaway account that means inviting 11+ members through the UI, and the test emulator's Gboard keyboard repeatedly hijacked the text-entry invite flow (it surfaced Google Calendar / Gboard settings on stray taps, and the unsubmitted invite selection was lost on app restarts). I made four attempts and the workspace stayed at 1 member.
What I did confirm visually: I reached the exact surface where the bug occurs — Workspace ▸ Members, with the role filter dropdown ("All members") rendering directly above where the search bar appears once member count crosses the threshold:
This is a deterministic layout bug, confirmed by code (see my earlier analysis). The filter button and the search field are siblings in a flexRow; only the search field is flexible (flex1) while the dropdown grows up to a fixed maxWidth: 256 with no flexShrink on its narrow-layout wrapper (WorkspaceMembersPage.tsx:719). When the "Role: …" label grows, the dropdown holds its width and the flex1 search field collapses out of view — so a manual repro with a real ≥12-member Control workspace should reliably show the symptom.
Environment notes
Build: standalone Android NewDot (com.expensify.chat.dev, developmentDebug) — not the HybridApp shell, so this covers the RN/JS layer but not OldDot/hybrid-shell or iOS.
Repeated Gboard interference + app cold-restarts (losing the in-progress, unsubmitted member invite) blocked reaching the 12-member threshold. A QA environment with a pre-seeded ≥12-member Control workspace would make this a one-step repro.
Next Steps: Reply with @MelvinBot implement this to create a draft PR for the code-confirmed fix, or @MelvinBot <feedback> to refine.
Activity
applause-bot commentedon Jun 18, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/300c48a04130a0d31059d89ec3b996edec1f78ffe2ac9a6f3c54a424e44f141d
melvin-bot commentedon Jun 18, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #91464
melvin-bot commentedon Jun 18, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 18, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 18, 2026
Proposal
What is the root cause of that problem?
PR #91464 made the member filter multi-select, so the dropdown label can now grow from a single value (
Role: All) to a long comma-joined string (Role: Members, Admins, Approvers, Auditor). In the header row, the role dropdown and the search field are siblings inside aflexRow, but only the search field is flexible while the dropdown is allowed to grow up to a hardmaxWidth: 256cap and is given noflexShrink— so on narrow (native) screens the dropdown holds up to ~256px of the row and theflex1search bar collapses to near-zero width, appearing "pushed out".Evidence (confidence: high)
SearchBar, and the search bar is the only flexible item (styles.flex1):WorkspaceMembersPage.tsx:1047.styles.flexGrow0(flexGrow:0, no flexShrink) on narrow layout, so it won't yield space to its sibling:WorkspaceMembersPage.tsx:719.,:WorkspaceMembersPage.tsx:707.{maxWidth: 256}; thenumberOfLines={1}/flexShrink1only ellipsize the text within the 256px button, they don't make the button give up row space:DropdownButton.tsx:65.Group:filter on Domain members:DomainMembersPage.tsx:117.What changes do you think we should make in order to solve the problem?
Let the dropdown shrink and ellipsize instead of holding a near-fixed width on narrow screens. Add
flexShrink: 1to the dropdown's narrow-layoutwrapperStyleinWorkspaceMembersPage.tsx:719(e.g.[styles.flexGrow0, styles.flexShrink1]) and the same for the Group filter inDomainMembersPage.tsx:117. Combined with the existingnumberOfLines={1}+ ellipsis on the label, the button label truncates and theflex1search field keeps a usable width.What alternative solutions did you explore? (Optional)
shouldUseNarrowLayout(the page already wraps both in aflexColumnat line 1046). Most robust visually, slightly larger change.maxWidthcap on narrow screens inDropdownButton. Less precise — it's a shared component used elsewhere.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/93987)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
Julesssss commentedon Jun 18, 2026
Testing Melvin manually with this:
verify if this issue is reproducable on android: https://github.com/Expensify/App/issues/93987 and take a screenshot to verifyMelvinBot commentedon Jun 19, 2026
Android verification — could not reproduce in the test environment⚠️
I attempted to reproduce this on standalone Android NewDot (
developmentDebug) but could not stage the precondition, so I have no visual confirmation of the bug. I do not want to imply it's not reproducible — only that I couldn't reach the required state here.Why the precondition is hard to stage: the search field that gets pushed out only renders once the workspace has ≥ 12 members (
STANDARD_LIST_ITEM_LIMIT = 12,WorkspaceMembersPage.tsx:672), and the long "Role: …" label needs multiple roles selected. In a fresh throwaway account that means inviting 11+ members through the UI, and the test emulator's Gboard keyboard repeatedly hijacked the text-entry invite flow (it surfaced Google Calendar / Gboard settings on stray taps, and the unsubmitted invite selection was lost on app restarts). I made four attempts and the workspace stayed at 1 member.What I did confirm visually: I reached the exact surface where the bug occurs — Workspace ▸ Members, with the role filter dropdown ("All members") rendering directly above where the search bar appears once member count crosses the threshold:
This is a deterministic layout bug, confirmed by code (see my earlier analysis). The filter button and the search field are siblings in a
flexRow; only the search field is flexible (flex1) while the dropdown grows up to a fixedmaxWidth: 256with noflexShrinkon its narrow-layout wrapper (WorkspaceMembersPage.tsx:719). When the "Role: …" label grows, the dropdown holds its width and theflex1search field collapses out of view — so a manual repro with a real ≥12-member Control workspace should reliably show the symptom.Environment notes
com.expensify.chat.dev,developmentDebug) — not the HybridApp shell, so this covers the RN/JS layer but not OldDot/hybrid-shell or iOS.Next Steps: Reply with
@MelvinBot implement thisto create a draft PR for the code-confirmed fix, or@MelvinBot <feedback>to refine.m-natarajan commentedon Jun 19, 2026
Not reproduced, Xiaomi Redmi Note 10 / Android 12, iphone12/26.5, App 9.4.15-3
Screenrecorder-2026-06-19-10-45-08-456.mp4
ScreenRecording_06-19-2026.08-21-04_1.MP4