Skip to content

[Due for payment 2026-08-29] Add Tax, Billable, and Reimbursable selectors in the Split details page of the Split edit table #94038

Closed

Description

@garrettmknight

FIGMA

Version Number: N/A
Reproducible in staging?: N/A
Reproducible in production?: N/A
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @RachCHopkins
Slack conversation (hyperlinked to channel name): migrate

Action Performed:

  1. Create a workspace, enable tax > add a second tax rate + enable rules
  2. Create an expense on the workspace
  3. In the expense click More > Split
  4. Open one of the splits

Expected Result:

In the expense details of the split, the user should be able to set the tax rate on the individual split and set reimbursable/billable details.

Actual Result:

Tax, Reimbursable, Billable don't show.

Workaround:

The user can split and then set these fields, but in Classic, they can set tax while splitting, so that's a parity issue. Many users also split to make a portion of the expense billable/reimbursable, so we should fix that as an improvement on Classic.

Todos:

  • Add Tax Rate selector

  • Add Reimbursable and Billable toggles

  • Reorder items to reflect how they typically list in the expense:

    1. Description
    1. Date
    1. Cat
    1. Tag
    1. Tax
    1. Reimbursable
    1. Billable
    1. Report

Screenshots/Videos

Updated Screens:

Image

Current behavior:
https://github.com/user-attachments/assets/13df246d-4e92-4298-b348-3953f3cc0193

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    NewFeatureSomething to build that is a new item.
    on Jun 19, 2026
  2. melvin-bot commented on Jun 19, 2026

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  3. melvin-bot commented on Jun 19, 2026

    @melvin-bot

    Summary of changes needed

    Frontend changes

    • src/types/onyx/IOU.ts — Add taxCode?: string, taxAmount?: number, taxValue?: number to the SplitExpense interface.
    • SplitExpenseEditPage.tsx — Add UI rows for Tax Rate, Reimbursable, and Billable (gated by the appropriate policy flags), navigating to the existing MONEY_REQUEST_STEP_TAX_RATE, MONEY_REQUEST_STEP_BILLABLE, and MONEY_REQUEST_STEP_REIMBURSABLE routes.
    • SplitExpenseItems.ts (initSplitExpenseItemData) — Seed taxCode/taxAmount/taxValue from the parent transaction when initializing split items.
    • SplitExpenseItems.ts (updateSplitExpenseField) — Carry taxCode/taxAmount/taxValue through from the draft transaction when saving a split edit.
    • SplitTransactionUpdate.ts — Include taxCode/taxAmount/taxValue in the splits API payload and in the optimistic Onyx merge.
    • SplitTransactionSplitsParam type — Add taxCode, taxAmount, taxValue fields.

    Backend changes

    • UpdateSplitTransaction — Accept explicit per-split taxCode/taxAmount in the payload; use them directly instead of the current proportional fallback. Recalculate the parent transaction's taxAmount as the sum of all per-split values after saving.
    • SplitTransaction (creation path) — Apply the same per-split tax acceptance logic so tax set before the initial save is handled consistently.
    • Validation — Validate incoming per-split tax codes against the workspace's enabled tax rates (same pattern used for category/tag).
  4. self-assigned this
    on Jun 19, 2026
  5. added
    InternalRequires API changes or must be handled by Expensify staff
    and removed
    InternalRequires API changes or must be handled by Expensify staff
    on Jun 19, 2026
  6. garrettmknight commented on Jun 19, 2026

    @garrettmknight
    ContributorAuthor

    Working with @shawnborton on a few tweaks to the screens, but we'll have those in the OP when we're done. @ishpaul777 they shouldn't really chance the BE, so feel free to get started and ask any questions that come up. I'll set it External for the FE when we've got our screens/plan finished.

  7. garrettmknight commented on Jun 22, 2026

    @garrettmknight
    ContributorAuthor

    Alright, visual tweaks done. @ishpaul777 all yours!

  8. 95 remaining items

  9. truph01 commented on Oct 9, 2026

    @truph01
    Contributor

    It looks like all the linked issues have been resolved, so this issue is ready for payment.

    @luacmartins  Initially, we agreed on $500 for this issue. However, a few regressions were introduced during implementation. I’m wondering whether the payment will be reduced because of these regressions.

    FYI, splitting is a complex flow, so it’s difficult to catch every potential bug in a single PR.


    Here are 4 PRs we worked on:

    #94434 (Original)
    #99644
    #99756
    #99212

  10. hoangzinh commented on Oct 9, 2026

    @hoangzinh
    Contributor

    @luacmartins, can you help add me to this issue? I helped to review all four PRs and followed up on other related issues. Thank you!

    I agree with @truph01; this is a new feature request, and it has Tax support, which is always complex. By the way, based on the size of each PR and the effort we spent on this issue, can we consider increasing the original bounty a bit, please? Hopefully it can be $750 🥺

  11. changed the title [-]Add Tax, Billable, and Reimbursable selectors in the Split details page of the Split edit table[/-] [+][Due for payment 2026-08-29] Add Tax, Billable, and Reimbursable selectors in the Split details page of the Split edit table[/+] on Oct 9, 2026
  12. luacmartins commented on Oct 9, 2026

    @luacmartins
    Contributor

    I think we can keep the original agreed priced of $500

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 9, 2026
  14. melvin-bot commented on Oct 9, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  15. mallenexpensify commented on Oct 12, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @truph01 due $500 via NewDot
    Contributor+: @hoangzinh due $500 via NewDot

  16. laurenreidexpensify commented on Oct 14, 2026

    @laurenreidexpensify
    Contributor

    Approved $500 @hoangzinh New Expensify

  17. garrettmknight commented on Nov 14, 2026

    @garrettmknight
    ContributorAuthor

    $500 approved for @truph01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffNewFeatureSomething to build that is a new item.ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions