You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-13] Spend rule - No results appear when searching by valid currency name #94091
Version Number: 9.4.16-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#93063 Email or phone of affected tester (no customers):applausetester+khcategory19@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Enable Expensify card and Rules.
Workspace has at least one virtual Expensify card.
Go to staging.new.expensify.com
Open FAB > Create expense > Manual.
Click Currency.
Type singapore.
→ User can search for currency by typing currency name.
Go to workspace settings > Rules.
Click Add spend rule.
Click Choose cards and select a card.
Click Permitted currencies.
Type singapore.
Expected Result:
Currency will appear when searching by valid currency name.
Actual Result:
No results appear when searching by valid currency name.
There is also no "No results found" message in empty result screen.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The spend-rule "Permitted currencies" search only matches against each row's text — which is the currency code + symbol (e.g. "SGD - $"), never the currency name. So typing singapore matches nothing.
getCurrencyOptions returns the currency name in a separate searchableText field, not in text:
Evidence
SearchUIUtils.ts:4803 builds each option as {text: "${code} - ${symbol}", value: code, searchableText: name}. The name ("Singapore Dollar") lives only in searchableText.
The working manual-expense picker uses CurrencySelectionList, which filters on both fields — CurrencySelectionList/index.tsx:56-60: searchRegex.test(text) || searchRegex.test(currencyName). That's why search-by-name works there but not here.
The second symptom (no "No results found" message) has the same source: SpendRulesCurrencyBase never passes a headerMessage to its SelectionList, whereas CurrencySelectionList renders an empty state via its isEmpty flag.
Introduced by #93063, which added this brand-new picker rather than reusing CurrencySelectionList.
What changes do you think we should make in order to solve the problem?
Carry the currency name onto each list item — add searchableText: currencyOption.searchableText when building currencyItems (around line 69-74), and add the field to the CurrencyListItem type.
Update filterCurrency (line 81-83) to also match the name, e.g. (item.text ?? '').toLowerCase().includes(searchInput) || (item.searchableText ?? '').toLowerCase().includes(searchInput).
Pass a headerMessage to the SelectionList so an empty search shows the standard message — headerMessage={inputValue.trim() && filteredCurrencyItems.length === 0 ? translate('common.noResultsFound') : ''}.
What alternative solutions did you explore? (Optional)
Replace the bespoke list with the shared CurrencySelectionList component (used by the manual picker), which already handles name search and the empty state — larger change, riskier for a deploy blocker.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/94091) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][Due for payment 2026-06-29] Spend rule - No results appear when searching by valid currency name[/-][+][Due for payment 2026-06-30] [Due for payment 2026-06-29] Spend rule - No results appear when searching by valid currency name[/+]on Jun 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.17-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-][Due for payment 2026-06-30] [Due for payment 2026-06-29] Spend rule - No results appear when searching by valid currency name[/-][+][Due for payment 2026-07-13] Spend rule - No results appear when searching by valid currency name[/+]on Jul 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.27-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jun 19, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/476dc658a7fc81bb1d160721668b0416bbc70965a35a1948aafe642fa59c8726
melvin-bot commentedon Jun 19, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #93063
melvin-bot commentedon Jun 19, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 19, 2026
Proposal
What is the root cause of that problem?
The spend-rule "Permitted currencies" search only matches against each row's
text— which is the currency code + symbol (e.g."SGD - $"), never the currency name. So typingsingaporematches nothing.getCurrencyOptionsreturns the currency name in a separatesearchableTextfield, not intext:Evidence
SearchUIUtils.ts:4803builds each option as{text: "${code} - ${symbol}", value: code, searchableText: name}. The name ("Singapore Dollar") lives only insearchableText.SpendRulesCurrencyBase.tsx:69-74copies onlytext/valueinto its list items and dropssearchableText.SpendRulesCurrencyBase.tsx:81-83filters onitem.textonly.The working manual-expense picker uses
CurrencySelectionList, which filters on both fields —CurrencySelectionList/index.tsx:56-60:searchRegex.test(text) || searchRegex.test(currencyName). That's why search-by-name works there but not here.The second symptom (no "No results found" message) has the same source:
SpendRulesCurrencyBasenever passes aheaderMessageto itsSelectionList, whereasCurrencySelectionListrenders an empty state via itsisEmptyflag.Introduced by #93063, which added this brand-new picker rather than reusing
CurrencySelectionList.What changes do you think we should make in order to solve the problem?
In
SpendRulesCurrencyBase.tsx:searchableText: currencyOption.searchableTextwhen buildingcurrencyItems(around line 69-74), and add the field to theCurrencyListItemtype.filterCurrency(line 81-83) to also match the name, e.g.(item.text ?? '').toLowerCase().includes(searchInput) || (item.searchableText ?? '').toLowerCase().includes(searchInput).headerMessageto theSelectionListso an empty search shows the standard message —headerMessage={inputValue.trim() && filteredCurrencyItems.length === 0 ? translate('common.noResultsFound') : ''}.What alternative solutions did you explore? (Optional)
Replace the bespoke list with the shared
CurrencySelectionListcomponent (used by the manual picker), which already handles name search and the empty state — larger change, riskier for a deploy blocker.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/94091)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
9 remaining items
melvin-bot commentedon Jun 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-29. 🎊
melvin-bot commentedon Jun 22, 2026
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-][Due for payment 2026-06-29] Spend rule - No results appear when searching by valid currency name[/-][+][Due for payment 2026-06-30] [Due for payment 2026-06-29] Spend rule - No results appear when searching by valid currency name[/+]melvin-bot commentedon Jun 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.17-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-06-30. 🎊
melvin-bot commentedon Jun 23, 2026
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-][Due for payment 2026-06-30] [Due for payment 2026-06-29] Spend rule - No results appear when searching by valid currency name[/-][+][Due for payment 2026-07-13] Spend rule - No results appear when searching by valid currency name[/+]melvin-bot commentedon Jul 6, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.27-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-13. 🎊
melvin-bot commentedon Jul 6, 2026
@luacmartins / @JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]