You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-30] [$250] "You appear to be offline" message not shown in RHP chats (report/expense/transaction threads) #94359
When offline, the You appear to be offline message is shown in regular chats above the composer, but it is not shown in chats opened in the Right-Hand Panel (RHP) — e.g. report threads, expense threads, and transaction threads.
Expected behavior
The You appear to be offline indicator should appear consistently across all chat composers, including RHP chats (report/expense/transaction threads), the same way it does in regular chats. On mobile it already shows on most screens, so behavior should be consistent.
Actual behavior
Regular chat: offline message is shown. ✅
Report RHP chat: offline message is missing. ❌
Expense RHP chat: offline message is missing. ❌
Steps to reproduce
Go offline.
Open a regular chat → observe the You appear to be offline message above the composer.
Open a report/expense/transaction thread in the RHP → notice the message is missing.
changed the title [-]"You appear to be offline" message not shown in RHP chats (report/expense/transaction threads)[/-][+][$250] "You appear to be offline" message not shown in RHP chats (report/expense/transaction threads)[/+]on Jun 23, 2026
The local evidence matches this recurring failure shape: optimistic transaction/report data is written to one Onyx key but the visible list reads another derived key. Here, src/libs/actions/IOU/SplitTransactionUpdate.ts:39 and src/libs/actions/IOU/SplitTransactionUpdate.ts:147 do not agree on the same expense report, You appear to be offline value, so the user-visible path can show a missing or stale state even though nearby data already has the needed context.
What changes do you think we should make in order to solve the problem?
Update src/libs/actions/IOU/SplitTransactionUpdate.ts:39 to derive expense report, You appear to be offline from the report/transaction source that owns this flow before the value is consumed.
Carry the same normalized value through src/libs/actions/IOU/SplitTransactionUpdate.ts:147; that follows the safer family move to align optimistic/success/failure data with the selector consumed by the screen, so the write/optimistic/read paths agree instead of only changing the visible component.
Keep the change inside the Reports, Expenses, IOU, Transactions surface and avoid changing payment actions, personal/deleted policies.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Add or update a regression in tests/unit/ReportUtils*.ts for the exact issue flow: [$250] "You appear to be offline" message not shown in RHP chats (report/expense/transaction threads).
Cover the counter-case near src/libs/actions/IOU/SplitTransactionUpdate.ts:39 so valid existing expense report, You appear to be offline behavior still works.
Manually repeat the issue steps after the patch and confirm the visible state/action is no longer stale.
What alternative solutions did you explore? (Optional)
I would not add a broad new condition outside these referenced paths; the safer fix is to keep expense report, You appear to be offline consistent at the first read/write boundary shown above.
shouldUseNarrowLayout is true not only on small screens but also for any chat opened inside the Right-Hand Panel, because isInNarrowPaneModal is true there:
The intent of the guard is to avoid a duplicate, since on small screens ScreenWrapper already renders a sticky bottom offline indicator. But that bottom indicator is gated strictly on isSmallScreenWidth, and the wide-screen one defaults to off:
So in a wide-screen RHP thread: isSmallScreenWidth is false → ScreenWrapper shows nothing, while shouldUseNarrowLayout is true → ComposerDefaultFooter hides its own indicator. Nothing renders it anywhere, hence the missing message.
What changes do you think we should make in order to solve the problem?
Gate the composer indicator on !isSmallScreenWidth instead of !shouldUseNarrowLayout, so it mirrors exactly the condition under which ScreenWrapper does NOT show the sticky bottom indicator:
Use isSmallScreenWidth from useResponsiveLayout (with the existing prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth lint-disable comment, as sibling files like ComposerFooter/ComposerSendButton already do). On true mobile the bottom indicator still covers it; on wide-screen RHP threads the composer now renders it; regular wide chats are unchanged.
The same !shouldUseNarrowLayout guard repeats in every non-composer branch of ReportFooter (archived, anonymous, blocked, system chat, admins-only, read-only), so those RHP footers lose the indicator on wide screens too:
They should be switched to isSmallScreenWidth for consistency.
What alternative solutions did you explore? (Optional)
Have the report's ScreenWrapper opt into shouldShowOfflineIndicatorInWideScreen for RHP threads, letting ScreenWrapper own the indicator everywhere. This is more invasive and risks double indicators in regular wide chats, so fixing the composer guard is cleaner.
Regular small-screen chats can rely on the page-level ScreenWrapper offline indicator, but wide-screen RHP chats cannot. ScreenWrapper only shows the default page-level indicator on small screens unless wide-screen display is explicitly enabled:
So in RHP report, expense, and transaction-thread chats on wide screens, both possible indicator paths are disabled: the composer footer hides its indicator because RHP makes shouldUseNarrowLayout true, and the surrounding ScreenWrapper does not render the wide-screen offline indicator.
The same shouldUseNarrowLayout condition is also used in the related non-composer ReportFooter branches, such as archived, anonymous, blocked, system, admins-only, and read-only footers. Those branches should follow the same visibility rule so the offline indicator behavior stays consistent across all report footer states.
What changes do you think we should make in order to solve the problem?
Use isSmallScreenWidth for the offline-indicator visibility decision in both ComposerDefaultFooter and the related non-composer ReportFooter branches instead of using shouldUseNarrowLayout.
The composer/report footer should hide its inline offline indicator only on actual small screens, where the page-level mobile offline indicator already handles the message. It should still render the inline indicator in wide-screen RHP chats, because RHP is a narrow-pane layout but not a small-screen layout.
This also addresses the duplicate-indicator concern raised during review. On actual small screens, isSmallScreenWidth remains true, so the footer-level indicator stays hidden and the existing mobile behavior is preserved. On wide-screen RHP chats, isSmallScreenWidth is false, so the footer-level indicator is shown where the user is actively composing or viewing the report footer. Based on the latest clarification, the expected behavior is to show the offline indicator for all wide-screen RHP chats, including report, expense, and transaction-thread chats.
Required change:
In src/pages/inbox/report/ReportActionCompose/ComposerDefaultFooter.tsx, destructure isSmallScreenWidth from useResponsiveLayout().
Render <OfflineIndicator /> when !isSmallScreenWidth.
Keep the existing containerStyles={[styles.chatItemComposeSecondaryRow]} so the visual spacing matches the current wide composer footer.
Add the existing lint-disable comment used elsewhere when intentionally reading isSmallScreenWidth.
In src/pages/inbox/report/ReportFooter.tsx, destructure isSmallScreenWidth from useResponsiveLayout() together with shouldUseNarrowLayout.
Replace the non-composer footer offline indicator checks from !shouldUseNarrowLayout to !isSmallScreenWidth for archived, anonymous, blocked, system, admins-only, and read-only footer branches.
Keep using shouldUseNarrowLayout for layout-only spacing such as styles.mb5, because that still depends on the narrow-pane layout.
Tests that should be added:
Add or update a ReportActionCompose UI test that mocks offline network state and useResponsiveLayout() as {shouldUseNarrowLayout: true, isSmallScreenWidth: false, isInNarrowPaneModal: true} and asserts that common.youAppearToBeOffline renders.
Add a counter-case for actual small-screen layout {shouldUseNarrowLayout: true, isSmallScreenWidth: true} and assert the composer footer does not render its own inline offline indicator, preventing duplicate mobile indicators.
Add coverage for a non-composer ReportFooter state, such as archived or read-only, and assert that the offline indicator renders when {shouldUseNarrowLayout: true, isSmallScreenWidth: false} but not when {shouldUseNarrowLayout: true, isSmallScreenWidth: true}.
The existing proposal points to src/libs/actions/IOU/SplitTransactionUpdate.ts, but this issue is not caused by optimistic IOU data or transaction/report write paths. The missing UI comes from the composer footer render condition, so changing IOU action logic would not fix the root cause.
I also considered adding route-specific Wide/Super-Wide RHP logic or enabling the wide-screen ScreenWrapper offline indicator on the RHP report pages, but the latest clarification supports showing the offline indicator for all wide-screen RHP chats. Applying the same isSmallScreenWidth condition in the shared composer and ReportFooter paths keeps the behavior consistent without adding route-specific checks.
What alternative solutions did you explore? (Optional)
⚠️@nabi-ebrahimi Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
Please re-state the problem that we are trying to solve in this issue.
When offline, the "You appear to be offline." message is shown above the composer in regular chats, but it is missing in chats opened in the Right-Hand Panel (RHP) — report threads, expense threads, and transaction threads.
What is the root cause of that problem?
The offline message above the composer is rendered by ComposerDefaultFooter, and it is gated on !shouldUseNarrowLayout:
The intent of that guard is "only render the composer's offline indicator on a wide screen, because on a small (mobile) screen the indicator is already rendered at the bottom of the screen by ScreenWrapper." However, shouldUseNarrowLayout is true not only on small screens but also whenever the component is inside a narrow-pane modal — i.e. any RHP chat — even on a wide screen. That is by design in useResponsiveLayout, where shouldUseNarrowLayout = isSmallScreenWidth || isInNarrowPaneModal:
So in an RHP thread on a wide screen, shouldUseNarrowLayout is true, and the composer's offline indicator is hidden. At the same time, ScreenWrapper only renders its own small-screen offline indicator when isSmallScreenWidth is true (and its wide-screen variant defaults to off):
On a wide screen isSmallScreenWidth is false, so ScreenWrapper shows nothing either. The result is that neither the composer nor the screen wrapper shows the offline message in a wide-screen RHP chat — the indicator goes missing. The guard conflates "on mobile" with "in the RHP", but only the "on mobile" case is the one where the bottom ScreenWrapper indicator already covers it.
What changes do you think we should make in order to solve the problem?
In ComposerDefaultFooter, change the guard for the composer's offline indicator from !shouldUseNarrowLayout to !isSmallScreenWidth (read isSmallScreenWidth from useResponsiveLayout instead of, or in addition to, shouldUseNarrowLayout).
With this change:
Wide-screen regular chat: isSmallScreenWidth is false → indicator shown (unchanged).
Wide-screen RHP chat (report/expense/transaction thread): isSmallScreenWidth is false → indicator now shown (the bug is fixed).
Mobile / small screen: isSmallScreenWidth is true → composer indicator hidden, exactly as today, because the bottom ScreenWrapper offline indicator already renders it there (so we avoid a duplicate indicator).
Because the repo has an ESLint rule preferring shouldUseNarrowLayout over isSmallScreenWidth, this intentional use of isSmallScreenWidth should carry the same // eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth comment that ScreenWrapper already uses for the very same reason (showing the offline indicator based on real screen width, not modal context).
What alternative solutions did you explore? (Optional)
An alternative is to leave ComposerDefaultFooter as-is and instead enable the wide-screen offline indicator on the RHP's ScreenWrapper (passing shouldShowOfflineIndicatorInWideScreen). This was rejected because it would place the indicator at the bottom of the RHP screen rather than directly above the composer (inconsistent with regular chats, where it sits above the composer), and it would require threading the prop through the report screen wrapper for RHP contexts only. Fixing the guard in the composer footer keeps the indicator in the same place across all chats with a single, localized change.
The problem is what shouldUseNarrowLayout means. In useResponsiveLayout it is true for both small screens and for any component rendered inside the RHP:
A report/expense/transaction thread opened in the RHP renders the same ReportScreen → ReportFooter → ReportActionCompose → ComposerDefaultFooter, but inside the RIGHT_MODAL_NAVIGATOR, so isInNarrowPaneModal === true and therefore shouldUseNarrowLayout === trueeven on a wide screen. !shouldUseNarrowLayout is then false and the OfflineIndicator is never mounted in the RHP composer.
Why the regular (central‑pane) chat works and the RHP one doesn't: on a wide screen the central pane is not in a modal, so isInNarrowPaneModal === false → shouldUseNarrowLayout === false → the composer indicator shows. On true mobile (isSmallScreenWidth === true) the composer indicator is intentionally hidden because ScreenWrapper renders a global small‑screen offline indicator instead — that one is gated on isSmallScreenWidth, notshouldUseNarrowLayout:
constdisplaySmallScreenOfflineIndicator=isSmallScreenWidth&&(...);constdisplayWideScreenOfflineIndicator=!isSmallScreenWidth&&(... ?? false);// false for ReportScreen
ReportScreen passes no offline‑indicator props, so on a wide screen both ScreenWrapper indicators are off and the only source of the composer offline message is ComposerDefaultFooter. In the RHP that source is suppressed by the shouldUseNarrowLayout gate, and no global one replaces it → the message is missing.
So: RHP composer → isInNarrowPaneModal true → shouldUseNarrowLayout true on wide screen → !shouldUseNarrowLayout false → OfflineIndicator not mounted, and ScreenWrapper's small‑screen indicator is isSmallScreenWidth‑gated (false on wide) → no offline message anywhere → symptom.
Sibling flows with the identical root cause: the non‑composer footers in ReportFooter (archived / anonymous / blocked / system‑chat / admins‑only / read‑only) use the exact same !shouldUseNarrowLayout gate, so an archived/blocked report opened in the RHP on a wide screen is also missing the indicator — e.g. https://github.com/Expensify/App/blob/be8591c9249/src/pages/inbox/report/ReportFooter.tsx#L120-L122 (repeated at L134-L136, L148-L150, L162-L164, L190-L192, L214-L216). Not affected: central‑pane chats (already wide, indicator shows) and any true mobile screen (the ScreenWrapper small‑screen indicator covers them).
What changes do you think we should make in order to solve the problem?
Gate the composer offline indicator on isSmallScreenWidth instead of shouldUseNarrowLayout. That keeps the indicator hidden only on true mobile (where ScreenWrapper shows the global one) and shows it on every wide layout — central pane and RHP. useResponsiveLayout already returns isSmallScreenWidth, and this is exactly the same distinction ScreenWrapper already relies on at L176‑L177 above. The repo already sanctions this with the eslint-disable used in ScreenWrapper/index.tsx#L121-L123.
- const {shouldUseNarrowLayout} = useResponsiveLayout();+ // Use isSmallScreenWidth (not shouldUseNarrowLayout) so the indicator still renders in the RHP on wide screens,+ // where ScreenWrapper's small-screen offline indicator is not shown (it is gated on isSmallScreenWidth).+ // eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth+ const {isSmallScreenWidth} = useResponsiveLayout();
...
- {!shouldUseNarrowLayout && <OfflineIndicator containerStyles={[styles.chatItemComposeSecondaryRow]} />}+ {!isSmallScreenWidth && <OfflineIndicator containerStyles={[styles.chatItemComposeSecondaryRow]} />}
2. (Consistency) src/pages/inbox/report/ReportFooter.tsx — apply the same !shouldUseNarrowLayout → !isSmallScreenWidth change to the 6 non‑composer footer branches (L120-L122, L134-L136, L148-L150, L162-L164, L190-L192, L214-L216) so archived/blocked/system/admins‑only/read‑only threads in the RHP are consistent too. useResponsiveLayout is already called here (it destructures shouldUseNarrowLayout at https://github.com/Expensify/App/blob/be8591c9249/src/pages/inbox/report/ReportFooter.tsx#L56) — just also pull isSmallScreenWidth (with the same eslint‑disable) and swap the gate.
Wide screen, report/expense/transaction thread in RHP, offline → message now shows. ✅
Mobile (small screen), any chat, offline → composer indicator stays hidden, ScreenWrapper's global small‑screen indicator shows (no duplicate). ✅
What alternative solutions did you explore? (Optional)
Enable the ScreenWrapper wide‑screen indicator for ReportScreen by passing shouldShowOfflineIndicatorInWideScreen (drives displayWideScreenOfflineIndicator at https://github.com/Expensify/App/blob/be8591c9249/src/components/ScreenWrapper/index.tsx#L177). Rejected: it would render a second indicator in the central pane (the composer footer already shows one there), and it places the message at the screen bottom rather than directly above the composer where the existing design puts it.
Add isInNarrowPaneModal to the gate (!shouldUseNarrowLayout || isInNarrowPaneModal). This works functionally but is a double negative that re‑expands to "show unless small screen", i.e. exactly !isSmallScreenWidth — the direct form is clearer and matches how ScreenWrapper already decides small‑ vs wide‑screen indicators.
⚠️@yusufdeveloper2903 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
I believe we intentionally chose not to show the offline indicator on RHP chats before because it is already visible in the background.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
@lorretheboy can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal. https://www.upwork.com/jobs/~022084460683290926021
Activity
melvin-bot commentedon Jun 23, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)[-]"You appear to be offline" message not shown in RHP chats (report/expense/transaction threads)[/-][+][$250] "You appear to be offline" message not shown in RHP chats (report/expense/transaction threads)[/+]melvin-bot commentedon Jun 23, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022069504855594848967
godzillaxbox19982014-lgtm commentedon Jun 23, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
[$250] "You appear to be offline" message not shown in RHP chats (report/expense/transaction threads)
What is the root cause of that problem?
I traced this to the path that handles
expense report, You appear to be offline:SplitTransactionUpdate):isPolicyExpenseChat as isPolicyExpenseChatReportUtil,chatReport):const chatReport = allReportsList?.['${ONYXKEYS.COLLECTION.REPORT}${expenseReport?.chatReportID}'];expenseReportParentChat):const expenseReportParentChat = getReportOrDraftReport(chatReport?.parentReportID);src/libs/actions/IOU/SplitTransactionUpdate.ts:39andsrc/libs/actions/IOU/SplitTransactionUpdate.ts:147do not agree on the sameexpense report, You appear to be offlinevalue, so the user-visible path can show a missing or stale state even though nearby data already has the needed context.What changes do you think we should make in order to solve the problem?
src/libs/actions/IOU/SplitTransactionUpdate.ts:39to deriveexpense report, You appear to be offlinefrom the report/transaction source that owns this flow before the value is consumed.src/libs/actions/IOU/SplitTransactionUpdate.ts:147; that follows the safer family move to align optimistic/success/failure data with the selector consumed by the screen, so the write/optimistic/read paths agree instead of only changing the visible component.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
tests/unit/ReportUtils*.tsfor the exact issue flow: [$250] "You appear to be offline" message not shown in RHP chats (report/expense/transaction threads).src/libs/actions/IOU/SplitTransactionUpdate.ts:39so valid existingexpense report, You appear to be offlinebehavior still works.What alternative solutions did you explore? (Optional)
expense report, You appear to be offlineconsistent at the first read/write boundary shown above.lorretheboy commentedon Jun 23, 2026
Proposal
What is the root cause of that problem?
The composer's "You appear to be offline" indicator is gated on
!shouldUseNarrowLayout:App/src/pages/inbox/report/ReportActionCompose/ComposerDefaultFooter.tsx
Lines 11 to 15 in 0aceb72
shouldUseNarrowLayoutistruenot only on small screens but also for any chat opened inside the Right-Hand Panel, becauseisInNarrowPaneModalis true there:App/src/hooks/useResponsiveLayout/index.ts
Lines 57 to 64 in 0aceb72
The intent of the guard is to avoid a duplicate, since on small screens
ScreenWrapperalready renders a sticky bottom offline indicator. But that bottom indicator is gated strictly onisSmallScreenWidth, and the wide-screen one defaults to off:App/src/components/ScreenWrapper/index.tsx
Lines 176 to 177 in 0aceb72
So in a wide-screen RHP thread:
isSmallScreenWidthisfalse→ScreenWrappershows nothing, whileshouldUseNarrowLayoutistrue→ComposerDefaultFooterhides its own indicator. Nothing renders it anywhere, hence the missing message.What changes do you think we should make in order to solve the problem?
Gate the composer indicator on
!isSmallScreenWidthinstead of!shouldUseNarrowLayout, so it mirrors exactly the condition under whichScreenWrapperdoes NOT show the sticky bottom indicator:App/src/pages/inbox/report/ReportActionCompose/ComposerDefaultFooter.tsx
Lines 9 to 19 in 0aceb72
Use
isSmallScreenWidthfromuseResponsiveLayout(with the existingprefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidthlint-disable comment, as sibling files likeComposerFooter/ComposerSendButtonalready do). On true mobile the bottom indicator still covers it; on wide-screen RHP threads the composer now renders it; regular wide chats are unchanged.The same
!shouldUseNarrowLayoutguard repeats in every non-composer branch ofReportFooter(archived, anonymous, blocked, system chat, admins-only, read-only), so those RHP footers lose the indicator on wide screens too:App/src/pages/inbox/report/ReportFooter.tsx
Lines 120 to 124 in 0aceb72
They should be switched to
isSmallScreenWidthfor consistency.What alternative solutions did you explore? (Optional)
Have the report's
ScreenWrapperopt intoshouldShowOfflineIndicatorInWideScreenfor RHP threads, lettingScreenWrapperown the indicator everywhere. This is more invasive and risks double indicators in regular wide chats, so fixing the composer guard is cleaner.nabi-ebrahimi commentedon Jun 23, 2026
🚨 Edited by proposal-police: This proposal was edited at 2026-06-23 19:41:49 UTC.
Proposal
What is the root cause of that problem?
The composer footer hides its own offline indicator whenever
shouldUseNarrowLayoutis true:App/src/pages/inbox/report/ReportActionCompose/ComposerDefaultFooter.tsx
Lines 9 to 15 in eb175af
That condition is too broad because
shouldUseNarrowLayoutis true not only on actual small screens, but also inside RHP / narrow-pane modal routes:App/src/hooks/useResponsiveLayout/index.ts
Lines 58 to 65 in eb175af
Regular small-screen chats can rely on the page-level
ScreenWrapperoffline indicator, but wide-screen RHP chats cannot.ScreenWrapperonly shows the default page-level indicator on small screens unless wide-screen display is explicitly enabled:App/src/components/ScreenWrapper/index.tsx
Lines 174 to 177 in eb175af
So in RHP report, expense, and transaction-thread chats on wide screens, both possible indicator paths are disabled: the composer footer hides its indicator because RHP makes
shouldUseNarrowLayouttrue, and the surroundingScreenWrapperdoes not render the wide-screen offline indicator.The same
shouldUseNarrowLayoutcondition is also used in the related non-composerReportFooterbranches, such as archived, anonymous, blocked, system, admins-only, and read-only footers. Those branches should follow the same visibility rule so the offline indicator behavior stays consistent across all report footer states.What changes do you think we should make in order to solve the problem?
Use
isSmallScreenWidthfor the offline-indicator visibility decision in bothComposerDefaultFooterand the related non-composerReportFooterbranches instead of usingshouldUseNarrowLayout.The composer/report footer should hide its inline offline indicator only on actual small screens, where the page-level mobile offline indicator already handles the message. It should still render the inline indicator in wide-screen RHP chats, because RHP is a narrow-pane layout but not a small-screen layout.
This also addresses the duplicate-indicator concern raised during review. On actual small screens,
isSmallScreenWidthremainstrue, so the footer-level indicator stays hidden and the existing mobile behavior is preserved. On wide-screen RHP chats,isSmallScreenWidthisfalse, so the footer-level indicator is shown where the user is actively composing or viewing the report footer. Based on the latest clarification, the expected behavior is to show the offline indicator for all wide-screen RHP chats, including report, expense, and transaction-thread chats.Required change:
src/pages/inbox/report/ReportActionCompose/ComposerDefaultFooter.tsx, destructureisSmallScreenWidthfromuseResponsiveLayout().<OfflineIndicator />when!isSmallScreenWidth.containerStyles={[styles.chatItemComposeSecondaryRow]}so the visual spacing matches the current wide composer footer.isSmallScreenWidth.src/pages/inbox/report/ReportFooter.tsx, destructureisSmallScreenWidthfromuseResponsiveLayout()together withshouldUseNarrowLayout.!shouldUseNarrowLayoutto!isSmallScreenWidthfor archived, anonymous, blocked, system, admins-only, and read-only footer branches.shouldUseNarrowLayoutfor layout-only spacing such asstyles.mb5, because that still depends on the narrow-pane layout.Tests that should be added:
Add or update a
ReportActionComposeUI test that mocks offline network state anduseResponsiveLayout()as{shouldUseNarrowLayout: true, isSmallScreenWidth: false, isInNarrowPaneModal: true}and asserts thatcommon.youAppearToBeOfflinerenders.Add a counter-case for actual small-screen layout
{shouldUseNarrowLayout: true, isSmallScreenWidth: true}and assert the composer footer does not render its own inline offline indicator, preventing duplicate mobile indicators.Add coverage for a non-composer
ReportFooterstate, such as archived or read-only, and assert that the offline indicator renders when{shouldUseNarrowLayout: true, isSmallScreenWidth: false}but not when{shouldUseNarrowLayout: true, isSmallScreenWidth: true}.The existing proposal points to
src/libs/actions/IOU/SplitTransactionUpdate.ts, but this issue is not caused by optimistic IOU data or transaction/report write paths. The missing UI comes from the composer footer render condition, so changing IOU action logic would not fix the root cause.I also considered adding route-specific Wide/Super-Wide RHP logic or enabling the wide-screen
ScreenWrapperoffline indicator on the RHP report pages, but the latest clarification supports showing the offline indicator for all wide-screen RHP chats. Applying the sameisSmallScreenWidthcondition in the shared composer andReportFooterpaths keeps the behavior consistent without adding route-specific checks.What alternative solutions did you explore? (Optional)
Fixed Demo:
Screencast.From.2026-06-25.07-11-12.mp4
github-actions commentedon Jun 23, 2026
wildan-m commentedon Jun 23, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When offline, the "You appear to be offline." message is shown above the composer in regular chats, but it is missing in chats opened in the Right-Hand Panel (RHP) — report threads, expense threads, and transaction threads.
What is the root cause of that problem?
The offline message above the composer is rendered by
ComposerDefaultFooter, and it is gated on!shouldUseNarrowLayout:App/src/pages/inbox/report/ReportActionCompose/ComposerDefaultFooter.tsx
Lines 13 to 18 in d68fa60
The intent of that guard is "only render the composer's offline indicator on a wide screen, because on a small (mobile) screen the indicator is already rendered at the bottom of the screen by
ScreenWrapper." However,shouldUseNarrowLayoutistruenot only on small screens but also whenever the component is inside a narrow-pane modal — i.e. any RHP chat — even on a wide screen. That is by design inuseResponsiveLayout, whereshouldUseNarrowLayout = isSmallScreenWidth || isInNarrowPaneModal:App/src/hooks/useResponsiveLayout/index.ts
Lines 56 to 64 in d68fa60
So in an RHP thread on a wide screen,
shouldUseNarrowLayoutistrue, and the composer's offline indicator is hidden. At the same time,ScreenWrapperonly renders its own small-screen offline indicator whenisSmallScreenWidthis true (and its wide-screen variant defaults to off):App/src/components/ScreenWrapper/index.tsx
Lines 176 to 177 in d68fa60
On a wide screen
isSmallScreenWidthisfalse, soScreenWrappershows nothing either. The result is that neither the composer nor the screen wrapper shows the offline message in a wide-screen RHP chat — the indicator goes missing. The guard conflates "on mobile" with "in the RHP", but only the "on mobile" case is the one where the bottomScreenWrapperindicator already covers it.What changes do you think we should make in order to solve the problem?
In
ComposerDefaultFooter, change the guard for the composer's offline indicator from!shouldUseNarrowLayoutto!isSmallScreenWidth(readisSmallScreenWidthfromuseResponsiveLayoutinstead of, or in addition to,shouldUseNarrowLayout).With this change:
isSmallScreenWidthisfalse→ indicator shown (unchanged).isSmallScreenWidthisfalse→ indicator now shown (the bug is fixed).isSmallScreenWidthistrue→ composer indicator hidden, exactly as today, because the bottomScreenWrapperoffline indicator already renders it there (so we avoid a duplicate indicator).Because the repo has an ESLint rule preferring
shouldUseNarrowLayoutoverisSmallScreenWidth, this intentional use ofisSmallScreenWidthshould carry the same// eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidthcomment thatScreenWrapperalready uses for the very same reason (showing the offline indicator based on real screen width, not modal context).Compare branch: https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/94359-rhp-composer-offline-indicator?expand=1
What alternative solutions did you explore? (Optional)
An alternative is to leave
ComposerDefaultFooteras-is and instead enable the wide-screen offline indicator on the RHP'sScreenWrapper(passingshouldShowOfflineIndicatorInWideScreen). This was rejected because it would place the indicator at the bottom of the RHP screen rather than directly above the composer (inconsistent with regular chats, where it sits above the composer), and it would require threading the prop through the report screen wrapper for RHP contexts only. Fixing the guard in the composer footer keeps the indicator in the same place across all chats with a single, localized change.yusufdeveloper2903 commentedon Jun 23, 2026
Proposal
What is the root cause of that problem?
The composer's offline message is rendered by
ComposerDefaultFooter, and it is gated on!shouldUseNarrowLayout:https://github.com/Expensify/App/blob/be8591c9249/src/pages/inbox/report/ReportActionCompose/ComposerDefaultFooter.tsx#L11-L15
The problem is what
shouldUseNarrowLayoutmeans. InuseResponsiveLayoutit is true for both small screens and for any component rendered inside the RHP:https://github.com/Expensify/App/blob/be8591c9249/src/hooks/useResponsiveLayout/index.ts#L57-L64
A report/expense/transaction thread opened in the RHP renders the same
ReportScreen→ReportFooter→ReportActionCompose→ComposerDefaultFooter, but inside theRIGHT_MODAL_NAVIGATOR, soisInNarrowPaneModal === trueand thereforeshouldUseNarrowLayout === trueeven on a wide screen.!shouldUseNarrowLayoutis thenfalseand theOfflineIndicatoris never mounted in the RHP composer.Why the regular (central‑pane) chat works and the RHP one doesn't: on a wide screen the central pane is not in a modal, so
isInNarrowPaneModal === false→shouldUseNarrowLayout === false→ the composer indicator shows. On true mobile (isSmallScreenWidth === true) the composer indicator is intentionally hidden becauseScreenWrapperrenders a global small‑screen offline indicator instead — that one is gated onisSmallScreenWidth, notshouldUseNarrowLayout:https://github.com/Expensify/App/blob/be8591c9249/src/components/ScreenWrapper/index.tsx#L176-L177
ReportScreenpasses no offline‑indicator props, so on a wide screen bothScreenWrapperindicators are off and the only source of the composer offline message isComposerDefaultFooter. In the RHP that source is suppressed by theshouldUseNarrowLayoutgate, and no global one replaces it → the message is missing.So: RHP composer →
isInNarrowPaneModaltrue →shouldUseNarrowLayouttrue on wide screen →!shouldUseNarrowLayoutfalse →OfflineIndicatornot mounted, andScreenWrapper's small‑screen indicator isisSmallScreenWidth‑gated (false on wide) → no offline message anywhere → symptom.Sibling flows with the identical root cause: the non‑composer footers in
ReportFooter(archived / anonymous / blocked / system‑chat / admins‑only / read‑only) use the exact same!shouldUseNarrowLayoutgate, so an archived/blocked report opened in the RHP on a wide screen is also missing the indicator — e.g. https://github.com/Expensify/App/blob/be8591c9249/src/pages/inbox/report/ReportFooter.tsx#L120-L122 (repeated at L134-L136, L148-L150, L162-L164, L190-L192, L214-L216). Not affected: central‑pane chats (already wide, indicator shows) and any true mobile screen (theScreenWrappersmall‑screen indicator covers them).What changes do you think we should make in order to solve the problem?
Gate the composer offline indicator on
isSmallScreenWidthinstead ofshouldUseNarrowLayout. That keeps the indicator hidden only on true mobile (whereScreenWrappershows the global one) and shows it on every wide layout — central pane and RHP.useResponsiveLayoutalready returnsisSmallScreenWidth, and this is exactly the same distinctionScreenWrapperalready relies on at L176‑L177 above. The repo already sanctions this with theeslint-disableused inScreenWrapper/index.tsx#L121-L123.1.
src/pages/inbox/report/ReportActionCompose/ComposerDefaultFooter.tsx— https://github.com/Expensify/App/blob/be8591c9249/src/pages/inbox/report/ReportActionCompose/ComposerDefaultFooter.tsx#L11-L152. (Consistency)
src/pages/inbox/report/ReportFooter.tsx— apply the same!shouldUseNarrowLayout→!isSmallScreenWidthchange to the 6 non‑composer footer branches (L120-L122, L134-L136, L148-L150, L162-L164, L190-L192, L214-L216) so archived/blocked/system/admins‑only/read‑only threads in the RHP are consistent too.useResponsiveLayoutis already called here (it destructuresshouldUseNarrowLayoutat https://github.com/Expensify/App/blob/be8591c9249/src/pages/inbox/report/ReportFooter.tsx#L56) — just also pullisSmallScreenWidth(with the same eslint‑disable) and swap the gate.Verify:
ScreenWrapper's global small‑screen indicator shows (no duplicate). ✅What alternative solutions did you explore? (Optional)
Enable the
ScreenWrapperwide‑screen indicator forReportScreenby passingshouldShowOfflineIndicatorInWideScreen(drivesdisplayWideScreenOfflineIndicatorat https://github.com/Expensify/App/blob/be8591c9249/src/components/ScreenWrapper/index.tsx#L177). Rejected: it would render a second indicator in the central pane (the composer footer already shows one there), and it places the message at the screen bottom rather than directly above the composer where the existing design puts it.Add
isInNarrowPaneModalto the gate (!shouldUseNarrowLayout || isInNarrowPaneModal). This works functionally but is a double negative that re‑expands to "show unless small screen", i.e. exactly!isSmallScreenWidth— the direct form is clearer and matches howScreenWrapperalready decides small‑ vs wide‑screen indicators.github-actions commentedon Jun 23, 2026
abbasifaizan70 commentedon Jun 23, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
64 remaining items
melvin-bot commentedon Jul 29, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jul 29, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
sobitneupane commentedon Jul 30, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
I believe we intentionally chose not to show the offline indicator on RHP chats before because it is already visible in the background.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/668129
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-5d13-a28e-dcb3-9141ed555cd4melvin-bot commentedon Aug 3, 2026
@mallenexpensify Huh... This is 4 days overdue. Who can take care of this?
mallenexpensify commentedon Aug 4, 2026
Payment Summary
Contributor: @lorretheboy paid $250 via Upwork
Contributor+: @sobitneupane due $250 via NewDot
@lorretheboy can you please accept the job below? Please reply here and tag me once you have.
If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
https://www.upwork.com/jobs/~022084460683290926021
^ Test case created. Thx
lorretheboy commentedon Aug 4, 2026
@mallenexpensify Thx, I accepted
mallenexpensify commentedon Aug 5, 2026
@lorretheboy paid, summary updated above. Thx.
JmillsExpensify commentedon Sep 18, 2026
$250 approved for @sobitneupane