You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
"You appear to be offline" overlaps Save button #94383
Version Number: 9.4.17-2 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#93185 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: iPhone 15 iOS 26.5 App Component: Workspace Settings
Action Performed:
Sign in to ND with expensifail account, which has access to rulesRevamp beta.
Create a workspace, enable Rules in More features
Open Rules page, go offline
Tap the Flag receipt line items or Require fields for all expenses row, observe the Save button
Expected Result:
Save button is visible in offline mode
Actual Result:
"You appear to be offline" overlaps Save button on "Flag receipt line items" and "Require fields for all expenses" pages
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Please re-state the problem that we are trying to solve in this issue.
When offline, the "You appear to be offline" indicator overlaps the Save button on the Flag receipt line items and Require fields for all expenses Rules pages (added in #93185).
What is the root cause of that problem?
Both pages render their Save Button inside a bare <View style={[styles.ph5, styles.pb5]}> that is a sibling placed after the ScrollView, still inside ScreenWrapper:
Both pages set enableEdgeToEdgeBottomSafeAreaPadding on ScreenWrapper and pass no bottomContent, so when offline ScreenWrapper renders the offline indicator as its last child with styles.stickToBottom (position: absolute; bottom: 0). Because it's absolutely positioned, it consumes no layout space and floats over whatever is at the bottom of the screen. The ScrollView reserves space via addBottomSafeAreaPadding, but the Save button lives in a separate Viewoutside the ScrollView with no offline-indicator padding — so the indicator draws on top of it.
The sibling page that works correctly, RulesRequireReceiptsPage.tsx:172-182, renders its button via FormProvider with addBottomSafeAreaPadding, which forwards addOfflineIndicatorBottomSafeAreaPadding into the scroll content and adds CONST.OFFLINE_INDICATOR_HEIGHT (25px) of bottom padding when offline — pushing the button above the sticky indicator.
stickToBottom = position: absolute; bottom: 0 → no layout space reserved.
The offline padding mechanism the buggy pages lack: useBottomSafeSafeAreaPaddingStyle.ts adds OFFLINE_INDICATOR_HEIGHT only when addOfflineIndicatorBottomSafeAreaPadding is set and offline.
What changes do you think we should make in order to solve the problem?
Wrap each Save button in the shared FixedFooter component (which routes addBottomSafeAreaPadding + addOfflineIndicatorBottomSafeAreaPadding through the same useBottomSafeSafeAreaPaddingStyle path as FormProvider) instead of the bare <View style={[styles.ph5, styles.pb5]}>:
Restructure both pages to render the Save button via FormProvider (like the Require receipts page) so the offline padding is handled automatically. This is more consistent but a larger change; the FixedFooter wrapper is the minimal, targeted fix for a deploy blocker.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/94383) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Activity
applause-bot commentedon Jun 23, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/db023bc7c97bc560d2a1feeb17e1c1de8a9a94252aa5e2839c85cf79b2a7ce2a
melvin-bot commentedon Jun 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #93185
melvin-bot commentedon Jun 23, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 23, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When offline, the "You appear to be offline" indicator overlaps the Save button on the Flag receipt line items and Require fields for all expenses Rules pages (added in #93185).
What is the root cause of that problem?
Both pages render their Save
Buttoninside a bare<View style={[styles.ph5, styles.pb5]}>that is a sibling placed after theScrollView, still insideScreenWrapper:RulesProhibitedDefaultPage.tsx:162RulesRequireFieldsPage.tsx:139Both pages set
enableEdgeToEdgeBottomSafeAreaPaddingonScreenWrapperand pass nobottomContent, so when offlineScreenWrapperrenders the offline indicator as its last child withstyles.stickToBottom(position: absolute; bottom: 0). Because it's absolutely positioned, it consumes no layout space and floats over whatever is at the bottom of the screen. TheScrollViewreserves space viaaddBottomSafeAreaPadding, but the Save button lives in a separateViewoutside the ScrollView with no offline-indicator padding — so the indicator draws on top of it.The sibling page that works correctly,
RulesRequireReceiptsPage.tsx:172-182, renders its button viaFormProviderwithaddBottomSafeAreaPadding, which forwardsaddOfflineIndicatorBottomSafeAreaPaddinginto the scroll content and addsCONST.OFFLINE_INDICATOR_HEIGHT(25px) of bottom padding when offline — pushing the button above the sticky indicator.Supporting evidence
ScreenWrapperappends the offline indicator as its last child and makes it sticky in edge-to-edge mode with nobottomContent:ScreenWrapper/index.tsx,ScreenWrapperOfflineIndicators.tsx.stickToBottom=position: absolute; bottom: 0→ no layout space reserved.useBottomSafeSafeAreaPaddingStyle.tsaddsOFFLINE_INDICATOR_HEIGHTonly whenaddOfflineIndicatorBottomSafeAreaPaddingis set and offline.What changes do you think we should make in order to solve the problem?
Wrap each Save button in the shared
FixedFootercomponent (which routesaddBottomSafeAreaPadding+addOfflineIndicatorBottomSafeAreaPaddingthrough the sameuseBottomSafeSafeAreaPaddingStylepath asFormProvider) instead of the bare<View style={[styles.ph5, styles.pb5]}>:Apply to both
RulesProhibitedDefaultPage.tsx:162andRulesRequireFieldsPage.tsx:139. This reserves the 25px above the sticky indicator and matches the working Require receipts page.What alternative solutions did you explore?
Restructure both pages to render the Save button via
FormProvider(like the Require receipts page) so the offline padding is handled automatically. This is more consistent but a larger change; theFixedFooterwrapper is the minimal, targeted fix for a deploy blocker.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/94383)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
melvin-bot commentedon Jun 24, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
luacmartins commentedon Jun 24, 2026
Feature is behind a beta, NAB.
melvin-bot commentedon Jun 29, 2026
@Krishna2323 Huh... This is 4 days overdue. Who can take care of this?
Krishna2323 commentedon Jun 30, 2026
@luacmartins Fixed in #94478, we can close this issue.