Skip to content

"You appear to be offline" overlaps Save button #94383

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.17-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93185
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: iPhone 15 iOS 26.5
App Component: Workspace Settings

Action Performed:

  1. Sign in to ND with expensifail account, which has access to rulesRevamp beta.
  2. Create a workspace, enable Rules in More features
  3. Open Rules page, go offline
  4. Tap the Flag receipt line items or Require fields for all expenses row, observe the Save button

Expected Result:

Save button is visible in offline mode

Actual Result:

"You appear to be offline" overlaps Save button on "Flag receipt line items" and "Require fields for all expenses" pages

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Image
Bug7189047_1782244720315.save_button.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7189047

Issue OwnerCurrent Issue Owner: @Krishna2323
Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. applause-bot commented on Jun 23, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/db023bc7c97bc560d2a1feeb17e1c1de8a9a94252aa5e2839c85cf79b2a7ce2a

  2. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 23, 2026
  3. melvin-bot commented on Jun 23, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #93185

  4. melvin-bot commented on Jun 23, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jun 23, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jun 23, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When offline, the "You appear to be offline" indicator overlaps the Save button on the Flag receipt line items and Require fields for all expenses Rules pages (added in #93185).

    What is the root cause of that problem?

    Both pages render their Save Button inside a bare <View style={[styles.ph5, styles.pb5]}> that is a sibling placed after the ScrollView, still inside ScreenWrapper:

    Both pages set enableEdgeToEdgeBottomSafeAreaPadding on ScreenWrapper and pass no bottomContent, so when offline ScreenWrapper renders the offline indicator as its last child with styles.stickToBottom (position: absolute; bottom: 0). Because it's absolutely positioned, it consumes no layout space and floats over whatever is at the bottom of the screen. The ScrollView reserves space via addBottomSafeAreaPadding, but the Save button lives in a separate View outside the ScrollView with no offline-indicator padding — so the indicator draws on top of it.

    The sibling page that works correctly, RulesRequireReceiptsPage.tsx:172-182, renders its button via FormProvider with addBottomSafeAreaPadding, which forwards addOfflineIndicatorBottomSafeAreaPadding into the scroll content and adds CONST.OFFLINE_INDICATOR_HEIGHT (25px) of bottom padding when offline — pushing the button above the sticky indicator.

    Supporting evidence

    What changes do you think we should make in order to solve the problem?

    Wrap each Save button in the shared FixedFooter component (which routes addBottomSafeAreaPadding + addOfflineIndicatorBottomSafeAreaPadding through the same useBottomSafeSafeAreaPaddingStyle path as FormProvider) instead of the bare <View style={[styles.ph5, styles.pb5]}>:

    <FixedFooter addBottomSafeAreaPadding addOfflineIndicatorBottomSafeAreaPadding>
        <Button success large text={translate('common.save')} onPress={handleSave} ... />
    </FixedFooter>

    Apply to both RulesProhibitedDefaultPage.tsx:162 and RulesRequireFieldsPage.tsx:139. This reserves the 25px above the sticky indicator and matches the working Require receipts page.

    What alternative solutions did you explore?

    Restructure both pages to render the Save button via FormProvider (like the Require receipts page) so the offline padding is handled automatically. This is more consistent but a larger change; the FixedFooter wrapper is the minimal, targeted fix for a deploy blocker.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94383) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. melvin-bot commented on Jun 24, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. luacmartins commented on Jun 24, 2026

    @luacmartins
    Contributor

    Feature is behind a beta, NAB.

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jun 24, 2026
  10. melvin-bot commented on Jun 29, 2026

    @melvin-bot

    @Krishna2323 Huh... This is 4 days overdue. Who can take care of this?

  11. Krishna2323 commented on Jun 30, 2026

    @Krishna2323
    Contributor

    @luacmartins Fixed in #94478, we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions