Skip to content

[Due for payment 2026-07-06] [WIP] [Performance] Resolve destinationReportID before confirmation mount in global-create #94462

Closed

Description

@mountiny

Problem

Single-screen global-create flows (workspace expenses, self-DM tracking) had transaction.reportID undefined at Confirmation mount time. The old multi-step flow called setTransactionReport before navigation, but the single-screen NEW_MANUAL_EXPENSE_FLOW bypasses this. The pre-insert effect fired with no destination, and subsequent setTransactionReport triggered cleanup that removed the pre-insert without replacement because hasPreInsertFired stayed true — contributing to ~56% DEFAULT handler rate in Sentry.

Solution

Extracted resolveEarlyReportID in useResetIOUType to set transaction.reportID immediately after initMoneyRequest for global-create flows with resolved default participants. Reset hasPreInsertFired in the pre-insert cleanup so it can re-fire when destinationReportID transitions from undefined to a valid value.

PR

#94459

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jun 24, 2026
  2. changed the title [-][WIP] [Performance] Resolve `destinationReportID` before confirmation mount in global-create[/-] [+][Due for payment 2026-07-06] [WIP] [Performance] Resolve `destinationReportID` before confirmation mount in global-create[/+] on Jun 29, 2026
  3. melvin-bot commented on Jun 29, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  4. 13 remaining items

  5. melvin-bot commented on Jul 5, 2026

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @mallenexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  6. melvin-bot commented on Jul 5, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @JakubKorytko does not require payment (Contractor)
    • ROLE: @dmkt9 paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  7. mallenexpensify commented on Jul 6, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @dmkt9 paid $250 via Upwork

  8. dmkt9 commented on Jul 7, 2026

    @dmkt9
    Contributor

    Payment Summary

    Contributor+: @dmkt9 due $250 via NewDot

    @mallenexpensify I am still receiving payment through Upwork.

  9. mallenexpensify commented on Jul 7, 2026

    @mallenexpensify
    Contributor

    @dmkt9 can you please accept the job below? Please reply here and tag me once you have.

    https://www.upwork.com/jobs/~022074629754533186042

  10. dmkt9 commented on Jul 8, 2026

    @dmkt9
    Contributor

    @dmkt9 can you please accept the job below? Please reply here and tag me once you have.

    @mallenexpensify Thanks. I've accepted the offer.

  11. mallenexpensify commented on Jul 8, 2026

    @mallenexpensify
    Contributor

    @dmkt9 paid, summary updated above. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions