Skip to content

TETSING Save button on Pronouns page is hidden by device navigation bar #94746

Closed

Description

@Julesssss

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.8-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #92749
Email or phone of affected tester (no customers): jsodinjosdjsoinjsiojs@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: User Settings

Action Performed:

Precondition:

  • Set device navigation to bar instead of gestures.
  1. Launch Expensify app.
  2. Go to Account > Profile > Pronouns.
  3. Dismiss the keyboard.

Expected Result:

Save button on Pronouns page will be above device navigation bar.

Actual Result:

Save button on Pronouns page is hidden by device navigation bar.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Image

View all open jobs on GitHub

Applause Internal Information
Exported by: Nathan Lemma
Bug ID: 7182672

Issue OwnerCurrent Issue Owner: @truph01
Upwork Automation - Do Not Edit

Activity

  1. MelvinBot commented on Jun 27, 2026

    @MelvinBot
    Contributor

    ⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

    Run details

  2. melvin-bot commented on Jun 30, 2026

    @melvin-bot

    Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  3. MelvinBot commented on Jul 1, 2026

    @MelvinBot
    Contributor

    ⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

    Run details

  4. MelvinBot commented on Jul 1, 2026

    @MelvinBot
    Contributor

    🤖 I could not run the requested agent-device verification for this one.

    This is an Android-native bug — the Save button on the Pronouns page being hidden behind the device navigation bar (3-button nav) is a bottom safe-area-inset problem that only manifests on a real Android surface. My agent-device environment this run only has a desktop/web target booted; no Android emulator is available (agent-device boot --platform android → DEVICE_NOT_FOUND). The web driver has no device navigation bar, so it can't reproduce or validate this bug — a "looks fine on web" result would be misleading.

    So this needs a run on the Android agent-device path (booted emulator with 3-button navigation) to get a real verdict.

    Code-level context (not a verdict)

    The page renders the Save button as the SelectionList confirm footer (confirmButtonOptions) inside a ScreenWrapper that already sets includeSafeAreaPaddingBottom:

    src/pages/settings/Profile/PronounsPage.tsx

    Whether the SelectionList footer actually respects the bottom inset once the keyboard is dismissed is exactly what the Android run needs to confirm — it can't be settled from the source alone.


    Next Steps: Re-run me on the Android agent-device path (booted emulator), or reply with @MelvinBot <feedback>.

  5. MelvinBot commented on Jul 1, 2026

    @MelvinBot
    Contributor

    🤖 Could not reproduce — the Save button renders correctly above the bottom system bar on current main, but with an important caveat about the exact precondition (see below).

    I drove the standalone Android NewDot build (developmentDebug) on an emulator against today's main and navigated to Account → Profile → Pronouns. The Save button sits at the bottom of the screen with a clear inset above the system navigation bar — it is fully visible and tappable, not obscured.

    Pronouns page on standalone Android NewDot: Save button fully visible above the bottom navigation bar

    Evidence + caveats
    • Measured button bounds in the resting (keyboard-dismissed) state: the Save button bottom edge is ~114px above the screen bottom on a 2400px-tall screen, i.e. it consumes the bottom safe-area inset rather than extending under the nav bar. Reported as visibleToUser: true, hittable: true.
    • The page renders the Save button as the SelectionList confirm footer inside a ScreenWrapper with includeSafeAreaPaddingBottom — src/pages/settings/Profile/PronounsPage.tsx. That padding is driven by the live system inset, so it scales with whatever navigation mode is active.

    Two caveats — I could not exactly match the reported precondition:

    1. Navigation mode: the emulator was in gesture navigation; I couldn't switch it to 3-button ("bar") navigation — the exact precondition — in this environment. The inset mechanism is the same code path in both modes (it reads the live insets.bottom, which is larger for the 3-button bar), and here the button clearly honors that inset, so it's very likely fine in 3-button mode too — but I couldn't confirm that specific mode directly.
    2. Keyboard dismiss: the emulator had a hardware keyboard attached, so the soft keyboard didn't render and I couldn't perform the literal "open keyboard → dismiss" gesture. I did observe the footer lift while the field was focused and return cleanly to a bottom position (with proper inset) when unfocused, which is the post-dismiss resting state the report describes.

    Scope: verified on standalone Android NewDot only — this does not speak to HybridApp-shell behavior or iOS.


    Next Steps: If you can confirm on a physical device with 3-button navigation and it still repros, reply with @MelvinBot <feedback> and I'll dig into the safe-area handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions