You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-14] [Perf] checkmark / thumbs-up animations are computed but never rendered #94944
In the money request report preview, there are two animated shared values: checkMarkScale and thumbsUpScale.
They are set in effects when an expense is paid (isPaidAnimationRunning) and when a report is approved (isApprovedAnimationRunning). But nothing reads them. There is no .get() on them, no animated style built from them, and no icon that uses them. So the animations run but nothing shows on screen.
This is old code, not something new. Today it lives in MoneyRequestReportPreviewContent. After PR #94675 it moves into the new usePreviewMessageAnimation hook, and the hook docstring even says it plays "checkmark / thumbs-up spring animations on settle / approval" — but they don't render.
The names suggest these were meant to show a checkmark when an expense is paid and a thumbs-up when it is approved. So this could be a real missing animation, not just dead code. We need to decide which case it is.
Goal
If these animations are not needed, remove both shared values and their effects, and fix the docstring so it only mentions the opacity animation.
If they are supposed to show, wire the scales to the checkmark / thumbs-up icons so the animations actually render.
It looks like this has been dead code since it first landed on main. It was introduced in : #58479, although an early commit in that PR briefly wired these values to inline animated icons, the final merged version already rendered the icons statically via ImageSVG, leaving checkMarkScale / thumbsUpScale unused.
It was later touched in #65997 but the visible success checkmark/thumbs-up animation is handled separately by AnimatedSettlementButton, so removing these unused shared values shouldn't affect the current UI.
Prepared a draft PR that removes this dead code: #94955
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.28-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
OlimpiaZurek commentedon Jun 30, 2026
It looks like this has been dead code since it first landed on
main. It was introduced in : #58479, although an early commit in that PR briefly wired these values to inline animated icons, the final merged version already rendered the icons statically viaImageSVG, leavingcheckMarkScale/thumbsUpScaleunused.It was later touched in #65997 but the visible success checkmark/thumbs-up animation is handled separately by
AnimatedSettlementButton, so removing these unused shared values shouldn't affect the current UI.Prepared a draft PR that removes this dead code: #94955
mountiny commentedon Jun 30, 2026
Thanks! I dont think we will need C+ for the review so please note it on the PR before you mark it ready for a review
OlimpiaZurek commentedon Jul 3, 2026
I resolved the conflicts on the PR: #94955. I think it's good to merge now.
1 remaining item
melvin-bot commentedon Jul 7, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 7, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.28-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 10, 2026
@Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!
Krishna2323 commentedon Jul 11, 2026
PR in prod, checklist isn't required here.
melvin-bot commentedon Jul 11, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Jul 13, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Jul 16, 2026
Payment Summary
Contributor+: @Krishna2323 due $250 via NewDot
laurenreidexpensify commentedon Jul 24, 2026
$250 approved for @Krishna2323