Skip to content

[Due for payment 2026-07-14] [Perf] checkmark / thumbs-up animations are computed but never rendered #94944

Closed

Description

@cristipaval

Problem

In the money request report preview, there are two animated shared values: checkMarkScale and thumbsUpScale.

They are set in effects when an expense is paid (isPaidAnimationRunning) and when a report is approved (isApprovedAnimationRunning). But nothing reads them. There is no .get() on them, no animated style built from them, and no icon that uses them. So the animations run but nothing shows on screen.

This is old code, not something new. Today it lives in MoneyRequestReportPreviewContent. After PR #94675 it moves into the new usePreviewMessageAnimation hook, and the hook docstring even says it plays "checkmark / thumbs-up spring animations on settle / approval" — but they don't render.

See the discussion: #94675 (comment)

Question to answer first

The names suggest these were meant to show a checkmark when an expense is paid and a thumbs-up when it is approved. So this could be a real missing animation, not just dead code. We need to decide which case it is.

Goal

  • If these animations are not needed, remove both shared values and their effects, and fix the docstring so it only mentions the opacity animation.
  • If they are supposed to show, wire the scales to the checkmark / thumbs-up icons so the animations actually render.

Related

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. OlimpiaZurek commented on Jun 30, 2026

    @OlimpiaZurek
    Contributor

    It looks like this has been dead code since it first landed on main. It was introduced in : #58479, although an early commit in that PR briefly wired these values to inline animated icons, the final merged version already rendered the icons statically via ImageSVG, leaving checkMarkScale / thumbsUpScale unused.

    It was later touched in #65997 but the visible success checkmark/thumbs-up animation is handled separately by AnimatedSettlementButton, so removing these unused shared values shouldn't affect the current UI.

    Prepared a draft PR that removes this dead code: #94955

  2. mountiny commented on Jun 30, 2026

    @mountiny
    Contributor

    Thanks! I dont think we will need C+ for the review so please note it on the PR before you mark it ready for a review

  3. OlimpiaZurek commented on Jul 3, 2026

    @OlimpiaZurek
    Contributor

    I resolved the conflicts on the PR: #94955. I think it's good to merge now.

  4. added and removed
    ReviewingHas a PR in review
    on Jul 7, 2026
  5. 1 remaining item

  6. melvin-bot commented on Jul 7, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  7. melvin-bot commented on Jul 7, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.28-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-14. 🎊

    For reference, here are some details about the assignees on this issue:

  8. melvin-bot commented on Jul 10, 2026

    @melvin-bot

    @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  9. Krishna2323 commented on Jul 11, 2026

    @Krishna2323
    Contributor

    PR in prod, checklist isn't required here.

  10. melvin-bot commented on Jul 11, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  11. melvin-bot commented on Jul 13, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. mallenexpensify commented on Jul 16, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Krishna2323 due $250 via NewDot

  13. laurenreidexpensify commented on Jul 24, 2026

    @laurenreidexpensify
    Contributor

    $250 approved for @Krishna2323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionTaskWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions