Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.4.25-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #90937
Email or phone of affected tester (no customers): nsjoijojosdjosjosj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
- Create a Control workspace.
- Add value to Custom field 1 and Custom field 2 in your profile via workspace settings > Members.
- Go to staging.new.expensify.com
- Go to workspace chat.
- Create two expenses.
- Go to Spend > Expenses.
- Click Display > Edit columns.
- Select Custom field 1 and Custom field 2 > Save.
- Go to workspace settings > Members.
- Click on your profile.
- Edit Custom field 1 and Custom field 2.
- Go to Spend tab.
Expected Result:
Custom field 1 and Custom field 2 will update after opening Spend.
Actual Result:
Custom field 1 and Custom field 2 do not update after opening Spend.
It only updates after opening Inbox and returning to Spend or opening the expense.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7195342_1782821667523.2.mp4
Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7195342
Issue Owner
Current Issue Owner: @shubham1206agraMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
applause-bot commentedon Jun 30, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/d066ff5b50bc214f507553facc2c58c48e8bada6de0f431e322d7d31ca4ca739
melvin-bot commentedon Jun 30, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90937
melvin-bot commentedon Jun 30, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jun 30, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jun 30, 2026
Proposal
Root Cause: The Spend > Expenses table renders Custom field 1/2 from
report.submitterUserID/report.submitterPayrollID, which are only ever populated by the backend Search response into thesnapshot_<hash>Onyx data. Editing a member's custom field writes to a completely different Onyx location —policy_<id>.employeeList[login].employeeUserID/employeePayrollID— and nothing on the client recomputes the report fields from it. So the columns stay stale until the Search API re-runs (which happens on screen re-focus), which is exactly why navigating to Inbox and back, or opening the expense, fixes it.PR #90937 introduced this by intentionally rendering only from the report fields with no
policy.employeeListfallback (stated in the PR description), so optimistic member edits never reach the table.What is the root cause of that problem?
Two disjoint data sources:
Policy.tsupdateMemberCustomField→policy.employeeList[login].employeeUserID/employeePayrollID(mapping inCONST.CUSTOM_FIELD_KEYS).report.submitterUserID/submitterPayrollID(TransactionItemRowWide.tsx:136-138,ExpenseReportListItemRowWide.tsx:53-54), sourced from the Search snapshot.These report fields have no client-side writer — a grep of
src/showssubmitterUserID/submitterPayrollIDare only read, never written by any optimistic update. They refresh only whensearch()re-runs, which is triggered on Search screen re-focus inSearch/index.tsx:360-396.What changes do you think we should make in order to solve the problem?
In the row components that render the columns, derive Custom field 1/2 from the live policy member data and fall back to the report field, so optimistic edits to
policy.employeeListare reflected immediately:ownerAccountIDvia personal details).policy.employeeList[submitterLogin].employeeUserID/employeePayrollID(viaCONST.CUSTOM_FIELD_KEYS) reactively (the policy collection is already in Onyx).report.submitterUserID/submitterPayrollIDwhen the member data isn't available.This re-adds the
policy.employeeListfallback that PR #90937 deliberately omitted, which is the source of the staleness. Apply it in bothTransactionItemRowWide.tsxandExpenseReportListItemRowWide.tsx(and the equivalent logic inReportUtils.getReportCustomColumnValueif shared).What alternative solutions did you explore? (Optional)
updateMemberCustomFieldalso optimistically update the report/snapshot fields for the member's reports. More complex — it must find every report submitted by that member and mergesubmitterUserID/submitterPayrollIDinto both live reports and active snapshots; the display-layer fallback is simpler and inherently reactive.UpdatePolicyMembersCustomFieldsreturns onyx updates for the affected reports/snapshots. If the intended design is for the column to mirror live member data, the client fallback is still the cleaner path.Investigation details & evidence
Confidence: High — two independent investigations agreed; fully explained by static analysis of disjoint Onyx data sources.
Data flow:
updateMemberCustomFieldoptimistically merges intopolicy_<id>.employeeList[login].employeeUserID/employeePayrollIDonly.report.submitterUserID/submitterPayrollIDfrom the Search snapshot (SearchUIUtils.getReportSections~:2805,getTransactionsSections~:2081).search()→ Search API rewrites the snapshot with fresh values → table updates. (Same effect from opening the expense / re-fetching the report.)Field definitions are display-only:
Report.ts:101-108documentsubmitterUserID= "Custom field 1 value for the report submitter" andsubmitterPayrollID= "Custom field 2 value".This is entirely within the App repo (the display layer reads the wrong/stale source), so a client-side fix is viable without backend changes.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/94960)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
grgia commentedon Jun 30, 2026
Discussing in slack, may be a BE bug. @shubham1206agra @KJ21-ENG
Would you please write the command / incorrect reponse you're encountering
48 remaining items
melvin-bot commentedon Nov 12, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
mallenexpensify commentedon Nov 13, 2026
Claude posting on behalf of Matt:
Hold/$0. Job price: $250 for shubham1206agra, assigned 2026-06-30, before 2026-09-19. The title says $175.
shubham1206agra approved #90937, the cause. This issue was created 2026-06-30, before #90937 reached production on 2026-07-01. That is inside the regression window.
Next: close.
Evidence
PAYPREP v1mallenexpensify commentedon Nov 13, 2026
@shubham1206agra plz complete the Contributor+ checklist and tag me in a post once you have.
I'm planning to not pay on this issue, comment if you disagree
shubham1206agra commentedon Nov 14, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: NA as this is a BE issue which came up after feat: add three report custom columns to expense tables #90937 has been deployed.
Link to the comment on the Issue: NA
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Custom field 1andCustom field 2.Test:
Custom field 1andCustom field 2, then click Save.Custom field 1andCustom field 2columns for your expenses.Custom field 1, enter a new value, and click Save.Custom field 2, enter a new value, and click Save.Custom field 1andCustom field 2columns show the new values without opening Inbox or the expense first.Do we agree 👍 or 👎
shubham1206agra commentedon Nov 14, 2026
@mallenexpensify This is not exactly a regression as this is a design change which required discussion and BE/FE PRs to work.
mallenexpensify commentedon Nov 15, 2026
@shubham1206agra, @MelvinBot is there a link to confirm this?
MelvinBot commentedon Nov 15, 2026
There are links confirming discussion and BE/FE work, but not conclusively the “not a regression” claim:
KioCoanconfirmed the backend PR was merged, supporting the frontend “Add three report custom columns to expense tables”.shubham1206agralinked the Slack thread here.grgialater explicitly said “FE only”. The resolving PR, “Refetch results when a member’s custom fields change”, describes refreshing stale search results.So the original feature required BE/FE coordination, but these references don’t establish that this stale-value bug was an agreed design change rather than a regression.
view run
shubham1206agra commentedon Nov 15, 2026
@grgia Can you please chime in here?
grgia commentedon Nov 16, 2026
The fix ended up FE only (#103441). Spend wasn't refetching its results after a member's custom field changed, no BE or design change shipped. It was a gap in #90937 caught on staging. @mallenexpensify payment call is yours.
mallenexpensify commentedon Nov 16, 2026
Thanks @grgia. That confirms the bug came from #90937: the fix was FE only, with no BE or design change. @shubham1206agra approved #90937, and work to fix a regression caused by the PR is unpaid. No payment on this issue. Closing.
@shubham1206agra comment/reopen if you disagree