Skip to content

[Due for payment 2026-07-28] [M3] Migrate InlineIcon usages #95159

Closed

Description

@mountiny

Problem

Several buttons render icons inline within text via Icon's inline prop, keeping inline layout logic inside the monolithic Icon facade. After M1 lands the dedicated InlineIcon primitive, these call sites should import it directly so the inline branch can be removed from Icon.

Solution

Replace each Icon usage that sets inline with a direct InlineIcon import, mapping props to the primitive's API (contentSize, iconWidth, iconHeight, etc.). Once no call sites remain, remove the inline prop and its branch from src/components/Icon/index.tsx.

Known call sites on main:

Verify for any additional Icon + inline usages after M1 merges (the M1 PR cites three call sites).

Acceptance criteria

  • No remaining Icon usages with inline in src/.
  • Inline copy and icon alignment unchanged in affected buttons.

Dependencies

Blocked by #95156 (M1 must merge first).

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Jul 2, 2026
  2. roryabraham commented on Jul 28, 2026

    @roryabraham
    Contributor

    I think $250 due to @Pujan92 for review of #95286

  3. changed the title [-][M3] Migrate InlineIcon usages[/-] [+][Due for payment 2026-07-28] [M3] Migrate InlineIcon usages[/+] on Jul 28, 2026
  4. melvin-bot commented on Jul 28, 2026

    @melvin-bot

    Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.

  5. roryabraham commented on Jul 28, 2026

    @roryabraham
    Contributor

    @mallenexpensify ready for payment

  6. melvin-bot commented on Jul 28, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @jmusial does not require payment (Contractor)
    • Reviewer: @Pujan92 owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  7. mallenexpensify commented on Jul 30, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Pujan92 due $250 via NewDot

  8. twisterdotcom commented on Aug 4, 2026

    @twisterdotcom
    Contributor

    $250 approved for @Pujan92 in Report ID: R00KnehTMFam.

    Zapier Logs Run ID: 00040eee-eaac-a7e7-b2ee-1d3601327e84

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionInternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewTaskWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions