Repository navigation
Create a FullPageNotFoundView component #9522
Description
Problem
Similar to our <FullPageOfflineView /> (#9165) we need a full page "not found" view to display when a user attempts to view a resource that doesn't exist or they have lost access to.
Solution
Create a <FullPageNotFoundView /> component that replaces the child view when a show prop is set to true.
Activity
melvin-bot commentedon Jun 24, 2022
@arosiclair Whoops! This issue is 2 days overdue. Let's get this updated quick!
arosiclair commentedon Jun 27, 2022
I'll implement this this week.
arosiclair commentedon Jun 29, 2022
For this, I think we should reuse the same presentation as our
FullPageOfflineBlockingViewbelow just with a different icon and message.@shawnborton do you agree? And if so which icon and message do you think we should use?
shawnborton commentedon Jun 29, 2022
Totally. We could do something very generic like the offline page you mentioned, something like this?
Questions:
arosiclair commentedon Jun 29, 2022
@shawnborton Thanks!
Your first guess is correct though it could also be used for other non-workspace pages. This view would replace the content of the page/pane that can't be viewed in the same way that our offline blocking page would.
shawnborton commentedon Jun 29, 2022
Sounds good!
I think the question mark circle icon already exists in the App repo, so you should be good to just reuse it and style it like the offline page. Feel free to tag design in your PR too!
melvin-bot commentedon Jun 30, 2022
Triggered auto assignment to @jamesdeanexpensify (
Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.7 remaining items
shawnborton commentedon Jun 30, 2022
Oh crap, my bad! Here is an updated screenie:
jamesdeanexpensify commentedon Jun 30, 2022
Maybe "That page..." instead of "The page"...what do you think?
shawnborton commentedon Jun 30, 2022
Here ya go:
jamesdeanexpensify commentedon Jun 30, 2022
Discussing the last bits here: https://expensify.slack.com/archives/C03SSAQG5/p1656631441234379?thread_ts=1656618417.749959&cid=C03SSAQG5
jamesdeanexpensify commentedon Jul 1, 2022
Will have this finalized tomorrow. It's a really small tweak, but I want to make sure I'm following the process that I'm creating!
jamesdeanexpensify commentedon Jul 1, 2022
I think for now since it's more of a header/title, we can leave "Hmm...it's not here" without a period. Let's ship it!
jamesdeanexpensify commentedon Jul 1, 2022
And by ship it, I mean this: #9522 (comment)
melvin-bot commentedon Jul 4, 2022
@arosiclair Whoops! This issue is 2 days overdue. Let's get this updated quick!
arosiclair commentedon Jul 5, 2022
Thanks guys! Getting a Spanish translation for this and then this should be through very soon.