Skip to content

[Due for payment 2026-08-05] [Split #94595] Batch C - Remove useOnyx deps from Search #95576

Closed

Description

@mountiny

Sub-issue of #94595.
Source plan: fabioh8010 comment.

Goal

Remove the deprecated 3rd dependencies argument from Search components.

Scope (9 files)

  • Search/FilterComponents/CategorySelector
  • Search/SearchList/ListItem/ExpenseReportListItem
  • Search/SearchList/ListItem/GroupHeader
  • Search/SearchList/ListItem/ReportListItemHeader
  • Search/SearchList/ListItem/TaskListItem
  • Search/SearchList/ListItem/TransactionGroupListItem
  • Search/SearchList/ListItem/TransactionListItem/index
  • Search/SearchPageHeader/SearchActionsBarCreateButton
  • pages/Search/SearchHoldReasonPage

Change types

INLINE-heavy; list-row rendering.

Dependencies

Blocked by PR 1 (ESLint guard) merged.

Tests / QA

Open Search; switch types (Expenses/Reports/Chats/Tasks); verify row content (submitter names, avatars, violation dots, group headers); category filter; bulk-select + hold-reason page.

Acceptance criteria

  1. npm run fmt on changed files
  2. npm run lint-changed — seatbelt count for rulesdir/no-useonyx-dependencies-arg must drop (never increase)
  3. npm run typecheck stays green
  4. npm run react-compiler-compliance-check check <files> — USECALLBACK/bailout files must not gain new failures vs main
  5. Relevant npm run test for touched areas
  6. Manual smoke test per batch QA steps — no stale data, infinite re-renders, or JS console errors
Issue OwnerCurrent Issue Owner: @hoangzinh

Activity

  1. melvin-bot commented on Jul 13, 2026

    @melvin-bot

    @hoangzinh Huh... This is 4 days overdue. Who can take care of this?

  2. hoangzinh commented on Jul 14, 2026

    @hoangzinh
    Contributor

    Updates: @fabioh8010 is working through PRs

  3. melvin-bot commented on Jul 17, 2026

    @melvin-bot

    @hoangzinh Whoops! This issue is 2 days overdue. Let's get this updated quick!

  4. fabioh8010 commented on Jul 20, 2026

    @fabioh8010
    Contributor

    #95618 is ready to review.

  5. melvin-bot commented on Jul 27, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  6. changed the title [-][Split #94595] Batch C - Remove useOnyx deps from Search[/-] [+][Due for payment 2026-08-05] [Split #94595] Batch C - Remove useOnyx deps from Search[/+] on Jul 29, 2026
  7. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    @hoangzinh

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.45-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-05. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions