You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-07] [$250] Chat view - Clicking nothing for now shows an error when screen size is small #95719
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
⚠️Preliminary analysis (low confidence) — I could not capture the exact error or reproduce the crash, so treat this as a starting point, not a conclusion.
What "Nothing for now" does: It is the only track-expense whisper button whose onPress calls dismissTrackExpenseActionableWhisper (the other three navigate to the participant selector). That function is layout-agnostic — it just optimistically merges resolution: 'nothing' onto the report action and fires the API write (Report/index.ts:6001). Once resolved, the whole whisper action is hidden by shouldReportActionBeVisible.
So the error is almost certainly not in the dismiss call itself, but in the re-render/list re-computation triggered when the whisper disappears — and it only surfaces on a small/narrow layout. I could not find a narrow-layout-gated throw statically, and a correct click on the button did not crash on latest main (see below), so I can't confirm the mechanism.
To move this forward, the single most useful thing is the exact red-box/console error + stack frame from the repro video (e.g. Cannot read properties of undefined (reading …) and the component name). That will immediately point to the throwing component. This is a client-side JS error, so it won't be in server logs.
Investigation details
Confirmed:dismissTrackExpenseActionableWhisper has no responsive-layout dependency; after it resolves the whisper, the action is removed from the list. The only narrow-layout branch in the direct render path is isEditingInline in ChatMessageContent, which does not touch track-expense whispers.
Could not reproduce on main (HEAD 5fadbf3): In a narrow (~800px) browser, submitting a self-DM expense and clicking "Nothing for now" fired DismissActionableWhisper (HTTP 200) and dismissed the whisper with no visible error. (The test tooling did misfire one click onto the emoji picker, but that is an accessibility-ref artifact, not the reported bug.) This build is newer than the reported staging build 9.4.32-0, so the offending change may already be reverted/fixed, or the crash needs specific state (e.g. the track-flows beta, which enables the extra "Categorize"/"Share" options) not present in the test account.
Best candidates for the throw, if it is a re-render crash gated on narrow layout: a sibling consumer of the same action that recomputes when it disappears — e.g. OptionRowLHNData.tsx:106 (reads getOriginalMessage(lastAction)?.transactionID for the resolved whisper) or the tracked-expense preview/thread-divider recompute in ReportActionsList.
Suggested next steps for the assignee:
Grab the exact console error + stack from the repro video / a fresh repro with DevTools open.
Confirm whether it still reproduces on the latest staging build — I could not reproduce a crash on current main.
If it reproduces, the offending PR is likely one in this deploy that touches the track-expense whisper render path or a component that re-renders when the whisper resolves.
Next Steps: Reply with @MelvinBot <the exact error text from the video> and I'll pinpoint the throwing component, or @MelvinBot <your feedback> to refine this analysis.
Classification: Frontend bug Causing PR: #95045 - "Open linked message at top - 3" by @VickyStash (Medium-High confidence) Related Issues: None
Recommendation: REVERT
This PR reworked the report-actions FlashList mount/scroll positioning to drive off initialScrollIndex + initialScrollIndexParams (tied to windowHeight) and shipped a new FlashList patch, and it is the only newly-deployed PR in this release that touches the exact render path where the crash surfaces (report actions list re-layout after the whisper is dismissed and the window is resized). Reverting is clean since it is a self-contained scroll/render change.
Assigned: @VickyStash (PR author), @aimane-chnaif and @JS00001 (approving reviewers) Labels: No change — DeployBlockerCash kept (frontend bug, App deploy is blocked). No DeployBlocker present, so nothing removed.
📋 Detailed Analysis
Evidence
Repro is layout/re-layout driven. The corrected repro from @m-natarajan is: submit expense → click "Nothing for now" → then reduce the window size → error. So the crash is not in the dismiss call (which is layout-agnostic, as noted in the earlier analysis), but in the report-actions list re-computing its layout after (a) the dismissed whisper shrinks renderedVisibleReportActions and (b) a window resize forces FlashList to recompute.
Open linked message at top - 3 #95045 — reworks src/pages/inbox/report/ReportActionsList.tsx, src/hooks/useReportActionsScroll.ts, the InvertedFlashList wrapper, and adds a new FlashList initialScrollIndex patch. Direct hit.
Timeline fits a fresh staging-only regression.Open linked message at top - 3 #95045 merged 2026-07-09 (the same day this blocker was filed) and is in this staging release but not production — matching "reproducible in staging, not production." The earlier "could not reproduce on main (5fadbf3)" note predates this PR's merge.
Verification
Affected render path: src/pages/inbox/report/ReportActionsList.tsx and src/hooks/useReportActionsScroll.ts (the self-DM chat whisper renders in ReportActionsList, not MoneyRequestReportView).
Confirmed Open linked message at top - 3 #95045 modifies exactly these files (gh pr view 95045 --json files): ReportActionsList.tsx, useReportActionsScroll.ts, InvertedFlashList/index.tsx, useReportUnreadMessageScrollTracking.ts, plus the new @shopify/flash-listimprove-scroll-key-handling patch.
Confirmed the change is present at current App HEAD (6e2df6b), i.e. still shipping — not yet reverted:
useReportActionsScroll.ts:160 now calls const {windowHeight} = useWindowDimensions();
Prior to #95045, the list positioned itself with an initialScrollKey and a data-slice handoff (useFlashListScrollKey, now deleted). #95045 replaced that with an explicit initialScrollIndex (= renderedVisibleReportActions.length - 1) plus initialScrollIndexParams.viewOffset = windowHeight, and a new FlashList patch whose applyInitialScrollAdjustment now does recomputeLayouts(0, this.getDataLength() - 1) and reads getLayout(initialScrollIndex).y/.height, plus a bottom-crop loop that calls getLayout(i) across indices.
When the whisper is dismissed the visible-actions array shrinks, and a subsequent window resize re-triggers FlashList's initial-index layout path against the new (shorter) data / new windowHeight-derived offset. If the computed index/offset no longer lines up with a measured layout (index past the shortened data, or an unmeasured layout during the resize recompute), the patch's getLayout(...) returns undefined and the .y/.height/.width read throws — a client-side JS error that only appears once a layout change (resize) forces the recompute, which is why it is width/resize-gated and does not reproduce on a stable full-width layout.
Because this is a client-side render crash introduced by an App PR, the fix belongs in Expensify/App (revert #95045), and the App deploy should remain blocked.
Activity
applause-bot commentedon Jul 9, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/806e6dea0f9fff4cd0d878956f3be4ded356367a5624ce63cb258c4587fc5482
melvin-bot commentedon Jul 9, 2026
Triggered auto assignment to @NicolasBonet (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 9, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 9, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 9, 2026
What "Nothing for now" does: It is the only track-expense whisper button whose
onPresscallsdismissTrackExpenseActionableWhisper(the other three navigate to the participant selector). That function is layout-agnostic — it just optimistically mergesresolution: 'nothing'onto the report action and fires the API write (Report/index.ts:6001). Once resolved, the whole whisper action is hidden byshouldReportActionBeVisible.So the error is almost certainly not in the dismiss call itself, but in the re-render/list re-computation triggered when the whisper disappears — and it only surfaces on a small/narrow layout. I could not find a narrow-layout-gated throw statically, and a correct click on the button did not crash on latest
main(see below), so I can't confirm the mechanism.To move this forward, the single most useful thing is the exact red-box/console error + stack frame from the repro video (e.g.
Cannot read properties of undefined (reading …)and the component name). That will immediately point to the throwing component. This is a client-side JS error, so it won't be in server logs.Investigation details
dismissTrackExpenseActionableWhisperhas no responsive-layout dependency; after it resolves the whisper, the action is removed from the list. The only narrow-layout branch in the direct render path isisEditingInlineinChatMessageContent, which does not touch track-expense whispers.main(HEAD5fadbf3): In a narrow (~800px) browser, submitting a self-DM expense and clicking "Nothing for now" firedDismissActionableWhisper(HTTP 200) and dismissed the whisper with no visible error. (The test tooling did misfire one click onto the emoji picker, but that is an accessibility-ref artifact, not the reported bug.) This build is newer than the reported staging build9.4.32-0, so the offending change may already be reverted/fixed, or the crash needs specific state (e.g. the track-flows beta, which enables the extra "Categorize"/"Share" options) not present in the test account.OptionRowLHNData.tsx:106(readsgetOriginalMessage(lastAction)?.transactionIDfor the resolved whisper) or the tracked-expense preview/thread-divider recompute inReportActionsList.Suggested next steps for the assignee:
main.Next Steps: Reply with
@MelvinBot <the exact error text from the video>and I'll pinpoint the throwing component, or@MelvinBot <your feedback>to refine this analysis.NicolasBonet commentedon Jul 9, 2026
I tried to reproduce this and got nothing:
CleanShot.2026-07-09.at.09.52.00.mp4
Please try to reproduce it again. Asking for a re-test.
m-natarajan commentedon Jul 9, 2026
Able to reproduce in latest staging.
Reproduction steps:
Recording.5986.mp4
NicolasBonet commentedon Jul 9, 2026
@MelvinBot please assign someone else, I have two other blockers, I cannot take care of this one which is unrelated with my changes.
MelvinBot commentedon Jul 9, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #95045 - "Open linked message at top - 3" by @VickyStash (Medium-High confidence)
Related Issues: None
Recommendation: REVERT
This PR reworked the report-actions FlashList mount/scroll positioning to drive off
initialScrollIndex+initialScrollIndexParams(tied towindowHeight) and shipped a new FlashList patch, and it is the only newly-deployed PR in this release that touches the exact render path where the crash surfaces (report actions list re-layout after the whisper is dismissed and the window is resized). Reverting is clean since it is a self-contained scroll/render change.Assigned: @VickyStash (PR author), @aimane-chnaif and @JS00001 (approving reviewers)
Labels: No change —
DeployBlockerCashkept (frontend bug, App deploy is blocked). NoDeployBlockerpresent, so nothing removed.📋 Detailed Analysis
Evidence
renderedVisibleReportActionsand (b) a window resize forces FlashList to recompute.src/pages/inbox/report/ReportActionsList.tsx,src/hooks/useReportActionsScroll.ts, the InvertedFlashList wrapper, and adds a new FlashListinitialScrollIndexpatch. Direct hit.MoneyRequestReportView/MoneyRequestReportNavigation.tsx(the money-request report view nav, not the DM chat where the whisper renders). Not the repro path.WhisperBanner.tsx/FloatingMessageCounter.tsxbut is a cosmetic icon-prop rename (expensifyIcons.Eye) from an icon-sizing lint fix. Ruled out.Verification
src/pages/inbox/report/ReportActionsList.tsxandsrc/hooks/useReportActionsScroll.ts(the self-DM chat whisper renders inReportActionsList, notMoneyRequestReportView).gh pr view 95045 --json files):ReportActionsList.tsx,useReportActionsScroll.ts,InvertedFlashList/index.tsx,useReportUnreadMessageScrollTracking.ts, plus the new@shopify/flash-listimprove-scroll-key-handlingpatch.6e2df6b), i.e. still shipping — not yet reverted:useReportActionsScroll.ts:160now callsconst {windowHeight} = useWindowDimensions();useReportActionsScroll.ts:418-419computesinitialScrollIndex = renderedVisibleReportActions.length - 1; initialScrollIndexParams = {viewOffset: windowHeight};Root Cause
Prior to #95045, the list positioned itself with an
initialScrollKeyand a data-slice handoff (useFlashListScrollKey, now deleted). #95045 replaced that with an explicitinitialScrollIndex(=renderedVisibleReportActions.length - 1) plusinitialScrollIndexParams.viewOffset = windowHeight, and a new FlashList patch whoseapplyInitialScrollAdjustmentnow doesrecomputeLayouts(0, this.getDataLength() - 1)and readsgetLayout(initialScrollIndex).y/.height, plus a bottom-crop loop that callsgetLayout(i)across indices.When the whisper is dismissed the visible-actions array shrinks, and a subsequent window resize re-triggers FlashList's initial-index layout path against the new (shorter) data / new
windowHeight-derived offset. If the computed index/offset no longer lines up with a measured layout (index past the shortened data, or an unmeasured layout during the resize recompute), the patch'sgetLayout(...)returns undefined and the.y/.height/.widthread throws — a client-side JS error that only appears once a layout change (resize) forces the recompute, which is why it is width/resize-gated and does not reproduce on a stable full-width layout.Because this is a client-side render crash introduced by an App PR, the fix belongs in
Expensify/App(revert #95045), and the App deploy should remain blocked.53 remaining items
melvin-bot commentedon Aug 6, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 6, 2026
Payment Summary
Resolving PRs:
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Aug 10, 2026
Payment Summary
Contributor: @apeyada paid $250 via Upwork
Contributor+: @aimane-chnaif due $250 via NewDot
^ Test case created. Thx
garrettmknight commentedon Sep 14, 2026
$250 approved for @aimane-chnaif
melvin-bot commentedon Oct 12, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.