Repository navigation
[HOLD for payment 2022-12-08] [$250][Form Refactor] CompanyStep #9580
Description
Coming from the New Expensify Forms design doc, we should refactor CompanyStep to use the new form component, follow the guidelines below:
Here's an example of a Form refactor: #9056
Guidelines
- Replace the form component with Form.js.
- Create a unique Onyx key in ONYXKEYS.FORM and pass it as the formID prop to Form.
- Pass a validate callback prop.
- Pass an onSubmit callback prop that calls the API via an action.
- Update all inputs wrapped by Form, following the guidelines in Refactor inputs.
- Remove any unused code.
Testing
Verify that:
- UI looks as it did before the refactor
- Values can be added and edited
- Errors are highlighted correctly (input border)
- Error messages show up correctly
- Draft values are saved properly
- Form alerts are displayed correctly
- Clicking the
fix the errorslink focuses the first input with error - No duplicate submission of the form occurs (when it's already submitting)
Activity
melvin-bot commentedon Jun 27, 2022
Triggered auto assignment to @adelekennedy (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.adelekennedy commentedon Jun 28, 2022
@luacmartins is this something contributors can work on? Double checking before I open an Upwork job
luacmartins commentedon Jun 28, 2022
Yes! The Form refactor project is all open to contributors :)
luacmartins commentedon Jun 29, 2022
This issue is being put on hold due to push to page discussions, as per this comment.
[-][Form Refactor] CompanyStep[/-][+][HOLD] [Form Refactor] CompanyStep[/+]adelekennedy commentedon Jun 29, 2022
Ty ty!
adelekennedy commentedon Jul 4, 2022
on hold
123 remaining items
adelekennedy commentedon Dec 8, 2022
pending payment on the discussion above
mananjadhav commentedon Dec 9, 2022
I think 500$ should be fine here. Please note this also had a regression involved. So incase we don't want to increase then that is fine too.
ravindra-encoresky commentedon Dec 9, 2022
I would go with the first option :) , it's been long back and forth. Thanks, looking forward.
luacmartins commentedon Dec 9, 2022
$500 seems fair to me. Let's go with that.
mananjadhav commentedon Dec 9, 2022
Thanks @luacmartins. @adelekennedy can you help with the payout here?
adelekennedy commentedon Dec 13, 2022
@mananjadhav just hired you at $500
mananjadhav commentedon Dec 13, 2022
Accepted @adelekennedy
adelekennedy commentedon Dec 13, 2022
paid and paid!
ravindra-encoresky commentedon Dec 13, 2022
@adelekennedy @mananjadhav I've received only $250.
JmillsExpensify commentedon Dec 23, 2022
Re-opening until the contributor's question is answered.
mallenexpensify commentedon Dec 26, 2022
Sorry about that @ravindra-encoresky , not sure what happened. I just bonused you $250 so total compensation is now $500. Double checked Manan's contract and the payment was $500 there, re-closing
ravindra-encoresky commentedon Dec 27, 2022
Got it, thank you.