Skip to content

Investigate workflow job failing on main: test / test (job 6) #96038

Closed

Description

@github-actions

🚨 Failure Summary 🚨:

  • 📋 Job Name: test / test (job 6)
  • 🔧 Failure in Workflow: Process new code merged to main
  • 🔗 Triggered by PR: PR Link
  • 👤 PR Author: @abzokhattab
  • 🤝 Merged by: @iwiznia
  • 🐛 Error Message:
    warning: [git-mirror] Skipping cache commit: Found 2 failed/cancelled steps
    warning: [git-mirror] - Step: unknown (failed)
    failure: Process completed with exit code 1.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named test / test (job 6).
🔍 This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

For detailed instructions, check this SO.

🐛 We appreciate your help in squashing this bug!

Activity

  1. iwiznia commented on Jul 14, 2026

    @iwiznia
    Contributor

    @grgia handled this here #96037

  2. mkhutornyi commented on Jul 14, 2026

    @mkhutornyi
    Contributor

    @MelvinBot implement this

  3. MelvinBot commented on Jul 14, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: #96067 — please mark it "Ready for review" when it's ready.

    Heads up: this failure is not the one grgia already fixed in #96037. That PR fixed the ExportOnyxStateTest.ts failure, which was in job 5. This issue is about job 6, which failed on a different test: tests/ui/components/SubmitPlanWelcomeModalTest.tsx (3 tests), and was still red on main.

    Root cause: a logical merge conflict. The render chain is SubmitPlanWelcomeModal → FeatureTrainingContent → FormAlertWithSubmitButton → usePressLoading. usePressLoading now calls useFocusEffect, which requires a navigation context. PR #95099 (which added the modal + test) was written/tested against a main where usePressLoading did not yet use useFocusEffect, so its test rendered the modal without a NavigationContainer. Once both changes landed on main together, the test threw at render time:

    Couldn't find a navigation object. Is your component inside NavigationContainer?
    

    Fix: render the modal inside a NavigationContainer + stack screen in the test, mirroring the existing pattern in FeatureTrainingModalTest.tsx. Test-only change — no runtime behavior change, since in the app the modal is always mounted inside navigation.

    Note on local verification

    Local test execution wasn't available in my environment, so I couldn't run jest locally before opening the PR. The CI test / test check on the PR will validate the fix. The change is a targeted, test-only wrapper following an established, passing pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions