You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Investigate workflow job failing on main: test / test (job 6) #96038
🐛 Error Message:
warning: [git-mirror] Skipping cache commit: Found 2 failed/cancelled steps
warning: [git-mirror] - Step: unknown (failed)
failure: Process completed with exit code 1.
⚠️Action Required⚠️:
🛠️ A recent merge appears to have caused a failure in the job named test / test (job 6).
🔍 This issue has been automatically created and labeled with Workflow Failure for investigation.
🤖 Draft PR created: #96067 — please mark it "Ready for review" when it's ready.
Heads up: this failure is not the one grgia already fixed in #96037. That PR fixed the ExportOnyxStateTest.ts failure, which was in job 5. This issue is about job 6, which failed on a different test: tests/ui/components/SubmitPlanWelcomeModalTest.tsx (3 tests), and was still red on main.
Root cause: a logical merge conflict. The render chain is SubmitPlanWelcomeModal → FeatureTrainingContent → FormAlertWithSubmitButton → usePressLoading. usePressLoading now calls useFocusEffect, which requires a navigation context. PR #95099 (which added the modal + test) was written/tested against a main where usePressLoading did not yet use useFocusEffect, so its test rendered the modal without a NavigationContainer. Once both changes landed on main together, the test threw at render time:
Couldn't find a navigation object. Is your component inside NavigationContainer?
Fix: render the modal inside a NavigationContainer + stack screen in the test, mirroring the existing pattern in FeatureTrainingModalTest.tsx. Test-only change — no runtime behavior change, since in the app the modal is always mounted inside navigation.
Note on local verification
Local test execution wasn't available in my environment, so I couldn't run jest locally before opening the PR. The CI test / test check on the PR will validate the fix. The change is a targeted, test-only wrapper following an established, passing pattern.
Activity
iwiznia commentedon Jul 14, 2026
@grgia handled this here #96037
mkhutornyi commentedon Jul 14, 2026
@MelvinBot implement this
MelvinBot commentedon Jul 14, 2026
🤖 Draft PR created: #96067 — please mark it "Ready for review" when it's ready.
Heads up: this failure is not the one
grgiaalready fixed in #96037. That PR fixed theExportOnyxStateTest.tsfailure, which was in job 5. This issue is about job 6, which failed on a different test:tests/ui/components/SubmitPlanWelcomeModalTest.tsx(3 tests), and was still red onmain.Root cause: a logical merge conflict. The render chain is
SubmitPlanWelcomeModal→FeatureTrainingContent→FormAlertWithSubmitButton→usePressLoading.usePressLoadingnow callsuseFocusEffect, which requires a navigation context. PR #95099 (which added the modal + test) was written/tested against amainwhereusePressLoadingdid not yet useuseFocusEffect, so its test rendered the modal without aNavigationContainer. Once both changes landed onmaintogether, the test threw at render time:Fix: render the modal inside a
NavigationContainer+ stack screen in the test, mirroring the existing pattern inFeatureTrainingModalTest.tsx. Test-only change — no runtime behavior change, since in the app the modal is always mounted inside navigation.Note on local verification
Local test execution wasn't available in my environment, so I couldn't run
jestlocally before opening the PR. The CItest / testcheck on the PR will validate the fix. The change is a targeted, test-only wrapper following an established, passing pattern.