You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Button spinner is not displayed for "Amount" field. #96058
Version Number: 9.4.32-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92498 Email or phone of affected tester (no customers):ibellicotest+2766@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Motorola MotoG60 / Android 12 (Hybrid app) App Component: Money Requests
Action Performed:
Open the Expensify app.
Start a manual expense creation flow.
Enter any amount and tap on "Next"
Note that no spinner is visible on "Next" button while moving to the following step.
On confirm page, reopen amount field, edit it and tap "Save"
Note that no spinner is displayed on "Save" button.
Open a different field such as "Merchant" or "Description"
Edit the field and tap "Save"
Note that a spinner is visible while field is saved.
Expected Result:
During expense creation flow, a spinner should be visible after editing a field and tapping "Save" or "Next"
Actual Result:
During expense creation flow, no spinner can be seen on "Save" or "Next" button after saving amount.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The Amount step's Next/Save button is a plain Button rendered by MoneyRequestAmountForm, which bypasses the entire Form stack. PR Expensify/App#92498 added the "instant spinner on press" behavior only to the Form stack (FormProvider → FormWrapper → FormAlertWithSubmitButton, driven by the usePressLoading hook). Because the Amount step never touches that stack, its button was never wired up — so no spinner appears.
By contrast, the Merchant and Description steps render their Save button through FormProvider, which calls usePressLoading and drives the spinner — which is why they behave correctly.
The Button component only shows a spinner when a parent explicitly passes isLoading={true} (Button/index.tsx); MoneyRequestAmountForm never does, and Button has no shouldShowLoadingImmediatelyOnPress prop of its own.
Recommended Fix
Mirror what FormProvider does — wire usePressLoading into MoneyRequestAmountForm's Button:
Add isLoading={isLoading} to the <Button>, and change onPress to run the submit through startWithLoading(...).
Validate first, then start the spinner.submitAndNavigateToNextPage can bail out early via setFormError (lines 199 & 204) without navigating. Since usePressLoading only auto-resets on focus loss, a failed-validation press won't navigate and could leave the spinner stuck — so only call startWithLoading on the valid path.
Amount: press → plain <Button>onPress → submitAndNavigateToNextPage() runs synchronously → no isLoading ever set → no spinner.
Note / correction to the PR description: the Form stack explicitly passes shouldShowLoadingImmediatelyOnPress={false} in FormWrapper.tsx:196-204 and relies on FormProvider's own usePressLoading, not the default true on FormAlertWithSubmitButton. So the correct fix mirrors FormProvider, not a prop flip.
Out of scope: the PAY + skipConfirmation branch uses SettlementButton (its own KYC/async flow), not the standard Next/Save button this bug is about.
Confidence: High — code path fully traced end-to-end; explains why Merchant/Description work but Amount doesn't.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/96058) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
I've been consulting on and refining the proposal, weighing different ways we could introduce the immediate spinner globally. Heads up I'm OOO next week (back Aug 3). Once I'm back I'll share a proposal.
@rlinoz@OlGierd03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Quick update: I have the approach and the proposal ready, but for completeness I've also been putting together a POC PR of the changes so the proposal comes with something concrete to look at.
Heads up that I'm OOO again, this time until Aug 17. In the meantime @mikolajpochec will help me polish the proposed changes. I'll share the full proposal once I'm back and the POC is refined.
Activity
applause-bot commentedon Jul 14, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/c17c6b87118747c434869e1c4933dcb589aa6967bee3594f9572b1725136590f
melvin-bot commentedon Jul 14, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92498
melvin-bot commentedon Jul 14, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 14, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 14, 2026
Proposal
Root Cause
The Amount step's
Next/Savebutton is a plainButtonrendered byMoneyRequestAmountForm, which bypasses the entireFormstack. PR Expensify/App#92498 added the "instant spinner on press" behavior only to theFormstack (FormProvider→FormWrapper→FormAlertWithSubmitButton, driven by theusePressLoadinghook). Because the Amount step never touches that stack, its button was never wired up — so no spinner appears.By contrast, the Merchant and Description steps render their
Savebutton throughFormProvider, which callsusePressLoadingand drives the spinner — which is why they behave correctly.The
Buttoncomponent only shows a spinner when a parent explicitly passesisLoading={true}(Button/index.tsx);MoneyRequestAmountFormnever does, andButtonhas noshouldShowLoadingImmediatelyOnPressprop of its own.Recommended Fix
Mirror what
FormProviderdoes — wireusePressLoadingintoMoneyRequestAmountForm'sButton:const {isLoading, startWithLoading} = usePressLoading();inMoneyRequestAmountForm.isLoading={isLoading}to the<Button>, and changeonPressto run the submit throughstartWithLoading(...).submitAndNavigateToNextPagecan bail out early viasetFormError(lines 199 & 204) without navigating. SinceusePressLoadingonly auto-resets on focus loss, a failed-validation press won't navigate and could leave the spinner stuck — so only callstartWithLoadingon the valid path.Investigation details & evidence
Data flow contrast:
FormProvider.submit→startWithLoadingsetsisPressed=true→ spinner paints →onSubmitdeferred one macrotask → spinner shows viaisLoading.<Button>onPress→submitAndNavigateToNextPage()runs synchronously → noisLoadingever set → no spinner.Note / correction to the PR description: the Form stack explicitly passes
shouldShowLoadingImmediatelyOnPress={false}inFormWrapper.tsx:196-204and relies onFormProvider's ownusePressLoading, not the defaulttrueonFormAlertWithSubmitButton. So the correct fix mirrorsFormProvider, not a prop flip.IOURequestStepAmount.tsx:276-289usePressLoadingprimitive:usePressLoading.ts:27-58Out of scope: the
PAY + skipConfirmationbranch usesSettlementButton(its own KYC/async flow), not the standardNext/Savebutton this bug is about.Confidence: High — code path fully traced end-to-end; explains why Merchant/Description work but Amount doesn't.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96058)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
rlinoz commentedon Jul 14, 2026
No need to block on this, but lets get this fixed.
12 remaining items
melvin-bot commentedon Jul 24, 2026
@OlGierd03 Whoops! This issue is 2 days overdue. Let's get this updated quick!
OlGierd03 commentedon Jul 25, 2026
I've been consulting on and refining the proposal, weighing different ways we could introduce the immediate spinner globally. Heads up I'm OOO next week (back Aug 3). Once I'm back I'll share a proposal.
rlinoz commentedon Jul 27, 2026
Moving to weekly based on that.
melvin-bot commentedon Jul 28, 2026
@rlinoz @OlGierd03 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
OlGierd03 commentedon Aug 6, 2026
Quick update: I have the approach and the proposal ready, but for completeness I've also been putting together a POC PR of the changes so the proposal comes with something concrete to look at.
Heads up that I'm OOO again, this time until Aug 17. In the meantime @mikolajpochec will help me polish the proposed changes. I'll share the full proposal once I'm back and the POC is refined.
OlGierd03 commentedon Aug 25, 2026
I published proposal on the expert-contributors channel (link)
OlGierd03 commentedon Sep 1, 2026
@rlinoz I think we can close this issue as we already have a new, general issue open for instant spinner