Skip to content

[Due for payment 2026-10-27] [$1000] Enable the Go Back button by default (flip shouldUseGoBackButton) #96098

Closed

Description

@Julesssss

Problem

Once the site refactors are complete, flip shouldUseGoBackButton on FullScreenLoadingIndicator to default-true so every fullscreen loader shows a "Go Back" button after a timeout. This is the step that actually delivers the recoverable error page — it fixes all remaining trapped-user loaders in one change instead of ~66 one-line PRs.

Solution

Blocked on #96093, #96094, #96095, #96096 (the bullet-1 refactors must land first, otherwise the flip draws a stray "Go Back" button on top of headers that already have one).

  • Set the shouldUseGoBackButton default to true in src/components/FullscreenLoadingIndicator.tsx.
  • Remove the now-redundant explicit shouldUseGoBackButton props from the sites that already pass it.
  • Retain an explicit shouldUseGoBackButton={false} on the six auth/transition screens where Go Back is dead or harmful on a cold deep-link start (no history to pop):
    • ValidateLoginPage/index.tsx
    • ValidateLoginPage/index.web.tsx
    • UnlinkLoginPage
    • LogInWithShortLivedAuthTokenPage
    • DelegatorConnectGate
    • LogOutPreviousUserPage — actively harmful, not just dead: Go Back can pop /transition back into the outgoing user's session mid-Onyx.clear()/sign-out.
Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit

Activity

  1. self-assigned this
    on Jul 14, 2026
  2. Julesssss commented on Jul 30, 2026

    @Julesssss
    ContributorAuthor

    Blocked by open PRs

  3. Julesssss commented on Aug 7, 2026

    @Julesssss
    ContributorAuthor

    We're wrapping up the last PRs

  4. 67 remaining items

  5. melvin-bot commented on Oct 21, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  6. melvin-bot commented on Oct 26, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  7. mallenexpensify commented on Oct 29, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @situchan due $1000 via NewDot

  8. trjExpensify commented on Nov 3, 2026

    @trjExpensify
    Contributor

    approved $1,000 for @situchan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringImprovementItem broken or needs improvement.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions