Skip to content

[Due for payment 2026-07-30] Android - Submit workspace - Free plan modal shows empty space at the bottom #96121

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.34-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #95099
Email or phone of affected tester (no customers): sidbhisdhidhisdhis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Money Requests

Action Performed:

  1. Launch Expensify app.
  2. Open any chat and send this link - https://staging.new.expensify.com/workspaces/submit-plan-welcome
  3. Tap on the link.

Expected Result:

Free plan modal will not show empty space at the bottom.

Actual Result:

Free plan modal shows empty space at the bottom.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Image

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7208381

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 14, 2026
  2. applause-bot commented on Jul 14, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/6aed5c1e02db2eca1ff53274edb5d241d4aa6f624a41ead608329b4ebe202de9

  3. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #95099

  4. melvin-bot commented on Jul 14, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jul 14, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jul 14, 2026

    @MelvinBot
    Contributor

    Issue Analysis

    ⚠️ Medium confidence — the mechanism below is Android/inset-specific and I could not reproduce it on web (the extra space only appears on devices that have a bottom inset, e.g. the S25 gesture bar). Please confirm on-device before landing a fix.

    Root cause (most likely): The bottom safe-area inset is added twice below the modal content, producing the empty white gap under the buttons on Android.

    1. CenteredModalLayout.tsx:41-44 wraps the children in a view and runs them through useBottomSafeSafeAreaPaddingStyle({addBottomSafeAreaPadding: true}). Even though SubmitPlanWelcomeModal passes contentStyle={[styles.pt0, styles.pb0]}, the hook still adds paddingBottom = safeAreaPaddingBottom on top of the zeroed pb0 (hook logic).
    2. Inside those children, FeatureTrainingContent.tsx:86-102 renders a ScrollView (because shouldUseScrollView is set) whose contentContainerStyle already adds paddingBottom = pb5 + safeAreaPaddingBottom via getScrollableFeatureTrainingModalStyles.

    So the space below the confirm button ends up being pb5 + (2 × safe-area inset). On web there is no bottom inset, so the doubling is invisible — which is why it only shows on Android.

    Note on scope / #95099: SubmitPlanWelcomeModal.tsx:58-79 reuses these shared components exactly like the pre-existing MigratedUserWelcomeModal and AutoSubmitModal (both also contentStyle={[styles.pt0, styles.pb0]} + shouldUseScrollView). The doubling therefore lives in the shared layout, not in logic unique to #95099 — the new modal just surfaced it. Worth spot-checking whether the sibling modals show the same gap on Android.

    Recommended fix: Stop double-counting the bottom inset. Since FeatureTrainingContent's ScrollView already owns the bottom safe-area padding, CenteredModalLayout should not add it again when the caller has explicitly zeroed bottom padding — e.g. skip addBottomSafeAreaPadding (or don't apply styles.pb5/inset) when contentStyle sets paddingBottom: 0. Keep the change in the shared component so the sibling modals benefit too.

    Fastest unblock for this release: reverting #95099 removes the newly-added modal and clears the blocker, but leaves the latent shared-layout gap in place for the other modals.

    Alternative explanation considered

    SubmitPlanWelcomeModal is the only one of the three using a static image with contentFitImage="contain" + illustrationAspectRatio={variables.submitPlanWelcomeModalIllustrationAspectRatio} (400/242). If that ratio doesn't match the intrinsic ratio of ReceiptWranglerSpaceCowgirl, contain would letterbox the SVG and leave yellow400 empty space — but that space would appear inside the illustration area at the top, not as white space at the bottom of the sheet, so it's a less likely match for the report. Ruled secondary.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/96121) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. MelvinBot commented on Jul 14, 2026

    @MelvinBot
    Contributor

    🚧 Deploy Blocker Investigation

    Causing PR: #95099 — "[Submit] In-product modal for existing 'Get paid back' intent users (Wave 4)" (author abzokhattab), in the current StagingDeployCash release. High confidence — it's the only PR in this release that adds the Submit-plan modal/route, and no other PR in the release touched the shared layout code.

    Recommendation: 🟢 ROLL FORWARD with a targeted fix (not a revert). The bug is cosmetic (an empty whitespace band), and the real defect is a small, well-understood double-padding in shared layout code — reverting the whole Wave-4 feature (component + route + navigator + guard + 11 language files) is disproportionate.

    Root cause: The bottom safe-area inset is applied twice below the modal content, so on Android (gesture bar → non-zero inset) there's a 20 + 2×inset band under the buttons. On web / devices without a bottom inset the inset ≈ 0, so it's invisible — matching the Android-only, N/A-in-prod report.

    Mechanism (validated against code)

    SubmitPlanWelcomeModal renders CenteredModalLayout(contentStyle=[pt0,pb0]) > FeatureTrainingContent(shouldUseScrollView), and both layers add bottom spacing:

    1. Wrapper: CenteredModalLayout.tsx:41-44 feeds the style through useBottomSafeSafeAreaPaddingStyle. The modal's pb0 overrides the layout's own pb5 → 0, then the hook adds safeAreaPaddingBottom → wrapper paddingBottom = inset.
    2. ScrollView: FeatureTrainingContent.tsx:86-102 already sets contentContainerStyle bottom padding via getScrollableFeatureTrainingModalStyles = pb5 + inset = 20 + inset.

    Net = (20 + inset) + inset = 20 + 2×inset.

    Pre-existing/latent: AutoSubmitModal.tsx:76-98 and MigratedUserWelcomeModal.tsx:92-108 use the identical [pt0,pb0] + shouldUseScrollView pattern, so the doubling lives in the shared components — #95099 just added the first Submit-plan modal that surfaces it visibly.

    Suggested fix (two options):

    • Option A — scoped, safest for the blocker: since the ScrollView already applies the bottom safe area, make the wrapper skip its redundant inset for this modal — add an opt-out prop to CenteredModalLayout (e.g. addBottomSafeAreaPadding, defaulting true) and set it false on SubmitPlanWelcomeModal.tsx:58-61. Siblings unaffected.
    • Option B — fix the shared root cause: in CenteredModalLayout.tsx:41-44, don't add safeAreaPaddingBottom when the resolved contentStyle paddingBottom is 0. Fixes all three modals, but needs regression testing on AutoSubmitModal / MigratedUserWelcomeModal.

    Do Option A now to unblock, with a follow-up for Option B. The fix should be confirmed on a real device with a gesture bar — this is inset-dependent and won't reproduce on web.

    Suggested assignees (from PR #95099): author abzokhattab and reviewers hungvu193, tgolen, iwiznia.


    Next Steps: Reply with @MelvinBot implement this to open a draft PR with Option A, or @MelvinBot <feedback> to refine.

  8. jasperhuangg commented on Jul 14, 2026

    @jasperhuangg
    Contributor

    Yeah, this is pretty minor. I think we can just demote this.

  9. 7 remaining items

  10. changed the title [-]Android - Submit workspace - Free plan modal shows empty space at the bottom[/-] [+][Due for payment 2026-07-30] Android - Submit workspace - Free plan modal shows empty space at the bottom[/+] on Jul 23, 2026
  11. melvin-bot commented on Jul 23, 2026

    @melvin-bot

    @abzokhattab

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.43-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-30. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  12. melvin-bot commented on Jul 27, 2026

    @melvin-bot

    @abzokhattab Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  13. abzokhattab commented on Jul 27, 2026

    @abzokhattab
    Contributor

    this issue can be closed @hungvu193

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 27, 2026
  15. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  16. melvin-bot commented on Jul 29, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions