Skip to content

[Due for payment 2026-07-23] Web - Account - App crash when open account tab #96158

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.34-8
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: N/A
Email or phone of affected tester (no customers): leungbratt6@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: User Settings

Action Performed:

  1. Open NewDot app and Sign up with new account
  2. Select Something Else -> Finish onboard
  3. Click on the Account tab

Expected Result:

Account tab opens

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7208651_1784086204933!staging.new.expensify.com-1784086182656.txt

Bug7208651_1784085565088.crash.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7208651

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 15, 2026
  2. applause-bot commented on Jul 15, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/58efd67a1920815b7eb04c5c4c8de5ddecb89e148aaa375820f88d95cddd05b9

  3. melvin-bot commented on Jul 15, 2026

    @melvin-bot

    Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jul 15, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jul 15, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jul 15, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #96115 — "Enforce Babel + OXC React Compiler memoization parity" by @roryabraham (cherry-picked to staging as #96154) (Medium confidence)
    Related Issues: This PR was itself a CP fixing prior deploy blockers #96054, #96086, #96092

    Recommendation: ROLL FORWARD

    This is an App-side regression (staging-only, not reproducible in production) on the Account tab render path, so an App change is responsible. A clean full revert is risky because #96115 was cherry-picked to fix three other deploy blockers (#96054, #96086, #96092) that would return — a targeted fix on the specific divergent file in the crash path is safer than reverting all 78 files.

    Assigned: @roryabraham (PR author, already assigned), @chuckdries and @jasperhuangg (approving reviewers)
    Labels: No change. DeployBlockerCash is kept — this is a Frontend bug (App PR involved) and the App deploy remains blocked. No DeployBlocker label is present.

    📋 Detailed Analysis

    Evidence

    Verification

    • Affected file (crash surface): src/pages/settings/InitialSettingsPage.tsx — the Account tab, wrapped by withCurrentUserPersonalDetails.
    • Confirmed [CP Stg] Enforce Babel + OXC React Compiler memoization parity #96115 modifies files on this exact render path:
      • src/components/withCurrentUserPersonalDetails.tsx (HOC wrapping the screen)
      • src/hooks/useLazyAsset.ts (icons rendered by the screen)
      • src/components/createOnyxContext.tsx, src/libs/genericMemo.ts (shared render infra)

    Root Cause

    Not yet pinned to a single line — a JS stack trace from the crash video/Sentry is needed to confirm. The mechanism is a memoization behavior change from #96115 that alters rendering on a code path only a brand-new "Something Else" account hits on the Account tab (sparse currentUserPersonalDetails / Onyx state). Because this is a compiler-parity PR that deliberately changes web (OXC) vs native (Babel) memoization, a subtle render-time crash on an under-tested new-user flow is consistent with the symptom. @roryabraham — could you check Sentry for release 9.4.34-8 for the stack trace on this crash so we can land a targeted roll-forward fix rather than reverting the whole PR (which would reintroduce #96054, #96086, #96092)?

  7. melvin-bot commented on Jul 15, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. melvin-bot commented on Jul 15, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. 5 remaining items

  10. melvin-bot commented on Jul 15, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. jponikarchuk commented on Jul 15, 2026

    @jponikarchuk

    Deploy Blocker #96207 was identified to be related to the PR #96164 that attempted to fix this issue.

  12. m-natarajan commented on Jul 15, 2026

    @m-natarajan

    issue not reproduce using build v9.4.34-13

    Screen.Recording.2026-07-16.at.5.38.50.AM.mov
  13. changed the title [-]Web - Account - App crash when open account tab[/-] [+][Due for payment 2026-07-23] Web - Account - App crash when open account tab[/+] on Jul 16, 2026
  14. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.34-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-23. 🎊

  16. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    @roryabraham The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  17. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    @roryabraham The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions