Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.4.35-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41237662
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11 / Chrome
App Component: Other
Action Performed:
- Open https://staging.new.expensify.com/
- Sign up for a new account (Without +)
- Choose "Manage my team's expenses"
- Select company size 11-50 employees
- Pick an accounting integration as QBD option
- Navigate to #admins room
Expected Result:
Verify the message contains Calendly link to book a call
Actual Result:
Missing message contains Calendly link to book a call
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7209723_1784197137353.96243_-_Onboarding_-_Manage_my_team_-_Missing_Calendly_link_to_book_a_call.mp4
Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7209723
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~022077727299550970579
- Upwork Job ID: 2077727299550970579
- Last Price Increase: 2026-08-06
Issue Owner
Current Issue Owner: @mollfprMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
applause-bot commentedon Jul 16, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e76c81d84baa9eb470a98db22061a0cc27fb15885f013e296f3e1881aee10ad5
MelvinBot commentedon Jul 16, 2026
Updated 2026-07-16: Correcting my earlier conclusion. My first analysis said this was backend-only with no App-side fix — that was wrong. There is a credible client-side (App) root cause, independently identified in
aswin-s's proposal.Issue Analysis
Root Cause (App): For
MANAGE_TEAM, App intends to defer the entire#adminswelcome to the backend'sinboxAdminsBespokevariant (the one that carries the Calendly "book a call" link). The optimistic Onyx writes for the welcome message are correctly gated on!shouldDeferOptimisticTasksatReportUtils.ts:12140and:12163. But the actual server payload push is not gated —ReportUtils.ts:12278-12280unconditionally pushes the plainonboardingManageTeamMessagecopy ("Your free trial has started… I'm your Expensify account executive", which has no Calendly link —en.ts:3535-3544) intoguidedSetupData, which is sent toCompleteGuidedSetup. So even though App means to let the server own the welcome, it still ships a plain, link-less message to the server, which appears to preempt the bespoke Calendly variant. ThewelcomeSignOffMessagepush atReportUtils.ts:12384has the same gap.Recommended Fix (App): Gate the message push at
ReportUtils.ts:12278with!shouldDeferOptimisticTasks(mirroring the existing guards at 12140 / 12163 / 12357), and apply the same guard to the sign-off push at 12384. ForMANAGE_TEAMthe client should send no message inguidedSetupData, leaving the whole welcome sequence (including the Calendly link) to the backend, posted idempotently viaoptimisticConciergeReportActionID.companySizeanduserReportedIntegration(QBD) are sent independently (Report/index.ts:5586-5587) and are unaffected by this change.Confidence: Medium. The unguarded-push asymmetry and the link-less message copy are verified in code. The remaining unverified step is backend behavior — that a message present in
guidedSetupDataactually suppresses theinboxAdminsBespokeCalendly welcome. Worth confirming with a backend/log check on a reproCompleteGuidedSetuprequest (11–50 + QBD), or by observing which message actually renders in the room.Investigation details & alternatives considered
messageis truthy forMANAGE_TEAM(built fromonboardingManageTeamMessage,OnboardingFlow.ts:334-335), so theif (message)at 12278 is entered.onboardingManageTeamMessagecopy exactly — consistent with the client-supplied message being what lands in the room.account.guideDetails.calendarLinkinto the client message copy. This keeps App generating the welcome rather than deferring to the backend, which conflicts with the existingshouldDeferOptimisticTasksdesign intent (the server owns the bespoke welcome). The guard-the-push fix is smaller and preserves that design.ReportUtils.ts:12237); the bug is not QBD-specific in App code — it applies to the wholeMANAGE_TEAMpath. The regression test happened to use QBD + 11–50.No open duplicate issues found in Expensify/App.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96291)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting this analysis.
aswin-s commentedon Jul 16, 2026
Please re-state the problem that we are trying to solve in this issue.
When a new user signs up on Web (Windows/Chrome), chooses "Manage my team's expenses", selects company size 11-50, and picks QuickBooks Desktop as the accounting integration, the welcome message that lands in the
#adminsroom is the plain "Your free trial has started" copy with no Calendly link. Expected: for MANAGE_TEAM signups the room should show the bespoke assigned-guide welcome that includes a Calendly link to book a call with the account manager.What is the root cause of that problem?
For
engagementChoice === MANAGE_TEAM,prepareOnboardingOnyxDatacorrectly setsshouldDeferOptimisticTasks = trueand generates anoptimisticConciergeReportActionIDso that the backend can idempotently post theinboxAdminsBespokewelcome (the variant that contains the Calendly link). See src/libs/ReportUtils.ts:11779-11780 and src/libs/ReportUtils.ts:11852-11853. However at src/libs/ReportUtils.ts:12278-12280 the client unconditionally pushes{type: 'message', ...textMessage}(built from the client-sideonboardingManageTeamMessagecopy in src/languages/en.ts:3535-3544, which has no Calendly link) intoguidedSetupData, which is then sent toCompleteGuidedSetupat src/libs/actions/Report/index.ts:5584. Because the client instructs the server to post that plain message, the server'sinboxAdminsBespokeCalendly variant is preempted or duplicated by the plain welcome and the admins room ends up without the Calendly link.A second plain message can also enter
guidedSetupDatavia thewelcomeSignOffMessagepush near src/libs/ReportUtils.ts:12384. TheskipSignOffguard only short-circuits forLOOKING_AROUND; forMANAGE_TEAMthe sign-off push is unconditional, so a stale optimistic sign-off action is sent to the server even thoughinboxAdminsBespokeowns the entire welcome sequence.What changes do you think we should make in order to solve the problem?
src/libs/ReportUtils.tsaround line 12277-12280, guard theguidedSetupData.push({type: 'message', ...textMessage})with!shouldDeferOptimisticTasks(mirroring the existingmessage && !shouldDeferOptimisticTasksguards at lines 12140 and 12163), so that for MANAGE_TEAM the client does not send the stale/plain message and lets the backend post theinboxAdminsBespokewelcome (which includes the Calendly link) usingoptimisticConciergeReportActionID.welcomeSignOffMessagepush near line 12384. TheskipSignOffvariable already correctly suppresses this forLOOKING_AROUND, but forMANAGE_TEAMthe sign-off must also be suppressed because the backend-owned bespoke welcome does not expect a client-generated sign-off alongside it. The corrected block should read:This ensures neither the plain onboarding message nor the sign-off message is sent to
CompleteGuidedSetupwhenshouldDeferOptimisticTasksistrue, leaving the entire welcome sequence to the backend.Verify that after this change the client still sends
companySizeanduserReportedIntegrationtoCompleteGuidedSetup(src/libs/actions/Report/index.ts:5586-5587) so the backend can select the correct bespoke variant for 11-50 employees + QBD. Those fields are independent of theguidedSetupDataarray and are not affected by the guards above.Add a regression test around
prepareOnboardingOnyxDataasserting that whenengagementChoice === MANAGE_TEAMthe returnedguidedSetupDatacontains no{type: 'message'}entry for either the plain onboarding message or the sign-off message, and thatoptimisticConciergeReportActionIDis present in the returned data.What alternative solutions did you explore? (Optional)
Move the Calendly link into the client-side
onboardingManageTeamMessagecopy insrc/languages/*.ts— rejected because the bespoke welcome (guide identity, Calendly URL, integration-specific copy) is owned by the backend and must not be hard-coded per locale on the client.nabi-ebrahimi commentedon Jul 16, 2026
Proposal
What is the root cause of that problem?
The QuickBooks Desktop choice is being captured correctly in onboarding: the accounting screen includes
quickbooksDesktopand stores the selected integration before moving to the interested-features step (source, source), and the final onboarding step forwards that value tocompleteOnboardingasuserReportedIntegration(source). The missing piece is that the guided setup/admin-room message payload never receives the guide’s Calendly URL.onboardingManageTeamMessageis built as static copy without any booking link (source),OnboardingTaskLinkshas workspace/accounting/card links but no guide calendar link (source), andprepareOnboardingOnyxDataonly passes those existing links into the message/task builders (source). ForMANAGE_TEAM, App intentionally defers the visible #admins welcome content to the guided-setup/server path (source, source), so the posted message can include the QBD task but has no source value to include the expected Calendly link. The separate header “Schedule call” button works because it readsaccount.guideDetails.calendarLinkdirectly (source, source), but that data is not wired into the onboarding message.What changes do you think we should make in order to solve the problem?
Thread the existing guide booking URL into the guided setup message data used for the
MANAGE_TEAMonboarding flow.Add an optional
guideCalendarLinkfield to the onboarding message/task params, pass it intoprepareOnboardingOnyxData, and then into theonboardingManageTeamMessagebuilder. InBaseOnboardingInterestedFeatures, read the sameaccountGuideDetailsvia the existingaccountGuideDetailsSelector(source) and passaccountGuideDetails?.calendarLinkthroughcompleteOnboardingfor the manage-team completion call. Then update the English manage-team welcome copy to include a booking sentence/link only whenguideCalendarLinkis present, preserving the current message when the guide has no calendar link.Because
completeOnboardingalready sendsguidedSetupData,companySize,userReportedIntegration, andpolicyIDtogether (source), the fix should keep the source of truth in the existing guided-setup payload rather than changing chat rendering or adding a separate follow-up message. We should also cover this with a focused unit test forMANAGE_TEAM + SMALL + quickbooksDesktop + guideCalendarLink, asserting that the generated guided setup message contains the booking link while the QBD task is still included.What alternative solutions did you explore? (Optional)
I considered relying on the existing header “Schedule call” button, but the regression expectation is specifically for the #admins message to contain the Calendly link, and the header button is rendered from a separate UI path. I also considered a backend-only copy change, but App currently has the guide calendar link in Onyx and is already responsible for building the guided setup message payload, so passing that value through App is the smallest source-of-truth fix.
trasnake87 commentedon Jul 16, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
After onboarding via "Manage my team's expenses" (company size 11-50, an accounting integration like QBD selected), the welcome message posted to the #admins room is missing the Calendly "book a call" link that sales‑eligible admins are supposed to receive.
What is the root cause of that problem?
For the
MANAGE_TEAMchoice, the #admins room welcome is a server‑generatedinboxAdminsBespokemessage (it contains the Calendly link for sales‑eligible company sizes). The client is only supposed to send the tasks to the backend and let the backend own the message copy. This is stated explicitly in the code:Every optimistic write of the client‑side message is correctly gated on
!shouldDeferOptimisticTasks(ReportUtils.ts:12140,12163), and the sign‑off message is gated on the guide‑assigned condition (ReportUtils.ts:12355,12357). But the message that is actually sent to the server inguidedSetupDatais NOT gated:messagehere is the genericonboardingManageTeamMessage("👋 Hey there, I'm your Expensify account executive…",en.ts:3535) — it has no Calendly link. Because the client sends this message inguidedSetupData, the backend treats the welcome as client‑provided and skips posting itsinboxAdminsBespokevariant. The result: the plain client message is what lands in #admins, and the Calendly link is dropped. This fires on exactly the reported steps (Manage my team → 11‑50 employees → QBD), which is the sales‑eligible path (getWorkspaceCreatedAnalyticsEvent.ts:9-15,29-30) the bespoke welcome targets. It does not affect Submit/Personal/Chat‑split flows, whereshouldDeferOptimisticTasksisfalseand the client legitimately owns the message.What changes do you think we should make in order to solve the problem?
Gate the
guidedSetupDatamessage push on!shouldDeferOptimisticTasks, matching the optimistic/success/failure pushes and the sign‑off handling directly above it, so the backend owns the #admins welcome forMANAGE_TEAM:Tasks are still pushed to
guidedSetupData(ReportUtils.ts:12353) and the accounting‑integration task filtering is unchanged, so the only behavioral change is that the client stops overriding the bespoke welcome. With no client message present, the backend posts theinboxAdminsBespokevariant containing the Calendly booking link.What alternative solutions did you explore? (Optional)
Adding the Calendly URL to
onboardingManageTeamMessageinen.ts. Rejected: the link is sales‑eligibility‑dependent (company size + private email domain) and is deliberately server‑owned; hardcoding it client‑side would show it to non‑eligible users and duplicate the backend copy the deferral logic was built to defer to.ahmdshrif commentedon Jul 16, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
In the "Manage my team" onboarding flow, the onboarding conversation introduces an Expensify account executive but never surfaces the Calendly link/button to actually book a call with them. The user has no way to schedule the call from the onboarding chat.
What is the root cause of that problem?
The "Book a call / Schedule a call" affordance is the onboarding help dropdown, which is only rendered when
shouldShowGuideBookingis true. That flag is computed inHeaderViewand is gated onisAdminRoom(report):App/src/pages/inbox/HeaderView.tsx
Lines 211 to 219 in 28f705b
The Manage-my-team account-executive message is posted into the onboarding chat (the Concierge/onboarding room used by
isChatUsedForOnboarding), not the workspace #admins room. Because that report fails theisAdminRoom(report)check on line 215,shouldShowGuideBookingisfalsethere, so the OnboardingHelpDropdownButton — and its Calendly "Schedule a call" option (OnboardingHelpDropdownButton.tsx,ONBOARDING_HELP.SCHEDULE_CALL) — is never shown in the flow that explicitly promises a specialist call.What changes do you think we should make in order to solve the problem?
Allow the guide-booking button to appear in the onboarding chat, not only in the admin room. Broaden the room gate on line 215 to also accept the onboarding conversation:
isChatUsedForOnboardingis already derived in this component (currently below this block viaisChatUsedForOnboardingReportUtilsaround line 291), so hoist that computation aboveshouldShowGuideBooking. The remaining guards (guide assigned, non-Concierge, hascalendarLink, company size) are unchanged, so the Calendly link only shows to users who actually have a bookable account executive.Regression: verify the admin room still shows the booking button and that non-manage-team / micro-size flows remain unaffected.
melvin-bot commentedon Jul 16, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)samranahm commentedon Jul 16, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
melvin-bot commentedon Jul 16, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022077727299550970579
35 remaining items
melvin-bot commentedon Aug 14, 2026
@mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mollfpr commentedon Aug 18, 2026
This looks intentional. On the BE, we run a 50/50 A/B test for 11+ employees between
controlandinboxAdminsBespoke. Only theinboxAdminBespokevariant posts the bespoke Concierge welcome with the Calendly link. The QA video shows thecontrolvariant, so the missing link is a side effect of the experiment.Related PR: https://github.com/Expensify/Auth/pull/21785
@marcochavezf could you confirm this is expected, or should the Calendly link also appear on the
controlvariant? If it's expected, can we close this issue?mananjadhav commentedon Aug 18, 2026
Thanks for confirming. Once confirmed we can close it.
marcochavezf commentedon Aug 18, 2026
Ah yes, that's correct, when the user is landed in the #admins room with onboarding tasks, we don't show the Calendly link, so we can close it
mananjadhav commentedon Aug 21, 2026
@mollfpr @marcochavezf Can we close this issue then?
Beamanator commentedon Aug 21, 2026
Before closing, let's see if we need to update a test case or something?
melvin-bot commentedon Aug 21, 2026
@mollfpr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mollfpr commentedon Aug 24, 2026
Created request for updating the QA test: https://github.com/Expensify/Expensify/issues/674431. Closing this 🙌
neerajbachani commentedon Oct 6, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a new user completes onboarding via Manage my team's expenses → 11–50 employees → an accounting integration such as QuickBooks Desktop (QBD), the welcome message posted in the #admins room shows the generic "Your free trial has started… / I'm your Expensify account executive" copy without the expected Calendly link to book a call. This reproduces on web (Windows Chrome, macOS Chrome/Safari) in staging and production; mobile platforms were not verified in the report.
What is the root cause of that problem?
For
MANAGE_TEAM, App deliberately defers the #admins welcome to the server. It setsshouldDeferOptimisticTasks = true, skips every optimistic Onyx write of the welcome/sign-off, and generatesoptimisticConciergeReportActionIDso Auth can post theinboxAdminsBespokewelcome (the variant that carries the Calendly link) idempotently:App/src/libs/ReportUtils.ts
Lines 12330 to 12331 in 380ee96
App/src/libs/ReportUtils.ts
Lines 12330 to 12331 in 380ee96
App/src/libs/ReportUtils.ts
Lines 12405 to 12406 in 380ee96
App/src/libs/ReportUtils.ts
Lines 12405 to 12406 in 380ee96
That deferral is applied on the Onyx side — the welcome optimistic push is correctly gated:
App/src/libs/ReportUtils.ts
Lines 12693 to 12701 in 380ee96
App/src/libs/ReportUtils.ts
Lines 12693 to 12701 in 380ee96
…but it is not applied to the payload actually shipped to
CompleteGuidedSetup. Right above assemblingguidedSetupData, the code states that for a first-run guide-assigned signup (!introSelected?.choice), the backend owns every message and App should only send tasks — yet it unconditionally pushes the client-authored welcome into the wire payload:App/src/libs/ReportUtils.ts
Lines 12829 to 12833 in 380ee96
App/src/libs/ReportUtils.ts
Lines 12829 to 12833 in 380ee96
The repro path is exactly a first signup (
introSelected?.choiceis unset), so this comment describes the bug scenario.messagehere is built fromonboardingManageTeamMessage, which is static copy with no Calendly URL:App/src/languages/en.ts
Lines 3589 to 3598 in 380ee96
App/src/languages/en.ts
Lines 3589 to 3598 in 380ee96
That
{type: 'message'}entry is serialized intoguidedSetupDataand sent to the server:App/src/libs/actions/Report/index.ts
Lines 5858 to 5866 in 380ee96
App/src/libs/actions/Report/index.ts
Lines 5858 to 5866 in 380ee96
The same half-deferral affects the sign-off message: optimistic Onyx pushes are gated on
!shouldDeferOptimisticTasks(line 12910), but the sign-off is still pushed intoguidedSetupDataunconditionally (line 12937):App/src/libs/ReportUtils.ts
Lines 12908 to 12938 in 380ee96
App/src/libs/ReportUtils.ts
Lines 12908 to 12938 in 380ee96
Mechanism: App tells the server to post its own link-less welcome via
guidedSetupDatawhile simultaneously reservingoptimisticConciergeReportActionIDfor the server-owned bespoke welcome. The plain client copy that lands in #admins matchesonboardingManageTeamMessageverbatim, which is consistent with the server honoring the client-supplied message instead of (or in place of) theinboxAdminsBespokeCalendly variant. QBD is not special-cased in App code beyond setting a Control workspace (requiresControlPlanat line 12790); the regression test happened to use QBD +companySize: '11-50'(CONST.ONBOARDING_COMPANY_SIZE.SMALL), the sales-eligible cohort this bespoke path targets.This is a regression in the deferral work introduced around PR #89469 / the
inboxAdminsBespokevariant: optimistic writes were deferred, but the outboundguidedSetupDatamessage pushes were left behind. Submit/Personal/Chat-split flows are unaffected becauseshouldDeferOptimisticTasksisfalsethere.What changes do you think we should make in order to solve the problem?
Apply the same
!shouldDeferOptimisticTasksguard to the server payload that already guards the optimistic/success/failure writes, soMANAGE_TEAMsends tasks only and leaves the entire welcome sequence (including the Calendly link) to the backend viaoptimisticConciergeReportActionID:(
shouldDeferOptimisticTasksis alreadytruefor everyMANAGE_TEAMcall, so the sign-off condition simplifies to folding the existing!shouldDeferOptimisticTasksguard into the outerifinstead of only wrapping the optimistic pushes.)Why this is the best fix covering all repro paths:
prepareOnboardingOnyxData, the single convergence point for every onboarding completion path:useCompleteOnboarding,Policy.createWorkspace, etc.).companySize('11-50') anduserReportedIntegration('quickbooksDesktop') continue to be sent as independent top-level fields and are untouched, so the server still receives everything it needs to pick the correct bespoke variant.guidedSetupData.push(...tasksForParameters)at line 12906) are unchanged.Regression / blast radius: Only
MANAGE_TEAMpayloads change; all other onboarding choices keep sending their client messages. Update the unit test attests/unit/ReportUtilsTest.ts("should include text message in guidedSetupData for MANAGE_TEAM…") to instead assert no{type: 'message'}entries whenengagementChoice === MANAGE_TEAM, while{type: 'task'}entries andoptimisticConciergeReportActionIDremain present. Add a contrasting non-MANAGE_TEAMcase (e.g.PERSONAL_SPEND) asserting its welcome message is still included, to guard against over-filtering.Backend note: C+ review requested confirming the Calendly link is emitted server-side for this cohort (
UserAPI::buildBespokeWelcomeMessage). This App change removes the client override that blocks that path; if the link is still missing after this fix, a complementary Web-Expensify change would be needed — but the half-applied deferral in App is a definite, independently fixable defect regardless.What alternative solutions did you explore? (Optional)
account.guideDetails.calendarLinkintoonboardingManageTeamMessage(nabi-ebrahimi / KJ21-ENG): Rejected — Calendly eligibility depends on company size, integration tier, and guide assignment; that copy is deliberately server-owned (see PR [Payment due @ChavdaSachin] Onboarding: drop cohort gate now that server generates per-tier welcome #89469, which removed client-side bespoke welcome generation). Duplicating it per locale on the client fights the deferral design.isAdminRoom(report).inboxAdminsBespokebut omits Calendly for QBD; however it does not address the documented App/server contract violation at line 12829 where App still ships link-less messages it explicitly says the backend should own.guidedSetupData.filter((item) => item.type !== 'message')at return time whenshouldDeferOptimisticTasks— equivalent outcome, slightly broader; the targeted guards above are simpler and match the existing per-push pattern.en.tsstatically (trasnake87 alternative): Rejected — would show the link to non-eligible cohorts (e.g. micro teams) and reintroduce the client/server drift PR [Payment due @ChavdaSachin] Onboarding: drop cohort gate now that server generates per-tier welcome #89469 removed.What specific scenarios should we cover in automated tests?
engagementChoice === MANAGE_TEAM,prepareOnboardingOnyxDatareturns no{type: 'message'}entries inguidedSetupData(neither welcome nor sign-off), but still returns task entries and a definedoptimisticConciergeReportActionID.engagementChoice === PERSONAL_SPEND(or any non-deferred choice),guidedSetupDatadoes contain the welcome{type: 'message'}entry — guards against over-filtering.completeOnboarding/COMPLETE_GUIDED_SETUPrequest forMANAGE_TEAM + companySize '11-50' + userReportedIntegration 'quickbooksDesktop'still carriescompanySize,userReportedIntegration, andoptimisticConciergeReportActionIDas top-level fields independent ofguidedSetupDatamessages.