Skip to content

[$250] Refactor highlight mechanism #96327

Open

Description

@blimpich

This is agreed upon follow up here. See P/S below:

Problem: The new-expense highlight feature shipped with a fragile implementation: two separate mechanisms writing the same highlight data with conflicting rules, and a set of edge cases producing wrong behavior users can hit bulk-duplicated expenses missing their highlights, split edits falsely flashing existing expenses as "new," highlights replaying on scroll or on quickly reopening a report, stale highlights reappearing days later, and on mobile, highlights playing while the screen is covered so users never see them (in one flow, the new row stayed invisible for ~5 seconds). The core files were also exempted from React Compiler and carried suppressed lint violations, and the animation-timing behavior had zero test coverage.

Solution: Consolidate to a single highlight mechanism with an insertion-proving gate, fix the full defect matrix above, and restructure the two core hooks to React-Compiler-clean patterns so React auto-optimizes them going forward.

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @TaduJR

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 16, 2026
  2. added theissue type on Jul 16, 2026
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jul 16, 2026
  4. melvin-bot commented on Jul 16, 2026

    @melvin-bot

    Current assignee @abzokhattab is eligible for the External assigner, not assigning anyone new.

  5. changed the title [-]Refactor highlight mechanism[/-] [+][$250] Refactor highlight mechanism[/+] on Jul 16, 2026
  6. melvin-bot commented on Jul 16, 2026

    @melvin-bot
  7. yusufdeveloper2903 commented on Jul 16, 2026

    @yusufdeveloper2903
  8. blimpich commented on Jul 16, 2026

    @blimpich
    ContributorAuthor

    Assignee will be @TaduJR

  9. aswin-s commented on Jul 16, 2026

    @aswin-s
  10. TaduJR commented on Jul 16, 2026

    @TaduJR
    Contributor

    👋

  11. Abdulloh0109 commented on Jul 16, 2026

    @Abdulloh0109
  12. ijmalik commented on Jul 16, 2026

    @ijmalik
    Contributor

    🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

  13. 98 remaining items

  14. melvin-bot commented on Nov 7, 2026

    @melvin-bot
  15. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 13, 2026
  16. melvin-bot commented on Nov 13, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  17. changed the title [-][$250] Refactor highlight mechanism[/-] [+][Due for payment 2026-09-17] [$250] Refactor highlight mechanism[/+] on Nov 13, 2026
  18. melvin-bot commented on Nov 13, 2026

    @melvin-bot

    📣 @TaduJR 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  19. mallenexpensify commented on Nov 13, 2026

    @mallenexpensify
    Contributor

    @situchan plz take over as C+. @TaduJR plz help @situchan get caught up. thx

  20. TaduJR commented on Nov 13, 2026

    @TaduJR
    Contributor

    @MelvinBot

    Please remove the payment label from title

  21. changed the title [-][Due for payment 2026-09-17] [$250] Refactor highlight mechanism[/-] [+][$250] Refactor highlight mechanism[/+] on Nov 13, 2026
  22. MelvinBot commented on Nov 13, 2026

    @MelvinBot
    Contributor

    Removed the payment prefix. The title is now: [$250] Refactor highlight mechanism.


    view run

  23. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @TaduJR Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions