You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-09-25] [$250] Public room-anon user first time tapping on sign in button or a thread open public room #96346
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
When an anonymous (logged-out) user cold-launches the app from a public-room deeplink (/r/<id>), the deeplink handler defers a navigation to that room until the room's report data finishes loading from the backend. That deferred navigation fires after the user's first tap and overwrites it — so instead of the Sign In screen or the tapped thread, the public room is (re)opened.
The deferral lives in openReportFromDeepLink in Link.ts: if the report isn't in Onyx yet, it opens an Onyx subscription that waits for the data, then calls Navigation.navigate(route, {forceReplace, waitForTransition: true}). Crucially, forceReplace is true whenever the top route is an RHP — which is exactly the case after the user has just tapped Sign In (opens the Sign-In RHP) — so the deferred navigate replaces the Sign-In slide/thread with the public room. This is why the actual result is "public room slide is opened" on iOS and "public room page is opened" on Android.
The three characteristics of the bug map cleanly onto this code:
Cold launch only → the flow is driven by Linking.getInitialURL() in DeepLinkHandler.tsx, which only runs on a fresh launch.
Why staging but not production (medium confidence): this is a timing race. On staging the report data lands after first paint (slower backend + unminified bundle), so the deferred navigate reliably arrives after the user's tap. On production the data usually resolves before the user can tap, so the navigate fires harmlessly early. This part needs a runtime repro to confirm.
What changes do you think we should make in order to solve the problem?
Make the deferred deeplink navigation abort if the user has already navigated away from the initial cold-launch state before the report data arrives. Concretely, inside the deferred navigateHandler in openReportFromDeepLink, before calling Navigation.navigate(...), check whether the user is still on the original route (or has since opened the Sign-In modal / another report) and skip the navigate (and the forceReplace) if so. Capturing the active route at the time the deeplink is queued and comparing it when the callback fires is enough to detect intervening user interaction. This preserves the intended behavior (navigate to the room once data loads on a clean cold launch) while no longer clobbering an explicit user action.
What alternative solutions did you explore? (Optional)
Ruled-out hypotheses
TransitionTracker gating the tap — ruled out. Default navigate() calls set runImmediately = !options?.waitForTransition → true, so the tap's navigation runs immediately and is not queued.
pendingNavigationCall re-fire (goToPendingRoute) — fires at startup before the user can tap, so it doesn't explain "first tap only."
ReportScreen self-redirect — no effect in ReportScreen/inbox navigates back to the same reportID.
Anonymous linkTo / router guard — linkTo and the router guards have no anon rewrite-to-current-room logic.
Confidence: High on the code mechanism (verified at the file:line refs above); Medium on the staging-vs-production timing explanation, which should be confirmed with a device repro (anon cold-launch into a public room, tap Sign In / a thread inside the data-load window).
Related issues
Two open, in-review issues cover adjacent public-room-deeplink-while-signed-out behavior — worth cross-checking so fixes don't collide:
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/96346) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
@abdulrahuman5196 this issue mentions a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: Not a regression
Link to the comment on the Issue: N/A
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template. Needed for all bugs AND new features
Activity
applause-bot commentedon Jul 16, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/0c0ebf3c965d160db7ddb166087bc1bbcfff1d548eb1d26d769f40814511fa8f
https://platform.applause.com/services/links/v1/external/ec48bd1c836b345f07a6ea8cea40345735d17bcdb54ba90f839dfa25e4214437
melvin-bot commentedon Jul 16, 2026
Triggered auto assignment to @stitesExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 16, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 16, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 16, 2026
Proposal
What is the root cause of that problem?
When an anonymous (logged-out) user cold-launches the app from a public-room deeplink (
/r/<id>), the deeplink handler defers a navigation to that room until the room's report data finishes loading from the backend. That deferred navigation fires after the user's first tap and overwrites it — so instead of the Sign In screen or the tapped thread, the public room is (re)opened.The deferral lives in
openReportFromDeepLinkinLink.ts: if the report isn't in Onyx yet, it opens an Onyx subscription that waits for the data, then callsNavigation.navigate(route, {forceReplace, waitForTransition: true}). Crucially,forceReplaceistruewhenever the top route is an RHP — which is exactly the case after the user has just tapped Sign In (opens the Sign-In RHP) — so the deferred navigate replaces the Sign-In slide/thread with the public room. This is why the actual result is "public room slide is opened" on iOS and "public room page is opened" on Android.The three characteristics of the bug map cleanly onto this code:
if (isAuthenticated) return;(signed-in navigation is handled by react-navigation).Linking.getInitialURL()inDeepLinkHandler.tsx, which only runs on a fresh launch.Why staging but not production (medium confidence): this is a timing race. On staging the report data lands after first paint (slower backend + unminified bundle), so the deferred navigate reliably arrives after the user's tap. On production the data usually resolves before the user can tap, so the navigate fires harmlessly early. This part needs a runtime repro to confirm.
What changes do you think we should make in order to solve the problem?
Make the deferred deeplink navigation abort if the user has already navigated away from the initial cold-launch state before the report data arrives. Concretely, inside the deferred
navigateHandlerinopenReportFromDeepLink, before callingNavigation.navigate(...), check whether the user is still on the original route (or has since opened the Sign-In modal / another report) and skip the navigate (and theforceReplace) if so. Capturing the active route at the time the deeplink is queued and comparing it when the callback fires is enough to detect intervening user interaction. This preserves the intended behavior (navigate to the room once data loads on a clean cold launch) while no longer clobbering an explicit user action.What alternative solutions did you explore? (Optional)
Ruled-out hypotheses
navigate()calls setrunImmediately = !options?.waitForTransition→true, so the tap's navigation runs immediately and is not queued.pendingNavigationCallre-fire (goToPendingRoute) — fires at startup before the user can tap, so it doesn't explain "first tap only."ReportScreen/inbox navigates back to the same reportID.linkToand the router guards have no anon rewrite-to-current-room logic.Confidence: High on the code mechanism (verified at the file:line refs above); Medium on the staging-vs-production timing explanation, which should be confirmed with a device repro (anon cold-launch into a public room, tap Sign In / a thread inside the data-load window).
Related issues
Two open, in-review issues cover adjacent public-room-deeplink-while-signed-out behavior — worth cross-checking so fixes don't collide:
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96346)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
76 remaining items
melvin-bot commentedon Sep 24, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Sep 24, 2026
Payment Summary
Resolving PRs:
Fix: anonymous user first time tapping on sign in button or a thread open public room #99582
Reviewer: @abdulrahuman5196 owed $250 via NewDot
Reviewer: @nkdengineer owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Sep 26, 2026
@abdulrahuman5196 this issue mentions a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.
abdulrahuman5196 commentedon Sep 26, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: Not a regression
Link to the comment on the Issue: N/A
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template. Needed for all bugs AND new features
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
abdulrahuman5196 commentedon Sep 26, 2026
@mallenexpensify Added the checklist.
abdulrahuman5196 commentedon Sep 26, 2026
This issue had one regression and was fixed here - #101528. The payment should be reduced accordingly for this issue.
mallenexpensify commentedon Sep 28, 2026
Payment Summary
Contributor: @nkdengineer due $125 via NewDot
Contributor+: @abdulrahuman5196 due $125 via NewDot
laurenreidexpensify commentedon Oct 6, 2026
Approved $125 @abdulrahuman5196 New Expensify