You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-07-29] Spend - Arrow buttons on expense disappear after opening expense from expense report #96545
Version Number: 9.4.41-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#90403 Email or phone of affected tester (no customers):sdsjodijnsdojsosjio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Go to Spend > Expenses.
Open any expense.
→ Arrow buttons are shown on the expense RHP.
Click on the subtitle link under report title.
Open any expense.
Click report RHP back button twice.
Expected Result:
Arrow buttons will not disappear from expense RHP after opening expense from expense report.
Actual Result:
Arrow buttons on expense disappear after opening expense from expense report.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #90403 - "Standardize Expense Report and Expense header with predictable button placement and carousel counter" by @thelullabyy (High confidence) Related Issues: N/A
Recommendation: REVERT
PR #90403 introduced the entire prev/next expense carousel seeding logic that this bug exercises, and reverting it cleanly removes the regression since the feature is new and does not exist in production. A targeted fix is possible (see Root Cause) if a revert is undesirable, but the safest deploy-unblocking action is a revert.
Assigned: @thelullabyy (PR author), @JS00001 and @ShridharGoel (approving reviewers) from the highest-confidence causing PR only Labels: No label changes. This is a frontend App bug, so DeployBlockerCash is correctly kept (App deploy is blocked). There is no DeployBlocker (Web) label present to remove.
The PR is in the current StagingDeployCash (release 9.4.41-0), merged 2026-07-17, before this bug was reported on 2026-07-21.
The bug is reproducible on staging only and is N/A on production because the carousel counter/standardized header is a new feature shipped by this PR — a strong signal the PR is the cause.
The repro flow steps directly through the three code paths this PR added/rewrote:
Step 5 (open expense from Spend > Expenses): arrows appear because Search/index.tsx#onSelectRow (added by this PR) seeds TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS with all sibling transaction IDs.
Step 6 (click subtitle link → opens the expense report view): the report-view effect in MoneyRequestReportTransactionList.tsx (rewritten by this PR) may overwrite or clear those carousel IDs.
Step 8 (back twice): the report view unmounts and its cleanup calls clearActiveTransactionIDs(), wiping the carousel that the underlying expense RHP still depends on.
src/components/MoneyRequestReportView/MoneyRequestReportTransactionsNavigation.tsx — renders the arrows; the render guard is the gate for the symptom.
src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx — seeds/overwrites/clears the carousel IDs when the report view mounts/unmounts.
src/components/Search/index.tsx — seeds the carousel from the Spend/Expenses flat list.
src/libs/actions/TransactionThreadNavigation.ts — the setActiveTransactionIDs / clearActiveTransactionIDs / getActiveTransactionIDs action layer backing the carousel Onyx key.
The arrows are rendered only when the shared Onyx list has 2+ entries: src/components/MoneyRequestReportView/MoneyRequestReportTransactionsNavigation.tsx L175-177 — permalink
if(transactionIDsList.length<2){return;}
transactionIDsList reads ONYXKEYS.TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS (L55). Once that list is cleared or overwritten with fewer than 2 IDs, the arrows disappear.
Root Cause
The prev/next arrows depend on a single shared Onyx key, TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS, that is seeded, overwritten, and cleared by multiple components introduced/reworked in this PR.
On the Spend > Expenses flat list, Search/index.tsx#onSelectRow seeds the key with every sibling transaction (setActiveTransactionIDs(siblingTransactionIDs, hash)), so the RHP shows arrows — permalink.
Clicking the subtitle link opens the expense report view (SEARCH_REPORT). Its effect in MoneyRequestReportTransactionList.tsx (L493-L527) decides whether to take over the carousel with the report's own visualOrderTransactionIDs, and registers a cleanup that calls clearActiveTransactionIDs() on unmount — permalink.
When the user navigates back twice, the report view unmounts and its cleanup clears TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS. The underlying expense RHP (opened from the Spend page) still relies on that same key, so transactionIDsList.length becomes < 2 and the arrows vanish.
In short, the report-view carousel effect and its unmount cleanup clobber the Spend-page carousel state that the expense RHP beneath it still needs. The PR added guards for the analogous snapshot/descriptor-backed flows (e.g. getActiveTransactionIDs().descriptors at L507, and the membership guard at L515-L521) but the non-descriptor Spend-page → report → expense flow is not protected: the report view's clearActiveTransactionIDs() on unmount (or an overwrite that drops IDs) removes the arrows for the expense still open underneath.
A targeted fix would preserve/restore the Spend-page carousel IDs when the report view (which overlaid it) unmounts — mirroring the existing descriptor-backed guard so the report view does not clobber a carousel that belongs to the transaction thread sitting underneath it. Given the feature is new and staging-only, a straight revert of #90403 is the lowest-risk option to unblock the deploy.
Cause: PR Expensify/App#90403 — "Standardize Expense Report and Expense header with predictable button placement and carousel counter" (in the current 9.4.41StagingDeployCash). Confidence: High.
Recommendation:Revert #90403. This is a new, staging-only feature (N/A in production), so a revert cleanly removes the regression with minimal risk. A targeted fix is possible if a revert is undesirable (see below).
Root cause: The prev/next arrows are driven by a single shared Onyx key (TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS). The report-view effect registers an unmount cleanup that calls clearActiveTransactionIDs(). When you open the expense report via the subtitle link (step 6) and then back out twice (step 8), that report view unmounts and wipes the carousel IDs that the still-open Spend-page expense RHP relies on — the list drops below 2 items, so the render guard hides the arrows.
Investigation details & code references
The three code paths the repro walks through were all introduced/rewritten by #90403:
The PR added a guard at MoneyRequestReportTransactionList.tsx:507 (if (getActiveTransactionIDs().descriptors) return;) that protects the descriptor/snapshot-backed flows, but the plain Spend-page → report → expense flow in this repro is not covered — so its unmount cleanup fires and clears the carousel the Spend page still needs.
Targeted fix (alternative to revert): preserve/restore the Spend-page carousel IDs when the overlaying report view unmounts — extend the existing descriptor guard so the cleanup does not clear IDs that the underlying RHP still depends on.
This is a frontend regression in Expensify/App, so DeployBlockerCash is correctly retained. cc the PR author and reviewers (already assigned) to revert or fix quickly.
The prev/next carousel arrows in the expense RHP are driven by a single shared Onyx key (TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS), managed through the TransactionThreadNavigation action layer introduced by PR #90403.
When you open the expense report via the subtitle link (step 6), the report-view transaction list mounts an effect that overwrites the carousel IDs and registers an unmount cleanup that calls clearActiveTransactionIDs(). Backing out twice (step 8) unmounts that report view, which wipes the carousel IDs the still-open Spend-page expense RHP relies on. The ID list drops below 2, and the render guard hides the arrows.
The PR added a guard for the descriptor/snapshot-backed flows, but the plain Spend > Expenses → report → expense flow in this repro isn't covered, so its cleanup fires unconditionally.
Causing PR (High confidence):#90403 — "Standardize Expense Report and Expense header with predictable button placement and carousel counter", in the current 9.4.41StagingDeployCash. It introduced/rewrote every code path this repro walks through, which is why the bug is staging-only (N/A in production).
What changes do you think we should make in order to solve the problem?
Because this is a deploy blocker on a staging-only feature, the fastest safe resolution is to revert #90403 — it cleanly removes the regression with no production impact.
If a revert is undesirable, the targeted fix is to stop the report view's unmount cleanup from clearing carousel IDs that the underlying Spend-page RHP still depends on — extend the existing descriptor guard so clearActiveTransactionIDs() only fires when this view actually owns the active carousel (e.g. skip the cleanup when the current active IDs were seeded by the Spend page and the report view was layered on top).
What alternative solutions did you explore? (Optional)
Considered scoping the carousel to a per-view key instead of one shared Onyx key, so unmounting one view can't clobber another's navigation state — larger change, better left as a follow-up rather than a deploy-blocker fix.
Possibly related:#93750 — "Forward/Back navigation buttons disappear after submitting a report" (same navigation arrows disappearing, different trigger). Worth checking whether both share the shared-key lifecycle issue.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/96545) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Spend - Arrow buttons on expense disappear after opening expense from expense report[/-][+][Due for payment 2026-07-29] Spend - Arrow buttons on expense disappear after opening expense from expense report[/+]on Jul 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@thelullabyy The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
@thelullabyy The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jul 21, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/83c95071176786efd64524a13707704c61c803f99aa85d0d607d014bf9567a03
melvin-bot commentedon Jul 21, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #90403
melvin-bot commentedon Jul 21, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 21, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 21, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #90403 - "Standardize Expense Report and Expense header with predictable button placement and carousel counter" by @thelullabyy (High confidence)
Related Issues: N/A
Recommendation: REVERT
PR #90403 introduced the entire prev/next expense carousel seeding logic that this bug exercises, and reverting it cleanly removes the regression since the feature is new and does not exist in production. A targeted fix is possible (see Root Cause) if a revert is undesirable, but the safest deploy-unblocking action is a revert.
Assigned: @thelullabyy (PR author), @JS00001 and @ShridharGoel (approving reviewers) from the highest-confidence causing PR only
Labels: No label changes. This is a frontend App bug, so
DeployBlockerCashis correctly kept (App deploy is blocked). There is noDeployBlocker(Web) label present to remove.📋 Detailed Analysis
Evidence
StagingDeployCash(release9.4.41-0), merged 2026-07-17, before this bug was reported on 2026-07-21.Search/index.tsx#onSelectRow(added by this PR) seedsTRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDSwith all sibling transaction IDs.MoneyRequestReportTransactionList.tsx(rewritten by this PR) may overwrite or clear those carousel IDs.clearActiveTransactionIDs(), wiping the carousel that the underlying expense RHP still depends on.Verification
Affected files, all modified by PR #90403:
src/components/MoneyRequestReportView/MoneyRequestReportTransactionsNavigation.tsx— renders the arrows; the render guard is the gate for the symptom.src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx— seeds/overwrites/clears the carousel IDs when the report view mounts/unmounts.src/components/Search/index.tsx— seeds the carousel from the Spend/Expenses flat list.src/libs/actions/TransactionThreadNavigation.ts— thesetActiveTransactionIDs/clearActiveTransactionIDs/getActiveTransactionIDsaction layer backing the carousel Onyx key.The arrows are rendered only when the shared Onyx list has 2+ entries:
src/components/MoneyRequestReportView/MoneyRequestReportTransactionsNavigation.tsxL175-177 — permalinktransactionIDsListreadsONYXKEYS.TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS(L55). Once that list is cleared or overwritten with fewer than 2 IDs, the arrows disappear.Root Cause
The prev/next arrows depend on a single shared Onyx key,
TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS, that is seeded, overwritten, and cleared by multiple components introduced/reworked in this PR.Search/index.tsx#onSelectRowseeds the key with every sibling transaction (setActiveTransactionIDs(siblingTransactionIDs, hash)), so the RHP shows arrows — permalink.SEARCH_REPORT). Its effect inMoneyRequestReportTransactionList.tsx(L493-L527) decides whether to take over the carousel with the report's ownvisualOrderTransactionIDs, and registers a cleanup that callsclearActiveTransactionIDs()on unmount — permalink.TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS. The underlying expense RHP (opened from the Spend page) still relies on that same key, sotransactionIDsList.lengthbecomes< 2and the arrows vanish.In short, the report-view carousel effect and its unmount cleanup clobber the Spend-page carousel state that the expense RHP beneath it still needs. The PR added guards for the analogous snapshot/descriptor-backed flows (e.g.
getActiveTransactionIDs().descriptorsat L507, and the membership guard at L515-L521) but the non-descriptor Spend-page → report → expense flow is not protected: the report view'sclearActiveTransactionIDs()on unmount (or an overwrite that drops IDs) removes the arrows for the expense still open underneath.A targeted fix would preserve/restore the Spend-page carousel IDs when the report view (which overlaid it) unmounts — mirroring the existing descriptor-backed guard so the report view does not clobber a carousel that belongs to the transaction thread sitting underneath it. Given the feature is new and staging-only, a straight revert of #90403 is the lowest-risk option to unblock the deploy.
MelvinBot commentedon Jul 21, 2026
Deploy Blocker Analysis
Cause: PR Expensify/App#90403 — "Standardize Expense Report and Expense header with predictable button placement and carousel counter" (in the current
9.4.41StagingDeployCash). Confidence: High.Recommendation: Revert #90403. This is a new, staging-only feature (N/A in production), so a revert cleanly removes the regression with minimal risk. A targeted fix is possible if a revert is undesirable (see below).
Root cause: The prev/next arrows are driven by a single shared Onyx key (
TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS). The report-view effect registers an unmount cleanup that callsclearActiveTransactionIDs(). When you open the expense report via the subtitle link (step 6) and then back out twice (step 8), that report view unmounts and wipes the carousel IDs that the still-open Spend-page expense RHP relies on — the list drops below 2 items, so the render guard hides the arrows.Investigation details & code references
The three code paths the repro walks through were all introduced/rewritten by #90403:
Carousel seeded from the Spend > Expenses list (step 5, arrows appear):
src/components/Search/index.tsxReport-view effect that overwrites the carousel on mount and clears it on unmount (steps 6–8):
MoneyRequestReportTransactionList.tsx:522-525The render guard that hides the arrows:
MoneyRequestReportTransactionsNavigation.tsx:175(if (transactionIDsList.length < 2) return;)The shared action layer:
src/libs/actions/TransactionThreadNavigation.tsThe PR added a guard at
MoneyRequestReportTransactionList.tsx:507(if (getActiveTransactionIDs().descriptors) return;) that protects the descriptor/snapshot-backed flows, but the plain Spend-page → report → expense flow in this repro is not covered — so its unmount cleanup fires and clears the carousel the Spend page still needs.Targeted fix (alternative to revert): preserve/restore the Spend-page carousel IDs when the overlaying report view unmounts — extend the existing descriptor guard so the cleanup does not clear IDs that the underlying RHP still depends on.
This is a frontend regression in
Expensify/App, soDeployBlockerCashis correctly retained. cc the PR author and reviewers (already assigned) to revert or fix quickly.MelvinBot commentedon Jul 21, 2026
Proposal
What is the root cause of that problem?
The prev/next carousel arrows in the expense RHP are driven by a single shared Onyx key (
TRANSACTION_THREAD_NAVIGATION_TRANSACTION_IDS), managed through theTransactionThreadNavigationaction layer introduced by PR #90403.When you open the expense report via the subtitle link (step 6), the report-view transaction list mounts an effect that overwrites the carousel IDs and registers an unmount cleanup that calls
clearActiveTransactionIDs(). Backing out twice (step 8) unmounts that report view, which wipes the carousel IDs the still-open Spend-page expense RHP relies on. The ID list drops below 2, and the render guard hides the arrows.The PR added a guard for the descriptor/snapshot-backed flows, but the plain Spend > Expenses → report → expense flow in this repro isn't covered, so its cleanup fires unconditionally.
Code evidence (verified against the tip of main)
MoneyRequestReportTransactionList.tsx:522-525MoneyRequestReportTransactionList.tsx:507MoneyRequestReportTransactionsNavigation.tsx:175src/components/Search/index.tsxCausing PR (High confidence): #90403 — "Standardize Expense Report and Expense header with predictable button placement and carousel counter", in the current
9.4.41StagingDeployCash. It introduced/rewrote every code path this repro walks through, which is why the bug is staging-only (N/A in production).What changes do you think we should make in order to solve the problem?
Because this is a deploy blocker on a staging-only feature, the fastest safe resolution is to revert #90403 — it cleanly removes the regression with no production impact.
If a revert is undesirable, the targeted fix is to stop the report view's unmount cleanup from clearing carousel IDs that the underlying Spend-page RHP still depends on — extend the existing descriptor guard so
clearActiveTransactionIDs()only fires when this view actually owns the active carousel (e.g. skip the cleanup when the current active IDs were seeded by the Spend page and the report view was layered on top).What alternative solutions did you explore? (Optional)
Considered scoping the carousel to a per-view key instead of one shared Onyx key, so unmounting one view can't clobber another's navigation state — larger change, better left as a follow-up rather than a deploy-blocker fix.
Possibly related: #93750 — "Forward/Back navigation buttons disappear after submitting a report" (same navigation arrows disappearing, different trigger). Worth checking whether both share the shared-key lifecycle issue.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/96545)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
11 remaining items
yuwenmemon commentedon Jul 21, 2026
This issue was fixed by the revert in #96636. @Expensify/applauseleads please retest.
[-]Spend - Arrow buttons on expense disappear after opening expense from expense report[/-][+][Due for payment 2026-07-29] Spend - Arrow buttons on expense disappear after opening expense from expense report[/+]melvin-bot commentedon Jul 22, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 22, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-07-29. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 22, 2026
@thelullabyy The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Jul 22, 2026
@thelullabyy The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]