Skip to content

[Due for payment 2026-07-29] Expense-More button is not aligned with the header in expense details in 1:1 chat #96575

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.4.41-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176922/test-cases/41237503
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: MacBook Air 26.5.2
App Component: Money Requests

Action Performed:

  1. Navigate to Account - Troubleshoot and clear cache
  2. Navigate to 1:1 chat
  3. Create a manual expense
  4. Click on the expense preview and observe the expense header and More button

Expected Result:

The More button is aligned with the header in the expense details

Actual Result:

The More button are not aligned with the header in the expense details in 1:1 chat.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7213105_1784609064744.More_is_not_aligned.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7213105

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 21, 2026
  2. applause-bot commented on Jul 21, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/b7c68c90e6e34f01899d5f5c517d5c5abae861082287b996ccf537f79555856d

  3. melvin-bot commented on Jul 21, 2026

    @melvin-bot

    Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Jul 21, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Jul 21, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. MelvinBot commented on Jul 21, 2026

    @MelvinBot
    Contributor

    Proposal

    Regression traced to #90403 — "Standardize Expense Report and Expense header with predictable button placement and carousel counter" (thelullabyy, merged 2026-07-17). It's a line item in the 9.4.41-0 StagingDeployCash and is the only staging-only PR that restructures the expense header layout, which matches "reproducible in staging, not production."

    What is the root cause of that problem?

    That PR restructured MoneyRequestHeader.tsx in two ways that shift the More button off the header baseline:

    1. It wrapped the buttons row in a styles.mtn1 container — a marginTop: -4 negative offset (spacing.ts:354) — that pulls the button up by 4px so it no longer lines up with the avatar/title.
    2. It changed the inline-render guard to !shouldDisplayButtonsInSeparateLine && !statusBarProps, so when a status is shown the More button is no longer rendered inline in the header row; it's relocated into the new mtn1-shifted status/actions row below.

    Net effect: on the affected layout the More button renders in a row that's offset 4px upward (and/or relocated), so it's visually misaligned with the header.

    Evidence & investigation details

    What changes do you think we should make in order to solve the problem?

    Remove or correct the styles.mtn1 (marginTop: -4) offset added to the buttons/status rows in MoneyRequestHeader.tsx (and re-check the relocated More button placement) so the button re-aligns to the header baseline. Because this is a deploy blocker, the fastest safe path is a revert of #90403 (or a targeted follow-up by the author) if a clean fix isn't quick.

    This fix is entirely within the App repo.

    No duplicate issues found in a quick scan.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/96575) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  7. Beamanator commented on Jul 21, 2026

    @Beamanator
    Contributor

    Looks like the PR we're accusing was reverted in #96636, will ask for retest

  8. Beamanator commented on Jul 21, 2026

    @Beamanator
    Contributor

    Hmm not fixed yet in v9.4.41-0, maybe that revert hasn't been CP'd yet

  9. Beamanator commented on Jul 21, 2026

    @Beamanator
    Contributor

    Fixed in v9.4.41-1!

    Image
  10. yuwenmemon commented on Jul 21, 2026

    @yuwenmemon
    Contributor

    This issue was fixed by the revert in #96636. @Expensify/applauseleads please retest.

  11. melvin-bot commented on Jul 22, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-07-29. 🎊

  12. changed the title [-]Expense-More button is not aligned with the header in expense details in 1:1 chat[/-] [+][Due for payment 2026-07-29] Expense-More button is not aligned with the header in expense details in 1:1 chat[/+] on Jul 22, 2026
  13. melvin-bot commented on Jul 22, 2026

    @melvin-bot

    @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. melvin-bot commented on Jul 22, 2026

    @melvin-bot

    @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions