Repository navigation
Always close the statement even after visiting multiple statement pages #9712
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Copy this URL into your browser: https://new.expensify.com/statements/202112/
- Then this one: https://new.expensify.com/statements/202201/
- Then this one: https://new.expensify.com/statements/202202/
- Click the
Xon the statement page in the rightDocked side modal - observe you're returned to the URL in Fix spaces #2. - Click the
Xagain - observe that you're returned to the URL in Some initial fixes and code style updates #1. - Click the
Xagain - observe that the rightDocked side modal closes
Expected Result:
Describe what you think should've happened
- Clicking the close button (
X) on the modal should close the statement modal and not redirect to the last statement you visited
Actual Result:
Describe what actually happened
- You get redirected to the last statement
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Yes, you can either just adjust the URL or just keep pressing X until you close the modal out
Platform:
Where is this issue occurring?
- Web x
- iOS
- Android
- Desktop App
- Mobile Web x
Version Number: v1.1.78-8
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Upwork URL: https://www.upwork.com/jobs/~01ce48a3c10dcdbe87
Issue reported by:
Slack conversation:
Activity
melvin-bot commentedon Jul 5, 2022
Triggered auto assignment to @sonialiap (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.melvin-bot commentedon Jul 5, 2022
Triggered auto assignment to @trjExpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Jul 5, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
Exported)15 remaining items
thienlnam commentedon Jul 6, 2022
Yeah I think it's because we're accessing it by modifying the URL instead of having a dedicated button that opens
Navigation.navigate(statement_route). Kind of like how if you click on another chat in the LHN the app won't reload, but if you manually edit the reportID in the URL it will cause it to reload. Not sure how it all plays into how the last page in the stack is the previous statement link thoughmarcaaron commentedon Jul 6, 2022
Ah ok, so, this is not unique to the statements. The same issue will happen if you navigate to something like
https://new.expensify.com/settings/payments
https://new.expensify.com/settings/preferences
marcaaron commentedon Jul 6, 2022
P.S. this issue is fixed by #9718 so I'm going to make it internal and assign myself.
[-][$250] Always close the statement even after visiting multiple statement pages[/-][+]Always close the statement even after visiting multiple statement pages[/+]trjExpensify commentedon Jul 6, 2022
Kewl, taken it down from Upwork. Removing myself as a CM is not required.