Skip to content

[$250] Accounting - The user cannot enable Card reconciliation to QuickBooks Online #97215

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number:
Reproducible in staging?: Needs Reproduction (Unable to access customer account, could not reproduce in QA account)
Reproducible in production?: Needs Reproduction (Unable to access customer account, could not reproduce in QA account)
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @VictoriaExpensify & Alannah Williams
Slack conversation (hyperlinked to channel name):

Action Performed:

  1. The user selects their Workspace
  2. They select the Accounting tab
  3. They click 'Card Reconciliation'
  4. They enable this
  5. They select the 'Workspace X'
  6. The screen refreshes to the Card Reconciliation tab with this disabled.

Expected Result:

The user can turn this on > select the account > the information saves and exports correctly

Actual Result:

The user turns card reconciliation on > selects the account > the screen refreshes with the button turned off.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

For the customer's details check please OP

View all open jobs on GitHub

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @thelullabyy

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 28, 2026
  2. exfy-zapier commented on Jul 28, 2026

    @exfy-zapier

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  3. MelvinBot commented on Jul 28, 2026

    @MelvinBot
    Contributor

    ⚠️ Preliminary analysis (medium confidence) — this is "Needs Reproduction" and the customer account couldn't be accessed, so the root cause below is inferred from code, not confirmed against a live repro or production logs.

    Issue Analysis

    Symptom: On QBO, enabling Card Reconciliation → picking a reconciliation account → returning to the tab leaves the toggle OFF.

    Most likely root cause (backend): The App code path is internally consistent — enabling the toggle optimistically writes true, and SET_CARD_RECONCILIATION_BANK_ACCOUNT never touches the toggle state. The toggle only flips back to OFF when the backend says so, via one of:

    1. TOGGLE_CARD_CONTINUOUS_RECONCILIATION returning non‑200, whose failureData reverts the optimistic value to !value → OFF (Card.ts:1620-1636).
    2. OpenPolicyAccountingPage re‑fetch overwriting the optimistic true with the backend's authoritative value, which stays OFF if the backend won't persist continuous reconciliation until a reconciliation account (or QBO auto‑sync) is associated first.

    Because the App side behaves correctly, the fix most likely lives outside this repo (Auth / Web‑Expensify — the TOGGLE_CARD_CONTINUOUS_RECONCILIATION command and its preconditions). This needs an internal engineer with access to those repos to confirm and fix — I can't propose an App code change for it. There is a related open App issue, #91505, suggesting the backend does gate continuous reconciliation on having a payable/reconciliation account set, which fits this symptom.

    To confirm: pull production logs for this workspace's TOGGLE_CARD_CONTINUOUS_RECONCILIATION and SET_CARD_RECONCILIATION_BANK_ACCOUNT calls — did the toggle command return non‑200, and does OpenPolicyAccountingPage return the continuous‑reconciliation field as 0 after the account is set?

    Investigation details
    • Settings page + toggle: CardReconciliationPage.tsx:85-108. Toggle isActive={!!continuousReconciliation} is derived solely from the Onyx collection key EXPENSIFY_CARD_USE_CONTINUOUS_RECONCILIATION_{effectiveDomainID} — read and written under the same effectiveDomainID, so it is not a key‑mismatch bug on the toggle itself.
    • Toggle is gated on QBO autoSync.enabled: disabled={!autoSync}. If auto‑sync is off the control is disabled entirely.
    • Toggle handler: toggleContinuousReconciliation, Card.ts:1572-1643 — successData keeps the value true; only failureData reverts it.
    • Account selection: setCardReconciliationAccount, Card.ts:1645-1668 — writes only the bank‑account‑ID key; no successData, so it cannot itself reset the toggle.
    • Secondary App‑side risk to verify: CardReconciliationPage keys off effectiveDomainID (parsed from the card‑feed key, falling back to policy.policyAccountID) — CardReconciliationPage.tsx:55,83 — while the account‑settings page passes policy.policyAccountID to setCardReconciliationAccount. If those differ for this workspace, the saved account row shows empty (though this would not by itself flip the toggle).

    Alternative explanations considered: a pure client key‑mismatch on the toggle (ruled out — read/write use the same effectiveDomainID); a missing optimistic update (ruled out — the optimistic write is present). The remaining explanations all route through the backend response.


    Next Steps for Contributor+ team:
    This looks like a backend (Auth/Web‑Expensify) issue rather than an App fix — please escalate to an internal engineer to confirm via logs whether TOGGLE_CARD_CONTINUOUS_RECONCILIATION is being rejected (and whether a reconciliation account is a required precondition).
    To refine: @MelvinBot <your feedback>

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jul 28, 2026
  5. melvin-bot commented on Jul 28, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

  6. melvin-bot commented on Jul 28, 2026

    @melvin-bot
  7. mukhrr commented on Jul 28, 2026

    @mukhrr
    Contributor

    @ahmedGaber93 I have a repro video in case you cannot.. I believe this is FE bug

  8. melvin-bot commented on Jul 31, 2026

    @melvin-bot

    @ahmedGaber93 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  9. ahmedGaber93 commented on Aug 2, 2026

    @ahmedGaber93
    Contributor

    I am not able to reproduce it.

    @mukhrr could you please share your steps and video? thanks!

    Image
  10. 62 remaining items

  11. heekinho commented on Sep 3, 2026

    @heekinho
    Contributor

    Nudged in slack for team's input. I'll keep adjusting the PRs so in case that solution is considered good we can quickly deploy it.

  12. melvin-bot commented on Sep 8, 2026

    @melvin-bot

    @heekinho Eep! 4 days overdue now. Issues have feelings too...

  13. heekinho commented on Sep 10, 2026

    @heekinho
    Contributor

    Actively working on it. Adjusted on the lastest sync today I create on PR on Web-Expensify and adjusted the App one.

  14. self-assigned this
    on Sep 23, 2026
  15. heekinho commented on Oct 9, 2026

    @heekinho
    Contributor

    App PR was just deployed to production. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorNeeds ReproductionReproducible steps neededReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions