You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Merging code to main can trigger deploy of unrelated systems #9725
We are working on releasing a new help site that's hosted in this repo. It deploys whenever code is merged to main. However, its deploy can be triggered even if the changes merged are completely unrelated to the help site, which causes:
An unnecessary deploy
Noise in slack
Noise in the git history
Unnecessary bloating of the deploy checklist
Similarly, merging helpsite-related code can trigger deploys of the main NewDot platform, which causes all the same issues, except it's even worse / more noisy.
Why this is important
This wastes engineering and QA time, and may distract others as well.
Solution
Check if a PR only contains changes in the /help directory. If so:
Don't add the PR to the main NewDot deploy checklist
Don't trigger a NewDot deploy, and instead only deploy the helpsite
If not (changes include files not in the /help directory, don't deploy the helpsite
Going to pick deploy improvements back up this week. Was holding off last week to avoid disrupting App deploys – we had some big checklists to get through
changed the title [-][HOLD] Merging code to main can trigger deploy of unrelated systems[/-][+]Merging code to main can trigger deploy of unrelated systems[/+]on Oct 5, 2023
Activity
roryabraham commentedon Jul 15, 2022
Not a priority for now.
roryabraham commentedon Jul 25, 2022
Going to pick deploy improvements back up this week. Was holding off last week to avoid disrupting App deploys – we had some big checklists to get through
roryabraham commentedon Aug 3, 2022
Not going to address this just now. Switching to monthly
19 remaining items
melvin-bot commentedon May 12, 2023
@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
melvin-bot commentedon Sep 22, 2023
@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
[-][HOLD] Merging code to main can trigger deploy of unrelated systems[/-][+]Merging code to main can trigger deploy of unrelated systems[/+]roryabraham commentedon Oct 5, 2023
Taking this off HOLD and will address it after I come back from OOO to prevent HelpDot test builds on non-HelpDot PRs for the sake of noise reduction.
roryabraham commentedon Nov 6, 2023
This was addressed in #30315