Skip to content

Merging code to main can trigger deploy of unrelated systems #9725

Closed

Description

@roryabraham

Problem

We are working on releasing a new help site that's hosted in this repo. It deploys whenever code is merged to main. However, its deploy can be triggered even if the changes merged are completely unrelated to the help site, which causes:

  1. An unnecessary deploy
  2. Noise in slack
  3. Noise in the git history
  4. Unnecessary bloating of the deploy checklist

Similarly, merging helpsite-related code can trigger deploys of the main NewDot platform, which causes all the same issues, except it's even worse / more noisy.

Why this is important

This wastes engineering and QA time, and may distract others as well.

Solution

Check if a PR only contains changes in the /help directory. If so:

  1. Don't add the PR to the main NewDot deploy checklist
  2. Don't trigger a NewDot deploy, and instead only deploy the helpsite

If not (changes include files not in the /help directory, don't deploy the helpsite

Activity

  1. self-assigned this
    on Jul 5, 2022
  2. roryabraham commented on Jul 15, 2022

    @roryabraham
    ContributorAuthor

    Not a priority for now.

  3. roryabraham commented on Jul 25, 2022

    @roryabraham
    ContributorAuthor

    Going to pick deploy improvements back up this week. Was holding off last week to avoid disrupting App deploys – we had some big checklists to get through

  4. roryabraham commented on Aug 3, 2022

    @roryabraham
    ContributorAuthor

    Not going to address this just now. Switching to monthly

  5. 19 remaining items

  6. melvin-bot commented on May 12, 2023

    @melvin-bot

    @roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  7. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    @roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  8. self-assigned this
    on Oct 5, 2023
  9. changed the title [-][HOLD] Merging code to main can trigger deploy of unrelated systems[/-] [+]Merging code to main can trigger deploy of unrelated systems[/+] on Oct 5, 2023
  10. roryabraham commented on Oct 5, 2023

    @roryabraham
    ContributorAuthor

    Taking this off HOLD and will address it after I come back from OOO to prevent HelpDot test builds on non-HelpDot PRs for the sake of noise reduction.

  11. roryabraham commented on Nov 6, 2023

    @roryabraham
    ContributorAuthor

    This was addressed in #30315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions