You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-10] Expense - Contact name disappears in recipient list after reset app #97250
Version Number: 9.4.45-4 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#96785 Email or phone of affected tester (no customers):soidjnsodjoisjiodjios@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Open 1:1 DM with any user.
Send a message to the user.
Go to Account > Troubleshoot > Clear cache and restart > Reset and refresh.
Open FAB > Create expense > Manual.
Enter amount > Next.
Click To field.
Expected Result:
Contact name will not disappear in recipient list after reset app.
Actual Result:
Contact name disappears in recipient list after reset app.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug (fix is in Expensify/App) Causing PR: #96785 - "Coalesce OnyxDerived recomputations via microtask scheduling" by @fabioh8010 (High confidence) Related Issues: #97251 (duplicate — same repro, version 9.4.45-4, same suspected PR)
Recommendation: REVERT
PR #96785 re-lands the OnyxDerived recompute coalescing engine that was already reverted twice for causing a cluster of stale-derived-data deploy blockers, and this regression is the same failure class: after a cache reset, the DM's reportAttributes.isEmpty stays stale/true, so the 1:1 chat is filtered out of the recipient list. Reverting restores the per-dependency recompute that does not have this staleness window.
Assigned: @fabioh8010 (PR author), @shubham1206agra and @mountiny (approving reviewers) from PR #96785 Labels: No change. DeployBlockerCash kept (App deploy is correctly blocked for a frontend regression). DeployBlocker (Web) was not present, so nothing to remove.
The repro flow (send a DM message → Clear cache and restart → open Create expense → "To" field) is exactly the kind of full-collection re-broadcast burst that the new coalescing/delta-reconstruction path handles, and the symptom (a chat that HAS a visible message being treated as empty and dropped from the option list) is a textbook stale-derived-value symptom.
Verification
The recipient list is built by OptionsListUtils, which filters reports via shouldReportBeInOptionList → reasonForReportToBeInOptionList in src/libs/ReportUtils.ts. A non-empty DM is dropped only when it is judged empty:
src/libs/ReportUtils.ts:9996-10008 returns null (excludes the chat) when excludeEmptyChats && isEmptyChat && isChatReport(report) && … && canHideReport — this is what makes the contact name disappear from the "To" list.
isEmptyReport reads the derived value directly: src/libs/ReportUtils.ts:9187-9189 → const attributes = reportAttributesDerivedValue?.[report.reportID]; if (attributes) { return attributes.isEmpty; }
So the option list's empty-chat filter is driven entirely by the REPORT_ATTRIBUTES derived value, and reportAttributes is one of the configs rewritten by PR #96785 (files changed include configs/reportAttributes.ts, configs/visibleReportActions.ts, configs/sortedReportActions.ts, and the coalescing engine OnyxDerived/index.ts + new getCollectionDelta.ts). Confirmed PR #96785 modifies these exact files.
Root Cause
PR #96785 stops using Onyx's own sourceValue and instead reconstructs the changed-member delta at flush time by diffing the current collection snapshot against a snapshot captured on the previous flush:
src/libs/actions/OnyxDerived/index.ts:80-81 — lastFlushedCollectionValues baseline + hasFlushedOnce flag are held in the per-key init() closure, created once at app startup.
src/libs/actions/OnyxDerived/index.ts:132-137 — once hasFlushedOnce is true, the delta is getCollectionDelta(current, lastFlushedCollectionValues[index]), and getCollectionDelta (src/libs/getCollectionDelta.ts:12-42) only emits members whose reference differs from the baseline.
"Clear cache and restart → Reset and refresh" clears Onyx and re-broadcasts every collection member through the existing connection callbacks (the init() closures are not re-created, so hasFlushedOnce is already true and the pre-reset baselines are still in lastFlushedCollectionValues). During that re-broadcast burst, reportAttributes then relies on the coalesced delta to decide what to recompute:
src/libs/actions/OnyxDerived/configs/reportAttributes.ts:306 — useIncrementalUpdates is true whenever currentValue.reports is non-empty (which it is, restored from disk/prior compute).
src/libs/actions/OnyxDerived/configs/reportAttributes.ts:361-441 — in the incremental path, only reports appearing in the reconstructed sourceValues delta (report / report-action / metadata updates) are recomputed; if the delta for the DM's REPORT_ACTIONS member is lost or split across bursts (a known hazard the PR itself calls out for sortedReportActions/reportTransactionsAndViolations where coalescing "would drop the second trigger"), the DM's isEmpty is never recomputed and remains true from before the message/reset settled.
With isEmpty stuck at true, reasonForReportToBeInOptionList filters the DM out at ReportUtils.ts:9996-10008, so the just-messaged contact vanishes from the manual-expense "To" recipient list — matching the report exactly, and matching the stale-derived-value class of the five blockers #96785 was meant to fix.
Because the fix requires changing Expensify/App code (revert or repair the coalescing engine), this is a Frontend bug and DeployBlockerCash should remain.
Recommendation detail: REVERT vs ROLL FORWARD
REVERT is recommended over a targeted fix because (a) this exact coalescing mechanism has already produced multiple deploy blockers across two prior land/revert cycles, indicating the delta-reconstruction approach is fragile under full re-broadcast bursts; (b) a targeted fix would need to prove correctness of delta reconstruction after cache reset across every derived config, which is higher risk under deploy-blocker time pressure than restoring the known-good per-dependency recompute. If the perf win must be preserved, roll forward only with a fix that forces a full (non-incremental) recompute after a storage clear/re-broadcast.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.48-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-10. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
changed the title [-]Expense - Contact name disappears in recipient list after reset app[/-][+][Due for payment 2026-08-10] Expense - Contact name disappears in recipient list after reset app[/+]on Aug 3, 2026
Activity
melvin-bot commentedon Jul 28, 2026
@mountiny recently merged #96785, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Jul 28, 2026
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Jul 28, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 28, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jul 28, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
MelvinBot commentedon Jul 28, 2026
🔍 Investigation Summary
Classification: Frontend bug (fix is in
Expensify/App)Causing PR: #96785 - "Coalesce OnyxDerived recomputations via microtask scheduling" by @fabioh8010 (High confidence)
Related Issues: #97251 (duplicate — same repro, version
9.4.45-4, same suspected PR)Recommendation: REVERT
PR #96785 re-lands the OnyxDerived recompute coalescing engine that was already reverted twice for causing a cluster of stale-derived-data deploy blockers, and this regression is the same failure class: after a cache reset, the DM's
reportAttributes.isEmptystays stale/true, so the 1:1 chat is filtered out of the recipient list. Reverting restores the per-dependency recompute that does not have this staleness window.Assigned: @fabioh8010 (PR author), @shubham1206agra and @mountiny (approving reviewers) from PR #96785
Labels: No change.
DeployBlockerCashkept (App deploy is correctly blocked for a frontend regression).DeployBlocker(Web) was not present, so nothing to remove.📋 Detailed Analysis
Evidence
@mountiny recently merged #96785. Coalesce OnyxDerived recomputations via microtask scheduling #96785 merged2026-07-24, landing in the9.4.45staging release where the bug first appears — reproducible on staging only, not production, consistent with a PR still on staging.src/libs/actions/OnyxDerived/index.tsconfirms this revert/re-land churn ("Revert OnyxDerived macrotask coalescing", "Revert Revert…", "Use queueMicrotask instead of macrotask").Verification
The recipient list is built by
OptionsListUtils, which filters reports viashouldReportBeInOptionList→reasonForReportToBeInOptionListinsrc/libs/ReportUtils.ts. A non-empty DM is dropped only when it is judged empty:src/libs/ReportUtils.ts:9942computesconst isEmptyChat = isEmptyReport(report, isReportArchived);src/libs/ReportUtils.ts:9996-10008returnsnull(excludes the chat) whenexcludeEmptyChats && isEmptyChat && isChatReport(report) && … && canHideReport— this is what makes the contact name disappear from the "To" list.isEmptyReportreads the derived value directly:src/libs/ReportUtils.ts:9187-9189→const attributes = reportAttributesDerivedValue?.[report.reportID]; if (attributes) { return attributes.isEmpty; }So the option list's empty-chat filter is driven entirely by the
REPORT_ATTRIBUTESderived value, andreportAttributesis one of the configs rewritten by PR #96785 (files changed includeconfigs/reportAttributes.ts,configs/visibleReportActions.ts,configs/sortedReportActions.ts, and the coalescing engineOnyxDerived/index.ts+ newgetCollectionDelta.ts). Confirmed PR #96785 modifies these exact files.Root Cause
PR #96785 stops using Onyx's own
sourceValueand instead reconstructs the changed-member delta at flush time by diffing the current collection snapshot against a snapshot captured on the previous flush:src/libs/actions/OnyxDerived/index.ts:80-81—lastFlushedCollectionValuesbaseline +hasFlushedOnceflag are held in the per-keyinit()closure, created once at app startup.src/libs/actions/OnyxDerived/index.ts:132-137— oncehasFlushedOnceis true, the delta isgetCollectionDelta(current, lastFlushedCollectionValues[index]), andgetCollectionDelta(src/libs/getCollectionDelta.ts:12-42) only emits members whose reference differs from the baseline."Clear cache and restart → Reset and refresh" clears Onyx and re-broadcasts every collection member through the existing connection callbacks (the
init()closures are not re-created, sohasFlushedOnceis alreadytrueand the pre-reset baselines are still inlastFlushedCollectionValues). During that re-broadcast burst,reportAttributesthen relies on the coalesced delta to decide what to recompute:src/libs/actions/OnyxDerived/configs/reportAttributes.ts:306—useIncrementalUpdatesis true whenevercurrentValue.reportsis non-empty (which it is, restored from disk/prior compute).src/libs/actions/OnyxDerived/configs/reportAttributes.ts:361-441— in the incremental path, only reports appearing in the reconstructedsourceValuesdelta (report / report-action / metadata updates) are recomputed; if the delta for the DM'sREPORT_ACTIONSmember is lost or split across bursts (a known hazard the PR itself calls out forsortedReportActions/reportTransactionsAndViolationswhere coalescing "would drop the second trigger"), the DM'sisEmptyis never recomputed and remainstruefrom before the message/reset settled.With
isEmptystuck attrue,reasonForReportToBeInOptionListfilters the DM out atReportUtils.ts:9996-10008, so the just-messaged contact vanishes from the manual-expense "To" recipient list — matching the report exactly, and matching the stale-derived-value class of the five blockers #96785 was meant to fix.Because the fix requires changing
Expensify/Appcode (revert or repair the coalescing engine), this is a Frontend bug andDeployBlockerCashshould remain.Recommendation detail: REVERT vs ROLL FORWARD
REVERT is recommended over a targeted fix because (a) this exact coalescing mechanism has already produced multiple deploy blockers across two prior land/revert cycles, indicating the delta-reconstruction approach is fragile under full re-broadcast bursts; (b) a targeted fix would need to prove correctness of delta reconstruction after cache reset across every derived config, which is higher risk under deploy-blocker time pressure than restoring the known-good per-dependency recompute. If the perf win must be preserved, roll forward only with a fix that forces a full (non-incremental) recompute after a storage clear/re-broadcast.
8 remaining items
fabioh8010 commentedon Jul 28, 2026
PR ready #97283
melvin-bot commentedon Aug 3, 2026
@shubham1206agra
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.48-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-10. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[-]Expense - Contact name disappears in recipient list after reset app[/-][+][Due for payment 2026-08-10] Expense - Contact name disappears in recipient list after reset app[/+]shubham1206agra commentedon Aug 4, 2026
@mountiny You can close this issue