Skip to content

[HOLD] Multiple concurrent deploys are slow #9726

Closed

Description

@roryabraham

Problem

When a PR is cherry-picked, we wait for staging deploys to finish before commenting in the deploy checklist to alert Applause of the newly-CP'd PR.

However, if we then merge / CP another PR, we run into softprops/turnstyle here. Then the second CP sits around and waits for the pending staging deploy to finish unnecessarily before creating a new version, CPing it to staging, and updating the checklist.

Why this is important

This causes unnecessary delays in the deploy process, particularly in scenarios where we want to complete multiple CP's in a row, which are typically more urgent scenarios. It will be even more important once we have the ability to CP PR's to production, because then production CP's will be delayed waiting for unrelated staging CP's, potentially adding hours to the time it takes for us to get an urgent fix out to users.

Solution

(ideally) Figure out a way to make it so we don't have to wait for staging deploys to finish. Maybe using a post-action hook?

Otherwise, cleverly separate jobs to make all the prep work (i.e: creating a new version, CPing it to staging, etc...) not have to wait.

Activity

  1. self-assigned this
    on Jul 6, 2022
  2. roryabraham commented on Aug 8, 2022

    @roryabraham
    ContributorAuthor

    No update.

  3. roryabraham commented on Sep 29, 2022

    @roryabraham
    ContributorAuthor

    Not a priority

  4. roryabraham commented on Sep 29, 2022

    @roryabraham
    ContributorAuthor

    Also would like to bundle this together with a suite of deploy improvements

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2022
  6. roryabraham commented on Oct 31, 2022

    @roryabraham
    ContributorAuthor

    No update

  7. 2 remaining items

  8. changed the title [-]Multiple concurrent deploys are slow[/-] [+][HOLD] Multiple concurrent deploys are slow[/+] on Nov 28, 2022
  9. roryabraham commented on Dec 5, 2022

    @roryabraham
    ContributorAuthor

    No update

  10. removed their assignment
    on Dec 14, 2022
  11. roryabraham commented on Dec 14, 2022

    @roryabraham
    ContributorAuthor

    Dropping, see #12021 (comment)

  12. MelvinBot commented on Feb 27, 2023

    @MelvinBot
    Contributor

    @roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  13. melvin-bot commented on May 12, 2023

    @melvin-bot

    @roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

  14. melvin-bot commented on Sep 22, 2023

    @melvin-bot

    @roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

    If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions