Skip to content

[Due for payment 2026-08-19] [CFI] Limit the From/To filter to workspace members when filtered to a workspace. #97343

Closed

Description

@melvin-bot

Problem

The Search From / To selectors (shared UserSelector) are populated from every contact "known" to the account — i.e. anyone the user has ever shared a workspace, report, DM, or IOU with. There is no membership-based grouping, so users at large or long-tenured accounts wade through hundreds of legacy/irrelevant contacts, and it's not obvious which options belong to the workspace they're actually looking at.

This came out of a report where an account that was formerly an admin/domain admin of a now-separated company still sees 10–20 users from that company in the From/To filters (they return zero results and add noise). The full list is intentional — the selector also supports filtering IOU/DM expenses with people outside your workspaces — so we don't want to hard-filter it. Instead we want better organization.

Proposed solution

When a workspace filter is applied, limit the From/To filter to workspace members.

Context

Reported in Slack.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    NewFeatureSomething to build that is a new item.
    and removed on Jul 29, 2026
  2. melvin-bot commented on Jul 29, 2026

    @melvin-bot
    Author

    Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

  3. changed the title [-]From/To (and other user selectors) - Section workspace members above all contacts when a workspace filter is applied[/-] [+][CFI] From/To (and other user selectors) - Section workspace members above all contacts when a workspace filter is applied[/+] on Jul 29, 2026
  4. bernhardoj commented on Jul 30, 2026

    @bernhardoj
    Contributor

    To/From filter is currently lagging so badly, and the list isn't scrollable. I think we need to fix that first. It's the same report in this Slack thread.

    Oh, turns out it's a regression from the filter negation PR. I've included the fix in this PR.

  5. changed the title [-][CFI] From/To (and other user selectors) - Section workspace members above all contacts when a workspace filter is applied[/-] [+][CFI] Limit the From/To filter to workspace members when filtered to a workspace.[/+] on Aug 3, 2026
  6. 13 remaining items

  7. melvin-bot commented on Aug 13, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  8. thelullabyy commented on Aug 14, 2026

    @thelullabyy
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: NA
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Test:

    Prerequisite: have some workspaces with some members

    1. Open Spend
    2. Press the Filters button
    3. Open the From/To filter
    4. Verify it shows all users
    5. Open the Workspace filter
    6. Select any workspace
    7. Open the From/To filter
    8. Verify it only shows users from the selected workspace members

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-076e-aa29-3e9f-ad4efea68734
  9. melvin-bot commented on Aug 18, 2026

    @melvin-bot
    Author

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
  10. melvin-bot commented on Aug 18, 2026

    @melvin-bot
    Author

    @mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

  11. mallenexpensify commented on Aug 20, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @bernhardoj due $250 via NewDot
    Contributor+: @thelullabyy due $250 via NewDot

  12. flaviadefaria commented on Aug 21, 2026

    @flaviadefaria
    Contributor

    Approved: @bernhardoj due $250 via NewDot

  13. laurenreidexpensify commented on Sep 7, 2026

    @laurenreidexpensify
    Contributor

    $250 approved @thelullabyy New Expensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions