You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-19] [CFI] Limit the From/To filter to workspace members when filtered to a workspace. #97343
The Search From / To selectors (shared UserSelector) are populated from every contact "known" to the account — i.e. anyone the user has ever shared a workspace, report, DM, or IOU with. There is no membership-based grouping, so users at large or long-tenured accounts wade through hundreds of legacy/irrelevant contacts, and it's not obvious which options belong to the workspace they're actually looking at.
This came out of a report where an account that was formerly an admin/domain admin of a now-separated company still sees 10–20 users from that company in the From/To filters (they return zero results and add noise). The full list is intentional — the selector also supports filtering IOU/DM expenses with people outside your workspaces — so we don't want to hard-filter it. Instead we want better organization.
Proposed solution
When a workspace filter is applied, limit the From/To filter to workspace members.
changed the title [-]From/To (and other user selectors) - Section workspace members above all contacts when a workspace filter is applied[/-][+][CFI] From/To (and other user selectors) - Section workspace members above all contacts when a workspace filter is applied[/+]on Jul 29, 2026
To/From filter is currently lagging so badly, and the list isn't scrollable. I think we need to fix that first. It's the same report in this Slack thread.
Oh, turns out it's a regression from the filter negation PR. I've included the fix in this PR.
changed the title [-][CFI] From/To (and other user selectors) - Section workspace members above all contacts when a workspace filter is applied[/-][+][CFI] Limit the From/To filter to workspace members when filtered to a workspace.[/+]on Aug 3, 2026
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: NA
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Test:
Prerequisite: have some workspaces with some members
Open Spend
Press the Filters button
Open the From/To filter
Verify it shows all users
Open the Workspace filter
Select any workspace
Open the From/To filter
Verify it only shows users from the selected workspace members
Activity
melvin-bot commentedon Jul 29, 2026
Triggered auto assignment to Design team member for new feature review - @dannymcclain (
NewFeature)[-]From/To (and other user selectors) - Section workspace members above all contacts when a workspace filter is applied[/-][+][CFI] From/To (and other user selectors) - Section workspace members above all contacts when a workspace filter is applied[/+]bernhardoj commentedon Jul 30, 2026
To/From filter is currently lagging so badly, and the list isn't scrollable. I think we need to fix that first. It's the same report in this Slack thread.
Oh, turns out it's a regression from the filter negation PR. I've included the fix in this PR.
[-][CFI] From/To (and other user selectors) - Section workspace members above all contacts when a workspace filter is applied[/-][+][CFI] Limit the From/To filter to workspace members when filtered to a workspace.[/+]13 remaining items
melvin-bot commentedon Aug 13, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)thelullabyy commentedon Aug 14, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: NA
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Test:
Prerequisite: have some workspaces with some members
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-076e-aa29-3e9f-ad4efea68734melvin-bot commentedon Aug 18, 2026
Payment Summary
Resolving PRs:
Only show user from selected workspace filter for From/To filter #97516
Reviewer: @bernhardoj owed $250 via NewDot
Reviewer: @thelullabyy owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
melvin-bot commentedon Aug 18, 2026
@mallenexpensify Eep! 4 days overdue now. Issues have feelings too...
mallenexpensify commentedon Aug 20, 2026
Payment Summary
Contributor: @bernhardoj due $250 via NewDot
Contributor+: @thelullabyy due $250 via NewDot
flaviadefaria commentedon Aug 21, 2026
Approved: @bernhardoj due $250 via NewDot
laurenreidexpensify commentedon Sep 7, 2026
$250 approved @thelullabyy New Expensify