Skip to content

[Due for payment 2026-08-05] Payment issue for E/App PR#96911 #97377

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #96911
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/663612.
Contributor+ member who reviewed the PR - @Eskalifer1.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Jul 29, 2026

    @melvin-bot
    Author

    @Eskalifer1 The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. Eskalifer1 commented on Aug 3, 2026

    @Eskalifer1
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: https://github.com/Expensify/App/pull/91646/changes#r3702575163

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Test:

    1. Go to Account > Private and press Phone number
    2. Enter a number with a country code and dashes in it, such as +1480-555-5555 (make sure it's numerically different from the existing value if you already have one, otherwise you won't be able to tell whether it worked)
    3. Press save, enter the security code
    4. Validate that your new number appears in the Private Phone number section. Note that it is expected that it will be just the numbers, without any dashes

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-6797-a97f-d0c4-7117a39a8e54
  3. Eskalifer1 commented on Aug 3, 2026

    @Eskalifer1
    Contributor

    @MelvinBot find offending PR for this issue

  4. MelvinBot commented on Aug 3, 2026

    @MelvinBot
    Contributor

    Offending PR: #87928

    The bug fixed by #96911 was in updatePrivatePersonalDetails — the exact Private phone number flow the regression test above targets. That function (and its buggy line) was introduced by Expensify/App#87928 — "Replace individual private detail edit pages with unified form + magic code" (author jasperhuangg, merged 2026-05-15).

    Root cause: #87928 added phoneNumber: LoginUtils.appendCountryCode(values.phoneNumber?.trim() ?? '', countryCode). appendCountryCode just prepends the country code to whatever the user typed, so a US-style number with dashes (+1480-555-5555) is neither valid E.164 nor US-customary and gets stripped by the WAF. #96911 fixed it by switching to formatE164PhoneNumber.

    This was a recent regression — updatePrivatePersonalDetails did not exist before #87928, so the private-phone bug was born there.

    Note on the second line changed by #96911

    #96911 also changed the same pattern in buildSetPersonalDetailsAndShipExpensifyCardsParams (the ship-Expensify-cards flow, pre-fix L60). That appendCountryCode usage is long-standing, not from #87928:

    • Originally added in Expensify/App#48775 (2024-09-12, single-arg form)
    • The 2-arg , countryCode form added in Expensify/App#69285 (2025-09-12)
    • Later moved into the current helper by Expensify/App#82376 (2026-03-12)

    For the "offending PR" attribution on this payment issue, #87928 is the one to comment on — it caused the reported Private phone number regression. #48775 only matters if you also want to attribute the card-shipping flow lineage.

    Confidence: high — verified the buggy line was added verbatim in #87928's commit 6aef26921a, and that both lines were present at the pre-fix commit 1700eae.

  5. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 4, 2026
  6. melvin-bot commented on Aug 4, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  7. melvin-bot commented on Aug 4, 2026

    @melvin-bot
    Author

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  8. mallenexpensify commented on Aug 7, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @Eskalifer1 paid $250 via Upwork

    @Eskalifer1 can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022085545056515710262

  9. Eskalifer1 commented on Aug 7, 2026

    @Eskalifer1
    Contributor

    Hi @mallenexpensify, i have accepted, thank you!

  10. mallenexpensify commented on Aug 8, 2026

    @mallenexpensify
    Contributor

    @Eskalifer1 paid, summary updated above. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions