You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-05] Payment issue for E/App PR#96911 #97377
@Eskalifer1 The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Enter a number with a country code and dashes in it, such as +1480-555-5555 (make sure it's numerically different from the existing value if you already have one, otherwise you won't be able to tell whether it worked)
Press save, enter the security code
Validate that your new number appears in the Private Phone number section. Note that it is expected that it will be just the numbers, without any dashes
The bug fixed by #96911 was in updatePrivatePersonalDetails — the exact Private phone number flow the regression test above targets. That function (and its buggy line) was introduced by Expensify/App#87928 — "Replace individual private detail edit pages with unified form + magic code" (author jasperhuangg, merged 2026-05-15).
#96911 also changed the same pattern in buildSetPersonalDetailsAndShipExpensifyCardsParams (the ship-Expensify-cards flow, pre-fix L60). That appendCountryCode usage is long-standing, not from #87928:
Originally added in Expensify/App#48775 (2024-09-12, single-arg form)
The 2-arg , countryCode form added in Expensify/App#69285 (2025-09-12)
Later moved into the current helper by Expensify/App#82376 (2026-03-12)
For the "offending PR" attribution on this payment issue, #87928 is the one to comment on — it caused the reported Private phone number regression. #48775 only matters if you also want to attribute the card-shipping flow lineage.
Confidence: high — verified the buggy line was added verbatim in #87928's commit 6aef26921a, and that both lines were present at the pre-fix commit 1700eae.
Activity
melvin-bot commentedon Jul 29, 2026
@Eskalifer1 The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Eskalifer1 commentedon Aug 3, 2026
BugZero Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: https://github.com/Expensify/App/pull/91646/changes#r3702575163
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/669351
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-6797-a97f-d0c4-7117a39a8e54Eskalifer1 commentedon Aug 3, 2026
@MelvinBot find offending PR for this issue
MelvinBot commentedon Aug 3, 2026
Offending PR: #87928
The bug fixed by #96911 was in
updatePrivatePersonalDetails— the exact Private phone number flow the regression test above targets. That function (and its buggy line) was introduced by Expensify/App#87928 — "Replace individual private detail edit pages with unified form + magic code" (authorjasperhuangg, merged 2026-05-15).Root cause: #87928 added
phoneNumber: LoginUtils.appendCountryCode(values.phoneNumber?.trim() ?? '', countryCode).appendCountryCodejust prepends the country code to whatever the user typed, so a US-style number with dashes (+1480-555-5555) is neither valid E.164 nor US-customary and gets stripped by the WAF. #96911 fixed it by switching toformatE164PhoneNumber.This was a recent regression —
updatePrivatePersonalDetailsdid not exist before #87928, so the private-phone bug was born there.Note on the second line changed by #96911
#96911 also changed the same pattern in
buildSetPersonalDetailsAndShipExpensifyCardsParams(the ship-Expensify-cards flow, pre-fix L60). ThatappendCountryCodeusage is long-standing, not from #87928:Expensify/App#48775(2024-09-12, single-arg form), countryCodeform added inExpensify/App#69285(2025-09-12)Expensify/App#82376(2026-03-12)For the "offending PR" attribution on this payment issue, #87928 is the one to comment on — it caused the reported Private phone number regression. #48775 only matters if you also want to attribute the card-shipping flow lineage.
Confidence: high — verified the buggy line was added verbatim in #87928's commit
6aef26921a, and that both lines were present at the pre-fix commit1700eae.melvin-bot commentedon Aug 4, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 4, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Aug 7, 2026
Payment Summary
Contributor+: @Eskalifer1 paid $250 via Upwork
@Eskalifer1 can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022085545056515710262
Eskalifer1 commentedon Aug 7, 2026
Hi @mallenexpensify, i have accepted, thank you!
mallenexpensify commentedon Aug 8, 2026
@Eskalifer1 paid, summary updated above. Thx.