You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-31] Expense - Deleted unreported split reappears when user turns to offline mode. #97400
Version Number: 9.4.46-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#92055 Email or phone of affected tester (no customers):ibellicotest+2766@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Money Requests
Action Performed:
Prerequisite: Account has Self DM.
Open the staging.new.expensify.com website.
Navigate to Self DM
Create a manual expense.
Open the just created expense.
Click on "More" > "Split" > Save splits.
Return to chat.
Right click and delete both splits.
Turn to offline mode.
Note that deleted split reappears in chat when user is in offline mode.
Turn to online mode.
Note that split disappears again.
Expected Result:
Deleted splits shouldn´t reappear when user is in offline mode.
Actual Result:
Deleted split becomes visible again when user turns to offline mode.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #92055 - "Split expense from Self DM / unreported expense" by @ZhenjaHorbach (High confidence) Related Issues: N/A (new feature, not in production)
Recommendation: REVERT
The bug is entirely inside the new self-DM / unreported split-delete flow shipped by this PR; it is staging-only and does not exist in production. Reverting #92055 cleanly unblocks the App deploy. A targeted roll-forward is also viable (see Root Cause) if the team prefers to keep the feature on staging.
Assigned: @ZhenjaHorbach (PR author), @lakchote and @dmkt9 (approving reviewers) — already assigned by Melvin. Labels: No changes. DeployBlockerCash is the only blocker label present and is correctly kept (Frontend bug — App deploy blocked). No DeployBlocker present to remove.
Prod vs staging: Reproducible on staging, N/A in production — this is exactly the "Split expense from Self DM / unreported expense" feature that Fix bugs for selfDM splits feature #92055 introduces, so no prod code path exists.
Scope match: The PR is the only change touching the split-delete code paths: src/hooks/useDeleteTransactions.ts, src/libs/actions/IOU/SplitTransactionUpdate.ts, src/libs/actions/IOU/SplitExpenseItems.ts, src/libs/actions/IOU/Split.ts.
The PR's own code comments explicitly acknowledge this class of bug — a split "remains visible ... when offline" — and add a partial fix that does not cover the deleted split.
Verification
Affected feature: deleting split children created from a Self-DM / unreported expense.
Delete routing lives in useDeleteTransactions.deleteTransactions, which groups split children by original transaction and calls updateSplitTransactions(...), notably forwarding isOffline:
When splits from a Self DM are deleted, the flow reaches updateSplitTransactions. For each split being removed it calls getDeleteTrackExpenseInformation, which optimistically marks that split's IOU report action with only pendingAction: DELETE (not removal), and only clears/removes it in successData — i.e. after the server responds:
The PR authors already discovered that a split marked merely pendingAction: DELETEstays visible offline (a split-expense preview action is not rendered as a deleted comment the way a normal message is). Their fix — SplitTransactionUpdate.ts L1361-L1416 — sets the report action to nullin optimisticData so it disappears offline too. But that null-removal is gated on forceDeleteSplitTransactionID, which is set only for the reverse-split operation and points only at the kept/merged split (splitExpenses.at(0)):
So the split that is actually being deleted (the undeletedTransaction iterated at L1341) never gets the optimistic null removal — it keeps pendingAction: DELETE only. Result:
Online: successData (server round-trip) finishes the removal → the split disappears.
Offline: successData never runs and pendingAction: DELETE alone doesn't hide the split preview → the deleted split reappears, then vanishes again once back online. This is exactly the reported symptom.
Roll-forward fix option (if not reverting): extend the optimistic report-action null removal at L1401-L1406 to cover every deleted split in the loop (not just forceDeleteSplitTransactionID), pushing value: {[currentReportAction.reportActionID]: null} to optimisticData (with the matching failureData restore) for each undeletedTransaction, so the deletion is hidden offline as well as online.
changed the title [-]Expense - Deleted unreported split reappears when user turns to offline mode.[/-][+][Due for payment 2026-08-31] Expense - Deleted unreported split reappears when user turns to offline mode.[/+]on Aug 24, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-31. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jul 29, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/60398abd67c956ee2a13ee5d6fdc6b805ef68b7220c87f64dda509a443089f0c
melvin-bot commentedon Jul 29, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #92055
melvin-bot commentedon Jul 29, 2026
@lakchote @dmkt9 you have been assigned to this deploy blocker because you reviewed the offending PR: #92055
melvin-bot commentedon Jul 29, 2026
@ZhenjaHorbach you have been assigned to this deploy blocker because you authored the offending PR: #92055
melvin-bot commentedon Jul 29, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 29, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 29, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #92055 - "Split expense from Self DM / unreported expense" by @ZhenjaHorbach (High confidence)
Related Issues: N/A (new feature, not in production)
Recommendation: REVERT
The bug is entirely inside the new self-DM / unreported split-delete flow shipped by this PR; it is staging-only and does not exist in production. Reverting #92055 cleanly unblocks the App deploy. A targeted roll-forward is also viable (see Root Cause) if the team prefers to keep the feature on staging.
Assigned: @ZhenjaHorbach (PR author), @lakchote and @dmkt9 (approving reviewers) — already assigned by Melvin.
Labels: No changes.
DeployBlockerCashis the only blocker label present and is correctly kept (Frontend bug — App deploy blocked). NoDeployBlockerpresent to remove.📋 Detailed Analysis
Evidence
2026-07-29T09:35Z; issue reported the same day against9.4.46-0. It is item The mobile app opens up with the keyboard showing #76 in the currentStagingDeployCash(#97375).src/hooks/useDeleteTransactions.ts,src/libs/actions/IOU/SplitTransactionUpdate.ts,src/libs/actions/IOU/SplitExpenseItems.ts,src/libs/actions/IOU/Split.ts.Verification
useDeleteTransactions.deleteTransactions, which groups split children by original transaction and callsupdateSplitTransactions(...), notably forwardingisOffline:useDeleteTransactions.tsL247-L337 (isOfflinepassed at L333).SplitTransactionUpdate.ts:getDeleteTrackExpenseInformation:TrackExpense.tsL669-L759.All three files are in Fix bugs for selfDM splits feature #92055's changeset — confirmed.
Root Cause
When splits from a Self DM are deleted, the flow reaches
updateSplitTransactions. For each split being removed it callsgetDeleteTrackExpenseInformation, which optimistically marks that split's IOU report action with onlypendingAction: DELETE(not removal), and only clears/removes it insuccessData— i.e. after the server responds:TrackExpense.tsL669-L688 and L731-L736 →pendingAction: DELETE.TrackExpense.tsL748-L759.The PR authors already discovered that a split marked merely
pendingAction: DELETEstays visible offline (a split-expense preview action is not rendered as a deleted comment the way a normal message is). Their fix —SplitTransactionUpdate.tsL1361-L1416 — sets the report action tonullinoptimisticDataso it disappears offline too. But that null-removal is gated onforceDeleteSplitTransactionID, which is set only for the reverse-split operation and points only at the kept/merged split (splitExpenses.at(0)):So the split that is actually being deleted (the
undeletedTransactioniterated at L1341) never gets the optimisticnullremoval — it keepspendingAction: DELETEonly. Result:successData(server round-trip) finishes the removal → the split disappears.successDatanever runs andpendingAction: DELETEalone doesn't hide the split preview → the deleted split reappears, then vanishes again once back online. This is exactly the reported symptom.Roll-forward fix option (if not reverting): extend the optimistic report-action
nullremoval at L1401-L1406 to cover every deleted split in the loop (not justforceDeleteSplitTransactionID), pushingvalue: {[currentReportAction.reportActionID]: null}tooptimisticData(with the matchingfailureDatarestore) for eachundeletedTransaction, so the deletion is hidden offline as well as online.11 remaining items
[-]Expense - Deleted unreported split reappears when user turns to offline mode.[/-][+][Due for payment 2026-08-31] Expense - Deleted unreported split reappears when user turns to offline mode.[/+]melvin-bot commentedon Aug 24, 2026
@ZhenjaHorbach / @dmkt9
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.59-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-31. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
ZhenjaHorbach commentedon Aug 25, 2026
@lakchote
I suppose we can close this
lakchote commentedon Aug 27, 2026
Yes, done!