You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-07] iOS - Spend - Filter name is cut off in landscape mode #97414
Version Number: 9.4.46-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#93909 Email or phone of affected tester (no customers):sdsjodijnsdojsosjio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: iPhone 15 Pro Max / iOS 26.5.2 App Component: Money Requests
Action Performed:
Launch Expensify app.
Go to Spend > Expenses.
Open Filters.
Tap Status.
Select any status > Confirm > Apply filters.
Rotate device to landscape mode.
Open Status quick filter.
Expected Result:
"Status" filter name will not be cut off in landscape mode.
Actual Result:
"Status" filter name is cut off in landscape mode.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #93909 - "Add filter negation feature" by @bernhardoj (Medium-High confidence) Related Issues: #93208 (feature request implemented by the PR)
Recommendation: ROLL FORWARD (targeted fix)
The negation feature adds a new "Filter type" toggle row at the top of every negatable filter popup (including Status). In landscape the bottom-docked popup does not scroll, so the extra row pushes the "Status" label until it is clipped. A targeted layout fix is far safer than reverting the entire feature PR; this is a cosmetic, landscape-only issue that BugZero may also choose to DEMOTE.
Assigned: @bernhardoj (PR author), @JS00001 and @aimane-chnaif (approving reviewers) — already assigned by melvin-bot, confirmed correct. Labels: No change. Kept DeployBlockerCash (frontend bug, App deploy blocked). DeployBlocker was not present. Not reproducible in production, so the App blocker label stays.
📋 Detailed Analysis
Evidence
The reported control is the Status quick filter, which renders through ListPopup → BasePopup, with the <ListFilterContent> body wrapped in the new NegatableFilter component.
STATUS is a negatable filter key (src/types/form/SearchAdvancedFiltersForm.ts line 55), so opening the Status quick filter now renders the negation toggle row.
PR Add filter negation feature #93909 file list confirms it createsNegatableFilter.tsx, ListPopup.tsx (replacing the deleted CommonPopup.tsx), and adds the search.filters.filterType.* strings across all src/languages/* — i.e. it is exactly the code that populates the top of the Status popup.
With no scroll container and limited vertical space in landscape, the content that exceeds the available height gets clipped at the top. PR #93909 added the extra NegatableFilter toggle row above the list, increasing the popup's content height by one row and pushing the "Status" title into the clipped region — so the title now appears cut off in landscape.
Note that FilterPopupButton.tsx (which sets the no-scroll-in-landscape behavior) was NOT modified by #93909; that behavior pre-existed. #93909 is the trigger because it added the extra height. Hence a targeted fix (allow the popup content to scroll when bottom-docked in landscape, or reduce/relayout the negation row height) is preferable to reverting the whole feature. If a quick fix is not feasible before deploy, DEMOTE is reasonable since the filter remains fully functional and only the title label is visually clipped in landscape.
changed the title [-]iOS - Spend - Filter name is cut off in landscape mode[/-][+][Due for payment 2026-08-07] iOS - Spend - Filter name is cut off in landscape mode[/+]on Jul 31, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Jul 30, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/7c97466080802deba3bc41dfe8079f48f5da6553aedc60cc8a371ee2bab6299a
melvin-bot commentedon Jul 30, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #93909
melvin-bot commentedon Jul 30, 2026
@JS00001 @aimane-chnaif you have been assigned to this deploy blocker because you reviewed the offending PR: #93909
melvin-bot commentedon Jul 30, 2026
@bernhardoj you have been assigned to this deploy blocker because you authored the offending PR: #93909
melvin-bot commentedon Jul 30, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Jul 30, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Jul 30, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #93909 - "Add filter negation feature" by @bernhardoj (Medium-High confidence)
Related Issues: #93208 (feature request implemented by the PR)
Recommendation: ROLL FORWARD (targeted fix)
The negation feature adds a new "Filter type" toggle row at the top of every negatable filter popup (including Status). In landscape the bottom-docked popup does not scroll, so the extra row pushes the "Status" label until it is clipped. A targeted layout fix is far safer than reverting the entire feature PR; this is a cosmetic, landscape-only issue that BugZero may also choose to DEMOTE.
Assigned: @bernhardoj (PR author), @JS00001 and @aimane-chnaif (approving reviewers) — already assigned by melvin-bot, confirmed correct.
Labels: No change. Kept
DeployBlockerCash(frontend bug, App deploy blocked).DeployBlockerwas not present. Not reproducible in production, so the App blocker label stays.📋 Detailed Analysis
Evidence
ListPopup→BasePopup, with the<ListFilterContent>body wrapped in the newNegatableFiltercomponent.STATUSis a negatable filter key (src/types/form/SearchAdvancedFiltersForm.tsline 55), so opening the Status quick filter now renders the negation toggle row.StagingDeployCashDeploy Checklist: New Expensify 2026-07-29 #97375) introducedNegatableFilter.tsxas a brand-new file. It renders an extra header row ("Filter type" label + is/is-not toggle) above the existing popup content:App/src/components/Search/FilterComponents/NegatableFilter.tsx
Lines 39 to 60 in ad07aea
Verification
src/components/Search/FilterDropdowns/ListPopup.tsx,BasePopup.tsx,FilterPopupButton.tsx, andsrc/components/Search/FilterComponents/NegatableFilter.tsx.NegatableFilter.tsx,ListPopup.tsx(replacing the deletedCommonPopup.tsx), and adds thesearch.filters.filterType.*strings across allsrc/languages/*— i.e. it is exactly the code that populates the top of the Status popup.BasePopup:App/src/components/Search/FilterDropdowns/BasePopup.tsx
Lines 30 to 42 in ad07aea
Root Cause
The popover is bottom-docked in landscape and is explicitly configured NOT to wrap its children in a scroll view in that mode:
App/src/components/Search/FilterDropdowns/FilterPopupButton.tsx
Line 150 in ad07aea
With no scroll container and limited vertical space in landscape, the content that exceeds the available height gets clipped at the top. PR #93909 added the extra
NegatableFiltertoggle row above the list, increasing the popup's content height by one row and pushing the "Status" title into the clipped region — so the title now appears cut off in landscape.Note that
FilterPopupButton.tsx(which sets the no-scroll-in-landscape behavior) was NOT modified by #93909; that behavior pre-existed. #93909 is the trigger because it added the extra height. Hence a targeted fix (allow the popup content to scroll when bottom-docked in landscape, or reduce/relayout the negation row height) is preferable to reverting the whole feature. If a quick fix is not feasible before deploy, DEMOTE is reasonable since the filter remains fully functional and only the title label is visually clipped in landscape.melvin-bot commentedon Jul 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
JS00001 commentedon Jul 30, 2026
Requested retest, we CPd a fix
[-]iOS - Spend - Filter name is cut off in landscape mode[/-][+][Due for payment 2026-08-07] iOS - Spend - Filter name is cut off in landscape mode[/+]melvin-bot commentedon Jul 31, 2026
@bernhardoj / @aimane-chnaif
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.46-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-08-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]