You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-08-17] Spend - Descenders are not highlighted when hovered over International reimbursement ID #97747
Version Number: 9.4.49-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#97337 Email or phone of affected tester (no customers):sdsiodjnosdjiodsj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Search
Action Performed:
Precondition:
Set app language to Polski or Greek.
Go to staging.new.expensify.com
Go to Spend > Expenses.
Click Filters.
Scroll down to Identytikatory zwrotów międzynarodowych (International reimbursement IDs).
Hover over Identytikatory zwrotów międzynarodowych (International reimbursement IDs).
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #97337 - "Add search filters for Custom Field 1, Custom Field 2, and International Reimbursement IDs" by @MelvinBot (High confidence that it exposes the bug; the underlying style is pre-existing) Related Issues: #95389 (feature request implemented by the PR)
Recommendation: ROLL FORWARD
The root cause is a pre-existing fixed row height in the shared advanced-filters list component (typeFilterMenu, height: 52) that PR #97337 did not touch — the PR merely added a new filter row whose long Polish/Greek label wraps to two lines and exposes it. The fix is a one-line style change (height → minHeight), which is far simpler and safer than reverting a legitimate feature, and it also cures the latent bug for any other long/localized label.
Assigned: @shubham1206agra, @JS00001 (approving reviewers of #97337) — already assigned. The PR author is a bot, so no additional human author to assign. Labels: No change. DeployBlockerCash is correct (App deploy) and is kept because this is a frontend bug. There is no DeployBlocker (Web) label to remove.
📋 Detailed Analysis
Evidence
The bug only reproduces with the app language set to Polski/Greek and only on the International reimbursement IDs row — both facts point at the label length, not the filter logic.
PR Add search filters for Custom Field 1, Custom Field 2, and International Reimbursement IDs #97337 added this exact filter row. It reuses the existing localized label common.internationalReimbursementIDs and the generic FilterItem renderer; it adds no new component or style. Its file list contains only CONST, parsers, SearchQueryUtils.ts, SearchUIUtils.ts, form/types, and useAdvancedSearchFilters.ts — notFilterList.tsx or styles/index.ts.
English label "International reimbursement IDs" fits on one line and highlights correctly. The Polish translation Identyfikatory zwrotów międzynarodowych (pl.ts#L406) is longer, wraps to two lines, and overflows the fixed-height row so the second line's descenders (y, ó, ą, ż …) fall below the hover-highlight background.
N/A in production because the filter is a new feature; reproduces on staging only, consistent with the new PR.
Verification
Affected renderer: FilterList.tsxFilterItem — the hover highlight is the PressableWithFeedback background, styled by styles.typeFilterMenu, and the label is a wrapping <Text style={[styles.flex1]}> with no numberOfLines.
Offending style: styles.typeFilterMenu — flexDirection: 'row', alignItems: 'center', and a hard height: 52.
typeFilterMenu fixes the row at height: 52. With alignItems: 'center', single-line labels sit centered and the whole glyph (including descenders) stays inside the 52px pressable, so the hover background covers it. A longer localized label wraps to two lines whose combined line-box height exceeds the available content height (52px minus paddingVertical: 4). Because the height is fixed rather than a minimum, the two-line text block overflows the pressable, and the bottom line's descenders render below the highlighted background — so they are not covered on hover.
Concrete fix: change height: 52 to minHeight: 52 in styles.typeFilterMenu so the row grows to fit wrapped multi-line labels; the pressable (and therefore the hover-highlight background) then spans the full text height, descenders included. (No change to FilterList.tsx needed.)
Note: this is a purely cosmetic hover-highlight issue on wrapped non-English labels with no functional impact, so DEMOTE would also be a defensible call if a same-checklist fix is not desired.
Activity
applause-bot commentedon Aug 4, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/0989fdd0537f9cb0b53336e40d65329126d70acf5f391a61576a3df887308f20
melvin-bot commentedon Aug 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #97337
melvin-bot commentedon Aug 4, 2026
@JS00001 @shubham1206agra you have been assigned to this deploy blocker because you reviewed the offending PR: #97337
melvin-bot commentedon Aug 4, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Aug 4, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #97337 - "Add search filters for Custom Field 1, Custom Field 2, and International Reimbursement IDs" by @MelvinBot (High confidence that it exposes the bug; the underlying style is pre-existing)
Related Issues: #95389 (feature request implemented by the PR)
Recommendation: ROLL FORWARD
The root cause is a pre-existing fixed row height in the shared advanced-filters list component (
typeFilterMenu,height: 52) that PR #97337 did not touch — the PR merely added a new filter row whose long Polish/Greek label wraps to two lines and exposes it. The fix is a one-line style change (height→minHeight), which is far simpler and safer than reverting a legitimate feature, and it also cures the latent bug for any other long/localized label.Assigned: @shubham1206agra, @JS00001 (approving reviewers of #97337) — already assigned. The PR author is a bot, so no additional human author to assign.
Labels: No change.
DeployBlockerCashis correct (App deploy) and is kept because this is a frontend bug. There is noDeployBlocker(Web) label to remove.📋 Detailed Analysis
Evidence
common.internationalReimbursementIDsand the genericFilterItemrenderer; it adds no new component or style. Its file list contains onlyCONST, parsers,SearchQueryUtils.ts,SearchUIUtils.ts, form/types, anduseAdvancedSearchFilters.ts— notFilterList.tsxorstyles/index.ts.Identyfikatory zwrotów międzynarodowych(pl.ts#L406) is longer, wraps to two lines, and overflows the fixed-height row so the second line's descenders (y, ó, ą, ż …) fall below the hover-highlight background.Verification
FilterList.tsxFilterItem— the hover highlight is thePressableWithFeedbackbackground, styled bystyles.typeFilterMenu, and the label is a wrapping<Text style={[styles.flex1]}>with nonumberOfLines.styles.typeFilterMenu—flexDirection: 'row',alignItems: 'center', and a hardheight: 52.SearchUIUtils.tsFILTER_VIEW_MAPlabelKey, one of the entries PR Add search filters for Custom Field 1, Custom Field 2, and International Reimbursement IDs #97337 added.Root Cause
typeFilterMenufixes the row atheight: 52. WithalignItems: 'center', single-line labels sit centered and the whole glyph (including descenders) stays inside the 52px pressable, so the hover background covers it. A longer localized label wraps to two lines whose combined line-box height exceeds the available content height (52px minuspaddingVertical: 4). Because the height is fixed rather than a minimum, the two-line text block overflows the pressable, and the bottom line's descenders render below the highlighted background — so they are not covered on hover.Concrete fix: change
height: 52tominHeight: 52instyles.typeFilterMenuso the row grows to fit wrapped multi-line labels; the pressable (and therefore the hover-highlight background) then spans the full text height, descenders included. (No change toFilterList.tsxneeded.)Note: this is a purely cosmetic hover-highlight issue on wrapped non-English labels with no functional impact, so DEMOTE would also be a defensible call if a same-checklist fix is not desired.
23 remaining items
melvin-bot commentedon Aug 16, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Aug 16, 2026
Payment Summary
Resolving PRs:
Fix descender clipping on wrapped advanced-filter labels #97859
Reviewer: @shubham1206agra owed $250 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Aug 18, 2026
Payment Summary
Contributor+: @shubham1206agra due $75 via NewDot
@shubham1206agra do we want to create/update a test case here?
melvin-bot commentedon Aug 21, 2026
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
shubham1206agra commentedon Aug 22, 2026
@mallenexpensify No, no test case update required here
mallenexpensify commentedon Aug 24, 2026
@shubham1206agra in the future, please state 'why' a test case isn't needed. Thx