You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Spend - Canadian Multiple Tax Export icon shows different icon in dropdown menu and Filters #97748
Version Number: 9.4.49-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#97255 Email or phone of affected tester (no customers):sdsiodjnosdjiodsj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Search
Action Performed:
Precondition:
Create a workspace with CAD currency.
Go to staging.new.expensify.com
Go to workspace chat.
Create a report.
Go to Spend > Reports.
Select the report via checkbox.
Click More > Export.
→ Canadian Multiple Tax Export icon shows default export icon.
Exit selection mode.
Click Filter > Exported to.
→ Canadian Multiple Tax Export icon shows custom export icon.
Expected Result:
In Step 6 and 8, Canadian Multiple Tax Export will show the same icon.
Actual Result:
In Step 6, from dropdown menu, Canadian Multiple Tax Export icon shows default export icon.
In Step 8, from Filters, Canadian Multiple Tax Export icon shows custom export icon.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #97255 - "Add Canadian Multiple Tax Export template to New Expensify for workspaces using CAD" by @dukenv0307 (High confidence) Related Issues: #97231 (the feature issue this PR implemented)
Recommendation: ROLL FORWARD
The bug is a cosmetic icon mismatch caused by one list not being updated when the new template was added. A one-line fix (registering MULTIPLE_TAX_EXPORT in the Filters selector's standard-template map) is far simpler and safer than reverting the entire CAD export feature.
Assigned: @dukenv0307 (PR author), @NikkiWines, @thelullabyy, @trjExpensify (approving reviewers) — already assigned by melvin-bot. Labels: No change. DeployBlockerCash is kept — this is an App-side bug and the issue is N/A on production (new feature).
📋 Detailed Analysis
Evidence
PR #97255 introduced the "Canadian Multiple Tax Export" template. It added the new option MULTIPLE_TAX_EXPORT and wired it into two places:
The export template builder getExportTemplates in src/libs/actions/Search.ts, where it is pushed into the default templates group for CAD workspaces.
The exported-to filter selector, by adding outputCurrency to exportedToPoliciesSelector in src/hooks/useExportedToFilterOptions.ts so the CAD template surfaces in the "Exported to" filter.
However, the PR did not update the separate, hard-coded standard-template classification map used by the Filters UI to pick the icon. The two lists (bulk-export dropdown vs. Filters) decide "default icon vs. custom icon" using two independent sources of truth, and only one was updated. The bug reproduces on staging only (new feature, N/A in production), matching a frontend feature regression.
Verification
The bug is an icon inconsistency between two lists. The two icon-selection code paths:
The template reaches the Filters list because both the selector and useExportedToFilterOptions build options via useCombinedExportTemplates → getExportTemplates, which now emits MULTIPLE_TAX_EXPORT for CAD policies (src/libs/actions/Search.ts L1758-1759):
PR #97255 did not modify ExportedToSelector.tsx nor AccountingUtils.ts, which is exactly why the classification diverged.
Root Cause
There are two independent definitions of "which export templates are standard/default" for icon selection:
The bulk-export dropdown derives it dynamically from getExportTemplates' defaultTemplates group (updated by the PR).
The Filters selector derives it from a static allowlist STANDARD_EXPORT_TEMPLATE_ID_TO_DISPLAY_LABEL (not updated by the PR).
Because MULTIPLE_TAX_EXPORT was added to the former but not the latter, the dropdown treats it as a default template (Table icon) while the Filters list treats it as a custom template (TablePencil icon), producing the reported mismatch.
Suggested fix
Add MULTIPLE_TAX_EXPORT to STANDARD_EXPORT_TEMPLATE_ID_TO_DISPLAY_LABEL in src/components/Search/FilterComponents/ExportedToSelector.tsx (line 31), and add a corresponding EXPORT_OPTION_LABELS.MULTIPLE_TAX_EXPORT entry in src/CONST/index.ts if a display label is required. For robustness, also consider adding it to STANDARD_EXPORT_TEMPLATE_NAME_MAPPING in src/libs/AccountingUtils.ts (L32-34) so the filter value/display name stays consistent with the other standard templates:
Activity
applause-bot commentedon Aug 4, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/5ad7c2179d5d6bb93ebbce92cfe222b5f1577f9613b1f2f4bb5c517b4b9ab614
melvin-bot commentedon Aug 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #97255
melvin-bot commentedon Aug 4, 2026
@NikkiWines @thelullabyy @trjExpensify you have been assigned to this deploy blocker because you reviewed the offending PR: #97255
melvin-bot commentedon Aug 4, 2026
@dukenv0307 you have been assigned to this deploy blocker because you authored the offending PR: #97255
melvin-bot commentedon Aug 4, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Aug 4, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #97255 - "Add Canadian Multiple Tax Export template to New Expensify for workspaces using CAD" by @dukenv0307 (High confidence)
Related Issues: #97231 (the feature issue this PR implemented)
Recommendation: ROLL FORWARD
The bug is a cosmetic icon mismatch caused by one list not being updated when the new template was added. A one-line fix (registering
MULTIPLE_TAX_EXPORTin the Filters selector's standard-template map) is far simpler and safer than reverting the entire CAD export feature.Assigned: @dukenv0307 (PR author), @NikkiWines, @thelullabyy, @trjExpensify (approving reviewers) — already assigned by melvin-bot.
Labels: No change.
DeployBlockerCashis kept — this is an App-side bug and the issue is N/A on production (new feature).📋 Detailed Analysis
Evidence
PR #97255 introduced the "Canadian Multiple Tax Export" template. It added the new option
MULTIPLE_TAX_EXPORTand wired it into two places:getExportTemplatesinsrc/libs/actions/Search.ts, where it is pushed into the default templates group for CAD workspaces.outputCurrencytoexportedToPoliciesSelectorinsrc/hooks/useExportedToFilterOptions.tsso the CAD template surfaces in the "Exported to" filter.However, the PR did not update the separate, hard-coded standard-template classification map used by the Filters UI to pick the icon. The two lists (bulk-export dropdown vs. Filters) decide "default icon vs. custom icon" using two independent sources of truth, and only one was updated. The bug reproduces on staging only (new feature, N/A in production), matching a frontend feature regression.
Verification
The bug is an icon inconsistency between two lists. The two icon-selection code paths:
Bulk-export dropdown (More > Export) —
src/hooks/useExportActions.ts:const isDefaultTemplate = defaultTemplates.includes(template);icon: isDefaultTemplate ? expensifyIcons.Table : expensifyIcons.TablePencil,defaultTemplatescomes fromgetExportTemplates, which PR Add Canadian Multiple Tax Export template to New Expensify for workspaces using CAD #97255 updated to includeMULTIPLE_TAX_EXPORT. So here it IS a default template → getsTable(the plain/default export icon).App/src/hooks/useExportActions.ts
Lines 206 to 209 in 95d364f
Filters "Exported to" list —
src/components/Search/FilterComponents/ExportedToSelector.tsx:const STANDARD_EXPORT_TEMPLATE_ID_TO_DISPLAY_LABELmaps onlyREPORT_LEVEL_EXPORTandEXPENSE_LEVEL_EXPORT— notMULTIPLE_TAX_EXPORT.const isStandardTemplate = !!STANDARD_EXPORT_TEMPLATE_ID_TO_DISPLAY_LABEL[template.templateName];leftElement: tableIconForExportOption(isStandardTemplate ? expensifyIcons.Table : expensifyIcons.TablePencil),MULTIPLE_TAX_EXPORTis absent from that map,isStandardTemplateisfalse→ getsTablePencil(the custom export icon).App/src/components/Search/FilterComponents/ExportedToSelector.tsx
Line 31 in 95d364f
App/src/components/Search/FilterComponents/ExportedToSelector.tsx
Lines 114 to 118 in 95d364f
The template reaches the Filters list because both the selector and
useExportedToFilterOptionsbuild options viauseCombinedExportTemplates→getExportTemplates, which now emitsMULTIPLE_TAX_EXPORTfor CAD policies (src/libs/actions/Search.tsL1758-1759):App/src/libs/actions/Search.ts
Lines 1758 to 1759 in 95d364f
PR #97255 did not modify
ExportedToSelector.tsxnorAccountingUtils.ts, which is exactly why the classification diverged.Root Cause
There are two independent definitions of "which export templates are standard/default" for icon selection:
getExportTemplates'defaultTemplatesgroup (updated by the PR).STANDARD_EXPORT_TEMPLATE_ID_TO_DISPLAY_LABEL(not updated by the PR).Because
MULTIPLE_TAX_EXPORTwas added to the former but not the latter, the dropdown treats it as a default template (Tableicon) while the Filters list treats it as a custom template (TablePencilicon), producing the reported mismatch.Suggested fix
Add
MULTIPLE_TAX_EXPORTtoSTANDARD_EXPORT_TEMPLATE_ID_TO_DISPLAY_LABELinsrc/components/Search/FilterComponents/ExportedToSelector.tsx(line 31), and add a correspondingEXPORT_OPTION_LABELS.MULTIPLE_TAX_EXPORTentry insrc/CONST/index.tsif a display label is required. For robustness, also consider adding it toSTANDARD_EXPORT_TEMPLATE_NAME_MAPPINGinsrc/libs/AccountingUtils.ts(L32-34) so the filter value/display name stays consistent with the other standard templates:App/src/libs/AccountingUtils.ts
Lines 32 to 34 in 95d364f
arosiclair commentedon Aug 4, 2026
Fixed in v9.4.49-3