You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android- Filters - "You appear to be offline" is not shown for the first filter #97824
Version Number: v9.4.49-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#97337 Email or phone of affected tester (no customers):applausetester+ds@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Android 16 App Component: Search
Action Performed:
Precondition: You have access to a workspace with reports/expenses that have Custom Field 1, Custom Field 2, and/or International Reimbursement ID values set.
Turn off your network connection.
2.. Go to the Reports (or Expenses) Search page.
3.. Open the search Filters and scroll the filter list.
Tap Custom field 1, enter a value, and press Save/Confirm.
Expected Result:
"You Appear To Be Offline" full page is shown
Actual Result:
"You Appear To Be Offline" full page is not shown in the first filter. It is shown after the first filter
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug (fix belongs in Expensify/App) Causing PR: #97337 - "Add search filters for Custom Field 1, Custom Field 2, and International Reimbursement IDs" by @MelvinBot (Low confidence — this PR surfaced the issue but did not introduce the offline‑indicator behavior) Related Issues: #95389 (the feature request implemented by #97337)
Recommendation: ROLL FORWARD
The missing offline indicator is a pre‑existing screen‑transition timing behavior in the shared ScreenWrapper / advanced‑filters content page, not a regression introduced by #97337. Reverting #97337 would NOT fix this — the identical behavior already exists in production for the older text filters (Title, Report ID, Description), which use the exact same page. If it is fixed, it must be a targeted change in the shared offline‑indicator code path (see below). Given it is a minor, non‑regression display‑timing issue with no functional impact, this is also a reasonable DEMOTE candidate for the BugZero team to consider.
Assigned: No assignees added by me — confidence that #97337caused the bug is Low, so per triage guidance I did not assign its contributors. (@JS00001 and @shubham1206agra were already auto‑assigned as reviewers.) Labels: No change. Kept DeployBlockerCash (this is a frontend/App bug). No DeployBlocker (Web) label is present, so nothing to remove.
It registers submitterUserID / submitterPayrollID / orderDealNumbers as text filters reusing the existing string‑filter machinery. No new routes, screens, or components (confirmed by the PR description and the diff).
The three new custom‑field filters render through the same generic advanced‑filters content route as the pre‑existing text filters (Title, Report ID, Description), all of which were already in EXPENSE/EXPENSE_REPORT before this PR — see useAdvancedSearchFilters.ts where TITLE and REPORT_ID already sit next to the newly added keys.
Because the code path is shared and unchanged, the "offline indicator not shown on the FIRST filter, shown on subsequent filters" behavior is reproducible with the older Title/Report ID text filters as well — i.e. it is not new to this deploy.
Reproducible on staging; "N/A on production" only because the custom‑field entry points are new, not because the underlying offline behavior is new.
Verification
The offline UI for these filter screens comes entirely from the shared ScreenWrapper in SearchAdvancedFiltersContentBase.tsx (lines 50–56) — shouldShowOfflineIndicatorInWideScreen + default small‑screen indicator.
The text‑input filter body itself, TextInputFilterContent.tsx, has no offline handling at all — so the custom‑field filters cannot be the source of the offline behavior.
The advanced‑filters content page relies on the shared ScreenWrapper offline‑indicator system, whose small‑screen visibility depends on the ScreenWrapperOfflineIndicatorContext value and the screen‑transition/mount state (didScreenTransitionEnd). On the first RHP screen opened after navigating into filters, that shared offline state/context has not settled, so the indicator does not render; on subsequent filter screens it does. This is a pre‑existing timing issue in the shared offline‑indicator plumbing — PR #97337 merely added new entry points (custom‑field filter rows) that QA exercised, which is why it was flagged. A correct fix targets the shared ScreenWrapper / advanced‑filters content offline path (e.g. ensuring the offline indicator visibility does not depend on first‑transition timing), not the custom‑field filter code, and would fix the older text filters at the same time.
Activity
applause-bot commentedon Aug 4, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/869a9d10f9d9cb4de01d937ef0d8f7a9ffdbee916fad7f1c1c784b95781ae2ae
melvin-bot commentedon Aug 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #97337
melvin-bot commentedon Aug 4, 2026
@JS00001 @shubham1206agra you have been assigned to this deploy blocker because you reviewed the offending PR: #97337
melvin-bot commentedon Aug 4, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Aug 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Aug 4, 2026
🔍 Investigation Summary
Classification: Frontend bug (fix belongs in
Expensify/App)Causing PR: #97337 - "Add search filters for Custom Field 1, Custom Field 2, and International Reimbursement IDs" by @MelvinBot (Low confidence — this PR surfaced the issue but did not introduce the offline‑indicator behavior)
Related Issues: #95389 (the feature request implemented by #97337)
Recommendation: ROLL FORWARD
The missing offline indicator is a pre‑existing screen‑transition timing behavior in the shared
ScreenWrapper/ advanced‑filters content page, not a regression introduced by #97337. Reverting #97337 would NOT fix this — the identical behavior already exists in production for the older text filters (Title, Report ID, Description), which use the exact same page. If it is fixed, it must be a targeted change in the shared offline‑indicator code path (see below). Given it is a minor, non‑regression display‑timing issue with no functional impact, this is also a reasonable DEMOTE candidate for the BugZero team to consider.Assigned: No assignees added by me — confidence that #97337 caused the bug is Low, so per triage guidance I did not assign its contributors. (@JS00001 and @shubham1206agra were already auto‑assigned as reviewers.)
Labels: No change. Kept
DeployBlockerCash(this is a frontend/App bug). NoDeployBlocker(Web) label is present, so nothing to remove.📋 Detailed Analysis
Evidence
src/CONST/index.ts,src/components/Search/types.ts,src/hooks/useAdvancedSearchFilters.ts,src/libs/SearchParser/*(peggy + generated.js),src/libs/SearchQueryUtils.ts,src/libs/SearchUIUtils.ts,src/types/form/SearchAdvancedFiltersForm.ts.submitterUserID/submitterPayrollID/orderDealNumbersas text filters reusing the existing string‑filter machinery. No new routes, screens, or components (confirmed by the PR description and the diff).EXPENSE/EXPENSE_REPORTbefore this PR — seeuseAdvancedSearchFilters.tswhereTITLEandREPORT_IDalready sit next to the newly added keys.Verification
ScreenWrapperinSearchAdvancedFiltersContentBase.tsx(lines 50–56) —shouldShowOfflineIndicatorInWideScreen+ default small‑screen indicator.TextInputFilterContent.tsx, has no offline handling at all — so the custom‑field filters cannot be the source of the offline behavior.ScreenWrapper:index.tsx#L184displaySmallScreenOfflineIndicator = isSmallScreenWidth && (shouldShowSmallScreenOfflineIndicator ?? showOnSmallScreens ?? true), with the transition state tracked atindex.tsx#L135. None of these files are in PR Add search filters for Custom Field 1, Custom Field 2, and International Reimbursement IDs #97337.Root Cause
The advanced‑filters content page relies on the shared
ScreenWrapperoffline‑indicator system, whose small‑screen visibility depends on theScreenWrapperOfflineIndicatorContextvalue and the screen‑transition/mount state (didScreenTransitionEnd). On the first RHP screen opened after navigating into filters, that shared offline state/context has not settled, so the indicator does not render; on subsequent filter screens it does. This is a pre‑existing timing issue in the shared offline‑indicator plumbing — PR #97337 merely added new entry points (custom‑field filter rows) that QA exercised, which is why it was flagged. A correct fix targets the sharedScreenWrapper/ advanced‑filters content offline path (e.g. ensuring the offline indicator visibility does not depend on first‑transition timing), not the custom‑field filter code, and would fix the older text filters at the same time.JS00001 commentedon Aug 4, 2026
I dont think this is a blocker
JS00001 commentedon Aug 7, 2026
I can no longer repro this: