Skip to content

[Due for payment 2026-08-21] [$250] [CFI] Company Cards - Expand feed removal confirmation copy to mention deleted unsubmitted transactions #97842

Closed

Description

@MelvinBot

Problem

When an admin removes a card feed, the confirmation modal warns "Are you sure you want to remove this card feed? This will unassign all cards." This undersells the impact: removing a feed also deletes unsubmitted (unreported/draft) transactions. Admins — especially new ones — can trigger a destructive action without understanding the full consequences, and for commercial feeds they currently can't re-add the feed themselves.

Solution

Update the removal confirmation copy to also mention that unsubmitted transactions will be deleted.

Copy key: workspace.companyCards.removeCardFeedDescription in src/languages/en.ts:6338

Current:

Are you sure you want to remove this card feed? This will unassign all cards.

Proposed:

Are you sure you want to remove this card feed? This will unassign all cards and delete unsubmitted transactions.

The modal title (removeCardFeedTitle, e.g. "Remove Mock Bank feed") stays as-is. The Spanish string src/languages/es.ts:6088 should get the equivalent update.

Slack thread: https://expensify.slack.com/archives/C07NMDKEFMH/p1785797681542709

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. trjExpensify commented on Aug 5, 2026

    @trjExpensify
    Contributor

    @MelvinBot draft a proposal for this change.

  2. self-assigned this
    on Aug 5, 2026
  3. changed the title [-]Company Cards - Expand feed removal confirmation copy to mention deleted unsubmitted transactions[/-] [+][CFI] Company Cards - Expand feed removal confirmation copy to mention deleted unsubmitted transactions[/+] on Aug 5, 2026
  4. MelvinBot commented on Aug 5, 2026

    @MelvinBot
    ContributorAuthor

    Proposal

    What is the root cause of that problem?

    The feed-removal confirmation copy only mentions one of the two destructive side effects. Removing a card feed both unassigns all cards and deletes unsubmitted (unreported/draft) transactions, but the confirmation string only warns about the first. As a result an admin can confirm a destructive delete without understanding the full consequences.

    The string is rendered as the prompt of the confirm modal in WorkspaceCompanyCardsSettingsPage.tsx:221, which resolves to the workspace.moreFeatures.companyCards.removeCardFeedDescription key. (Note: the correct key path is workspace.moreFeatures.companyCards.…, not workspace.companyCards.… as written in the issue body — the line numbers cited are correct.)

    The gap is only in the copy — the sibling card-level strings already spell out this behavior, e.g. unassignCardDescription ("Unassigning this card will remove all unsubmitted transactions"), so the feed-level string is simply out of step.

    What changes do you think we should make in order to solve the problem?

    Update the confirmation description in both language files to also mention deleted unsubmitted transactions. Title (removeCardFeedTitle) stays unchanged.

    English — src/languages/en.ts:6338:

    • Current: Are you sure you want to remove this card feed? This will unassign all cards.
    • Proposed: Are you sure you want to remove this card feed? This will unassign all cards and delete unsubmitted transactions.

    Spanish — src/languages/es.ts:6088:

    • Current: ¿Estás seguro de que deseas eliminar esta fuente de tarjetas? Esto anulará la asignación de todas las tarjetas.
    • Proposed: ¿Estás seguro de que deseas eliminar esta fuente de tarjetas? Esto anulará la asignación de todas las tarjetas y eliminará las transacciones no enviadas.

    The Spanish wording reuses the existing convention "transacciones no enviadas" already used in the neighboring unassignCardDescription string, so it stays consistent across the company-cards flow.

    This is a copy-only change in the two src/languages/*.ts files — no component or logic changes are required.

    What alternative solutions did you explore? (Optional)

    • List both consequences on separate lines / as bullets for extra clarity. Rejected as heavier than needed — a single appended clause matches the phrasing style of the sibling card strings and keeps the modal compact.
    • Also address the "can't re-add commercial feeds themselves" concern raised in the issue background. That's a separate functional gap (not copy) and out of scope for this copy update; it should be tracked separately if desired.

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/97842#issuecomment-5186067361) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.

  5. changed the title [-][CFI] Company Cards - Expand feed removal confirmation copy to mention deleted unsubmitted transactions[/-] [+][$50] [CFI] Company Cards - Expand feed removal confirmation copy to mention deleted unsubmitted transactions[/+] on Aug 10, 2026
  6. melvin-bot commented on Aug 10, 2026

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 10, 2026
  8. melvin-bot commented on Aug 10, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  9. melvin-bot commented on Aug 10, 2026

    @melvin-bot
  10. 14 remaining items

  11. changed the title [-][$250] [CFI] Company Cards - Expand feed removal confirmation copy to mention deleted unsubmitted transactions[/-] [+][Due for payment 2026-08-21] [$250] [CFI] Company Cards - Expand feed removal confirmation copy to mention deleted unsubmitted transactions[/+] on Aug 14, 2026
  12. melvin-bot commented on Aug 14, 2026

    @melvin-bot

    @hoangzinh

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.53-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-08-21. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  13. hoangzinh commented on Aug 17, 2026

    @hoangzinh
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: It's a feature request

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      We probably don't need a regression test for this update; but if we need, here it is:

    Regression Test Proposal

    Test:

    1. Go to a workspace with a company card feed → Company cards → feed settings.
    2. Click Remove card feed.
    3. Verify the confirmation modal shows: "Are you sure you want to remove this card feed? This will unassign all cards and delete unsubmitted transactions."

    Do we agree 👍 or 👎

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Aug 17, 2026
  15. melvin-bot commented on Aug 20, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  16. melvin-bot commented on Aug 20, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  17. mallenexpensify commented on Aug 21, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @hoangzinh due $250 via NewDot

  18. laurenreidexpensify commented on Aug 25, 2026

    @laurenreidexpensify
    Contributor

    $250 approved @hoangzinh New Expensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions