Skip to content

[Due for payment 2026-08-25] [$250] Add Expensify Card spend rules to Announcements (product update — newsletter) #98001

Closed

Description

@melvin-bot

Add the Expensify Card spend rules launch to the in-product Announcements section as a product update / newsletter.

Sub-issue of Expensify/Expensify#666229. Requested by danielrvidal. Needs to be live by Mon Aug 17.

Announcements update details

cc @jamesdeanexpensify

Reported in Slack.

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 6, 2026
  2. melvin-bot commented on Aug 6, 2026

    @melvin-bot
    Author

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @bernhardoj (External)

  3. melvin-bot commented on Aug 6, 2026

    @melvin-bot
    Author
  4. melvin-bot commented on Aug 8, 2026

    @melvin-bot
    Author

    📣 @Jotanune! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  5. atlascraft-codex commented on Aug 8, 2026

    @atlascraft-codex

    Proposal

    What is the root cause of that problem?

    The Home page already renders its Announcements section from the static
    CONST.HOME.ANNOUNCEMENTS list. AnnouncementSection.tsx sorts that list by
    publishedDate, displays title and subtitle, and opens the supplied url.
    There is no entry yet for the August 17 Expensify Card spend-rules update, so
    the existing UI has nothing to display. This is a content/data gap rather than
    a missing component or API.

    What changes do you think we should make in order to solve the problem?

    Once the final blog URL is available, add one item to
    CONST.HOME.ANNOUNCEMENTS with:

    • title: Control card spend before it happens
    • subtitle: Product update
    • published date: 2026-08-17
    • URL: the final link supplied by the product team

    No component or translation change is needed because the current entries use
    the same literal fields and the section already handles ordering and links.
    Verify that the item appears first on both wide and narrow Home layouts and
    that selecting it opens the final HTTPS URL.

    One rollout detail matters: the section does not currently hide future-dated
    entries. To avoid announcing the launch early or linking to a missing page, the
    change should merge/release only after the final blog URL is live and timed for
    August 17, rather than adding unrelated date-gating logic to this small update.

    What alternative solutions did you explore? (Optional)

    Adding a new component, API, translation key, or general scheduled-publishing
    system would widen the scope without improving this single announcement. The
    existing static list already provides the required behavior.

  6. melvin-bot commented on Aug 8, 2026

    @melvin-bot
    Author

    📣 @atlascraft-codex! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  7. danielrvidal commented on Aug 10, 2026

    @danielrvidal
    Contributor

    @bernhardoj does the proposal above look okay? We'll need to get started on this asap to make sure it's ready next week.

  8. self-assigned this
    on Aug 10, 2026
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 10, 2026
  10. yusufdeveloper2903 commented on Aug 10, 2026

    @yusufdeveloper2903
    Contributor

    Proposal

    What is the root cause of that problem?

    This is a content addition rather than a bug, so let me first explain where the in-product Announcements section gets its data, then map the requested launch onto it.

    The "Announcements" widget on the Home screen is rendered by AnnouncementSection, which reads a hardcoded array and renders one MenuItemWithTopDescription per entry:

    {announcements.map((announcement) => (
    <MenuItemWithTopDescription
    key={announcement.title}
    description={announcement.subtitle}
    title={announcement.title}
    titleStyle={styles.textBold}
    onPress={() => Linking.openURL(announcement.url)}
    shouldShowRightIcon
    leftComponent={<DateIcon date={announcement.publishedDate} />}
    wrapperStyle={[styles.alignItemsCenter, shouldUseNarrowLayout ? styles.ph5 : styles.ph8]}
    hasSubMenuItems
    viewMode={CONST.OPTION_MODE.COMPACT}
    rightIconWrapperStyle={styles.pl2}
    shouldCheckActionAllowedOnPress={false}
    />
    ))}

    That array is CONST.HOME.ANNOUNCEMENTS — a static list of plain object literals, one per product update / press release, defined here:

    App/src/CONST/index.ts

    Lines 9311 to 9330 in 63a8989

    ANNOUNCEMENTS: [
    {
    title: 'Scoped admin roles, plus HR & AI updates',
    subtitle: 'Product update',
    url: 'https://use.expensify.com/blog/expensify-july-2026-product-update',
    publishedDate: '2026-07-28',
    },
    {
    title: 'The Expensify Card: Now in the UK & EU',
    subtitle: 'Press release',
    url: 'https://www.businesswire.com/news/home/20260720653615/en/Expensify-Launches-Corporate-Card-in-Europe',
    publishedDate: '2026-07-20',
    },
    {
    title: 'New feature: Consolidated travel billing',
    subtitle: 'Press release',
    url: 'https://www.businesswire.com/news/home/20260713695836/en/Expensify-Launches-Consolidated-Travel-Billing-to-Simplify-How-Companies-Pay-for-Business-Travel',
    publishedDate: '2026-07-13',
    },
    ],

    Each entry has exactly four string fields, and the four fields marketing supplied in this issue map one-to-one onto them:

    • title ← Title copy (Control card spend before it happens)
    • subtitle ← Type — the free-form category label shown as the top description (existing entries use 'Product update' / 'Press release')
    • url ← Link — opened via Linking.openURL on tap
    • publishedDate ← Date (2026-08-17), a YYYY-MM-DD string

    The list is sorted by publishedDate descending before rendering, and DateIcon renders that same date as the left icon:

    const announcements = CONST.HOME.ANNOUNCEMENTS.toSorted((a, b) => {
    if (a.publishedDate > b.publishedDate) {
    return -1;
    }
    if (a.publishedDate < b.publishedDate) {
    return 1;
    }
    return 0;
    });

    So there is nothing broken — there is simply no entry yet for the Aug 17 Expensify Card spend rules launch. Adding one object to CONST.HOME.ANNOUNCEMENTS is the whole change.

    In short: the Announcements widget maps over the static CONST.HOME.ANNOUNCEMENTS array → the launch has no entry there → it doesn't appear → adding one {title, subtitle, url, publishedDate} entry surfaces it.

    What changes do you think we should make in order to solve the problem?

    We should add one entry to CONST.HOME.ANNOUNCEMENTS at src/CONST/index.ts:9311:

     ANNOUNCEMENTS: [
    +    {
    +        title: 'Control card spend before it happens',
    +        subtitle: 'Product update',
    +        url: 'https://use.expensify.com/blog/<final-spend-rules-post-slug>',
    +        publishedDate: '2026-08-17',
    +    },
         {
             title: 'Scoped admin roles, plus HR & AI updates',
             subtitle: 'Product update',
             url: 'https://use.expensify.com/blog/expensify-july-2026-product-update',
             publishedDate: '2026-07-28',
         },

    Insertion position within the array is cosmetic — AnnouncementSection re-sorts by publishedDate descending, so 2026-08-17 renders at the top of the list regardless of where the object is placed. I put it first only to match the existing newest-first authoring order.

    This is safe because:

    • title, subtitle, and url are consumed as raw strings (description={announcement.subtitle}, title={announcement.title}, Linking.openURL(announcement.url)) — AnnouncementSection.tsx:33-48 — so no translation keys are required (these entries are intentionally not localized, matching the three existing ones).
    • The entry shape is validated at compile time: CONST is an as const object, so an object missing a field or with a wrong type fails typecheck — no separate type/enum needs touching.
    • key={announcement.title} is unique, and the new title differs from every existing one, so no React key collision.
    • The DateIcon and descending sort both key off publishedDate, so supplying '2026-08-17' correctly dates the icon and positions the row without any other change.

    Note on the two values still pending from marketing:

    • Link is TBD in the issue ("ETA early next week"). The url above is a placeholder and this must not merge until the final blog URL is supplied — an empty/placeholder url would Linking.openURL to a dead link.
    • Type/subtitle: the issue titles this a "product update — newsletter". The App list has no 'Newsletter' category today; the closest existing convention is 'Product update', which I used. If marketing wants the literal label Newsletter shown as the description, set subtitle: 'Newsletter' instead — it is free-form text, so either works with no other change.

    What alternative solutions did you explore? (Optional)

    A separate, richer mechanism exists — the one-at-a-time promotional popup driven by ACTIVE_PRODUCT_MARKETING_ANNOUNCEMENT in ProductMarketingWindowUtils.ts (ProductMarketingWindow). It is tempting because its type is literally named ProductMarketingAnnouncement, but it is the wrong surface here: it is a dismissible, audience-targeted, localized bottom-right popup keyed by updateKey with an in-app CTA route and heading/body/ctaLabel translation paths — it has no date, no subtitle/type label, and no external url field. The issue's four supplied fields (Date, Type, Title copy, Link) match the CONST.HOME.ANNOUNCEMENTS entry shape exactly and not the popup's, so the Home Announcements list is the correct target.

  11. 36 remaining items

  12. yusufdeveloper2903 commented on Aug 18, 2026

    @yusufdeveloper2903
    Contributor

    Works for me too, $125 is fine. Thanks

  13. jamesdeanexpensify commented on Aug 18, 2026

    @jamesdeanexpensify
    Contributor

    I'm not involved with payment, but @stitesExpensify do you know who would issue that?

  14. yusufdeveloper2903 commented on Aug 20, 2026

    @yusufdeveloper2903
    Contributor

    @mallenexpensify could you please help with payment here? We agreed on $125 for this one

  15. yusufdeveloper2903 commented on Aug 24, 2026

    @yusufdeveloper2903
    Contributor

    @mallenexpensify friendly bump 🙏

  16. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Aug 25, 2026
  17. changed the title [-][$250] Add Expensify Card spend rules to Announcements (product update — newsletter)[/-] [+][Due for payment 2026-08-25] [$250] Add Expensify Card spend rules to Announcements (product update — newsletter)[/+] on Aug 25, 2026
  18. melvin-bot commented on Aug 25, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  19. mallenexpensify commented on Aug 25, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @yusufdeveloper2903 paid $125 via Upwork
    Contributor+: @bernhardoj due $125 via NewDot

    @yusufdeveloper2903 can you please accept the job below? Please reply here and tag me once you have.
    If you're not sent an offer in Upwork when you're assigned to an issue, please tag me. If an Upwork job exists, please submit a proposal.
    https://www.upwork.com/jobs/~022085426694190480370

  20. yusufdeveloper2903 commented on Aug 25, 2026

    @yusufdeveloper2903
    Contributor

    @mallenexpensify Thanks! I've accepted the job offer on Upwork

  21. mallenexpensify commented on Aug 25, 2026

    @mallenexpensify
    Contributor

    @yusufdeveloper2903 paid, summary updated above. Thx.

  22. flaviadefaria commented on Sep 2, 2026

    @flaviadefaria
    Contributor

    Approved: @bernhardoj due $125 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions